[WIP] Cycles: optimizationS for Tabulated-Sobol sampler #119575

Odilkhon Yakubov · 2024-03-16T20:23:36+01:00

Odilkhon Yakubov commented

2024-03-16 20:23:36 +01:00

First-time contributor

Improved code quality and some optimizations

Odilkhon Yakubov added 1 commit 2024-03-16 20:23:45 +01:00

a54c6bf726 Cycles: optimization for Tabulated-Sobol sampler

Improved code quality and some optimizations

Iliya Katushenock added this to the Render & Cycles project 2024-03-16 20:25:33 +01:00

Jesse Yurkovich commented

2024-03-16 21:16:58 +01:00

Like your previous PR which was closed[1], you need to provide more information on what this patch does, why it is better, and provide proof of benefit across several scenes.

This patch will be closed if this information is not provided.

[1] #116951 (comment)

Like your previous PR which was closed[1], you need to provide more information on what this patch does, why it is better, and provide proof of benefit across several scenes. This patch will be closed if this information is not provided. [1] https://projects.blender.org/blender/blender/pulls/116951#issuecomment-1099404

Alaska commented

2024-03-17 14:04:09 +01:00

Along with the comment from @deadpin , it seems a lot of your "additions and subtractions" are white space changes and the removal of code comments. This makes it harder to identify exactly what changed, making it harder to review.

If the code comment is still applicable, then keep it in. As for the white space changes, please run make format before committing the changes.

Along with the comment from @deadpin , it seems a lot of your "additions and subtractions" are white space changes and the removal of code comments. This makes it harder to identify exactly what changed, making it harder to review. If the code comment is still applicable, then keep it in. As for the white space changes, please run `make format` before committing the changes.

Odilkhon Yakubov commented

2024-03-18 03:16:43 +01:00

First-time contributor

@deadpin @Alaska Thanks for feedback!

Odilkhon Yakubov closed this pull request

2024-03-18 03:16:46 +01:00

Alaska commented

2024-03-18 04:51:14 +01:00

@odil24 did you mean to close this pul request?

Odilkhon Yakubov commented

2024-03-18 09:05:06 +01:00

First-time contributor

@odil24 did you mean to close this pul request?

I mean just close for sometimes when I will finish then reopen again

> @odil24 did you mean to close this pul request? I mean just close for sometimes when I will finish then reopen again

Alaska commented

2024-03-18 11:35:03 +01:00

@odil24 if a pull is work in progress, then you can name it WIP: Name of your pull request to let people know it's not ready for review.

If you need to make some changes, but they will be done quickly (E.G. within a day or two), you can leave the pull request open, make the changes you need, then commit and push them to the branch you're using for this pull request.

If you need to make some changes, and they're going to take many days, then it's best to leave the pull request open and just let people know you're working on it, either with a comment or with the WIP title thing mentioned above.

@odil24 if a pull is work in progress, then you can name it `WIP: Name of your pull request` to let people know it's not ready for review. If you need to make some changes, but they will be done quickly (E.G. within a day or two), you can leave the pull request open, make the changes you need, then commit and push them to the branch you're using for this pull request. If you need to make some changes, and they're going to take many days, then it's best to leave the pull request open and just let people know you're working on it, either with a comment or with the WIP title thing mentioned above.

Odilkhon Yakubov changed title from ~~Cycles: optimization for Tabulated-Sobol sampler~~ to [WIP] Cycles: optimizationS for Tabulated-Sobol sampler

2024-03-18 17:11:58 +01:00

Odilkhon Yakubov reopened this pull request

2024-03-18 17:12:28 +01:00

Odilkhon Yakubov commented

2024-03-18 17:17:09 +01:00

First-time contributor

Please, review the commit:
50011c0bee

Please, review the commit: https://projects.blender.org/blender/blender/commit/50011c0bee216fe51f8295890e4bf2a137684bb3

Thomas Dinges commented

2024-03-21 15:51:02 +01:00

@odil24 Please update this pull request rather than pointing to a commit.

This pull request is marked as a work in progress.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u main:odil24-main

git checkout odil24-main

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

[WIP] Cycles: optimizationS for Tabulated-Sobol sampler #119575

Checkout