blender
/
blender
136
406
Fork 590
Code Issues 6.3k Pull Requests 763 Projects 19 Wiki Activity

Fix: #117320: Correct selection in the UV Editor with Edge Selection and UV Sync #119629

Closed
rui-lin wants to merge 2 commits from rui-lin/blender:uv_edge_selection into main
pull from: rui-lin/blender:uv_edge_selection
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 2 Files Changed 1 +2 -4
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/bmesh/intern/bmesh_marking.cc
View File

@ -484,9 +484,7 @@ void BM_mesh_select_flush(BMesh *bm)
bool ok;
BM_ITER_MESH (e, &eiter, bm, BM_EDGES_OF_MESH) {
if (BM_elem_flag_test(e->v1, BM_ELEM_SELECT) && BM_elem_flag_test(e->v2, BM_ELEM_SELECT) &&
!BM_elem_flag_test(e, BM_ELEM_HIDDEN))
{
if (BM_elem_flag_test(e, BM_ELEM_SELECT) && !BM_elem_flag_test(e, BM_ELEM_HIDDEN)) {
Campbell Barton commented 2024-03-20 03:43:06 +01:00
Review
Copy Link

This breaks flushing vertex to edge selection. It also doesn't make sense to select the edge only if it's already selected.

This breaks flushing vertex to edge selection. It also doesn't make sense to select the edge only if it's already selected.
BM_elem_flag_enable(e, BM_ELEM_SELECT);
}
}
@ -495,7 +493,7 @@ void BM_mesh_select_flush(BMesh *bm)
if (!BM_elem_flag_test(f, BM_ELEM_HIDDEN)) {
l_iter = l_first = BM_FACE_FIRST_LOOP(f);
do {
if (!BM_elem_flag_test(l_iter->v, BM_ELEM_SELECT)) {
if (!BM_elem_flag_test(l_iter->e, BM_ELEM_SELECT)) {
ok = false;
break;
}