Fix #119635: File Browser Horizontal Display Never Compact #119673

Harley Acheson · 2024-03-19T17:58:29+01:00

Harley Acheson commented

2024-03-19 17:58:29 +01:00

File Browser listings can clip content, remove columns, etc as the
available space narrows. This PR just makes this never happen for
the horizontal display mode, where files are shown in multiple columns,
as this is not applicable.

There are a few ways to fix this issue, but this PR seems the simplest and most logical. It just adds "only in vertical list mode" to three Boolean macros that control this behavior when the space narrows. It should read nicely.

This issue could also be fixed by replacing "layout->width" with "layout->tile_w" in the same macros, but that would look a bit weirder. These two values are kept properly in sync, so this would work, but the tile width is only meant to be used at times where this display narrowing is actually not applicable. So it would work but look confusing.

Careful readers of the complaint will notice this problem only occurs on the first paint of the file list, and it works properly if you make any change including slightly resizing the window. So it starts broken then corrects itself. This is because during the initial setup of the layout in ED_fileselect_init_layout the number of files is -1 which in FILE_HORIZONTALDISPLAY results in incorrect values for flow_columns and width, which are corrected shortly afterward. But this makes no difference to this mode, which doesn't use width anyway. And also a bit confusing to make a "correction" here for something unrelated and not applicable.

File Browser listings can clip content, remove columns, etc as the available space narrows. This PR just makes this never happen for the horizontal display mode, where files are shown in multiple columns, as this is not applicable. --- There are a few ways to fix this issue, but this PR seems the simplest and most logical. It just adds "only in vertical list mode" to three Boolean macros that control this behavior when the space narrows. It should read nicely. This issue could also be fixed by replacing "layout->width" with "layout->tile_w" in the same macros, but that would look a bit weirder. These two values are kept properly in sync, so this would work, but the tile width is only meant to be used at times where this display narrowing is actually not applicable. So it would work but look confusing. Careful readers of the complaint will notice this problem only occurs on the first paint of the file list, and it works properly if you make any change including slightly resizing the window. So it starts broken then corrects itself. This is because during the initial setup of the layout in `ED_fileselect_init_layout` the number of files is `-1` which in FILE_HORIZONTALDISPLAY results in incorrect values for flow_columns and width, which are corrected shortly afterward. But this makes no difference to this mode, which doesn't use width anyway. And also a bit confusing to make a "correction" here for something unrelated and not applicable.

Harley Acheson added this to the User Interface project 2024-03-19 18:00:17 +01:00

Harley Acheson requested review from Hans Goudey 2024-03-19 18:11:45 +01:00

Harley changed target branch from main to blender-v4.1-release

2024-03-20 02:27:39 +01:00

Harley changed target branch from blender-v4.1-release to main

2024-03-20 02:27:59 +01:00

Pratik Borhade added this to the 4.1 milestone 2024-03-20 10:02:19 +01:00

Hans Goudey approved these changes 2024-03-20 13:48:26 +01:00

Thomas Dinges commented

2024-03-20 13:54:42 +01:00

This should go into 4.1 as well.

Harley Acheson force-pushed Fix119635 from c4306b27d5 to 82b13babb4

2024-03-20 16:24:02 +01:00

Compare

Harley changed target branch from main to blender-v4.1-release

2024-03-20 16:24:26 +01:00

Harley Acheson commented

2024-03-20 16:25:26 +01:00

@blender-bot build

Harley Acheson merged commit afbd733047 into blender-v4.1-release

2024-03-20 17:06:46 +01:00

Harley Acheson referenced this issue from a commit

2024-03-20 17:06:47 +01:00

Fix #119635: File Browser Horizontal Display Never Compact

Harley Acheson deleted branch Fix119635

2024-03-20 17:06:52 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #119635: File Browser Horizontal Display Never Compact #119673