Fix #119635: File Browser Horizontal Display Never Compact #119673

Merged
Harley Acheson merged 1 commits from Harley/blender:Fix119635 into blender-v4.1-release 2024-03-20 17:06:46 +01:00
Member

File Browser listings can clip content, remove columns, etc as the
available space narrows. This PR just makes this never happen for
the horizontal display mode, where files are shown in multiple columns,
as this is not applicable.


There are a few ways to fix this issue, but this PR seems the simplest and most logical. It just adds "only in vertical list mode" to three Boolean macros that control this behavior when the space narrows. It should read nicely.

This issue could also be fixed by replacing "layout->width" with "layout->tile_w" in the same macros, but that would look a bit weirder. These two values are kept properly in sync, so this would work, but the tile width is only meant to be used at times where this display narrowing is actually not applicable. So it would work but look confusing.

Careful readers of the complaint will notice this problem only occurs on the first paint of the file list, and it works properly if you make any change including slightly resizing the window. So it starts broken then corrects itself. This is because during the initial setup of the layout in ED_fileselect_init_layout the number of files is -1 which in FILE_HORIZONTALDISPLAY results in incorrect values for flow_columns and width, which are corrected shortly afterward. But this makes no difference to this mode, which doesn't use width anyway. And also a bit confusing to make a "correction" here for something unrelated and not applicable.

File Browser listings can clip content, remove columns, etc as the available space narrows. This PR just makes this never happen for the horizontal display mode, where files are shown in multiple columns, as this is not applicable. --- There are a few ways to fix this issue, but this PR seems the simplest and most logical. It just adds "only in vertical list mode" to three Boolean macros that control this behavior when the space narrows. It should read nicely. This issue could also be fixed by replacing "layout->width" with "layout->tile_w" in the same macros, but that would look a bit weirder. These two values are kept properly in sync, so this would work, but the tile width is only meant to be used at times where this display narrowing is actually not applicable. So it would work but look confusing. Careful readers of the complaint will notice this problem only occurs on the first paint of the file list, and it works properly if you make any change including slightly resizing the window. So it starts broken then corrects itself. This is because during the initial setup of the layout in `ED_fileselect_init_layout` the number of files is `-1` which in FILE_HORIZONTALDISPLAY results in incorrect values for flow_columns and width, which are corrected shortly afterward. But this makes no difference to this mode, which doesn't use width anyway. And also a bit confusing to make a "correction" here for something unrelated and not applicable.
Harley Acheson added this to the User Interface project 2024-03-19 18:00:17 +01:00
Harley Acheson requested review from Hans Goudey 2024-03-19 18:11:45 +01:00
Harley Acheson changed target branch from main to blender-v4.1-release 2024-03-20 02:27:39 +01:00
Harley Acheson changed target branch from blender-v4.1-release to main 2024-03-20 02:27:59 +01:00
Pratik Borhade added this to the 4.1 milestone 2024-03-20 10:02:19 +01:00
Hans Goudey approved these changes 2024-03-20 13:48:26 +01:00

This should go into 4.1 as well.

This should go into 4.1 as well.
Harley Acheson force-pushed Fix119635 from c4306b27d5 to 82b13babb4 2024-03-20 16:24:02 +01:00 Compare
Harley Acheson changed target branch from main to blender-v4.1-release 2024-03-20 16:24:26 +01:00
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit afbd733047 into blender-v4.1-release 2024-03-20 17:06:46 +01:00
Harley Acheson deleted branch Fix119635 2024-03-20 17:06:52 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119673
No description provided.