Curves: Bezier handle selection support

Removing small optimization to reduce complexity, because even assert for it caused crashes.

@@ -922,3 +924,1 @@
-          ".selection", bke::AttrDomain::Curve);
-      selection.varray.set(curve_index, true);
-      selection.finish();
+      /* If Bezier curve is being added, loop through all three ids.  */

@@ -986,12 +1002,24 @@ static int curves_draw_exec(bContext *C, wmOperator *op)
     selection.varray.set(curve_index, true);
     selection.finish();
 
+    /* Creates ".selection_handle_left" and ".selection_handle_right" attributes, otherwise all

@@ -988,1 +1004,4 @@
 
+    /* Creates ".selection_handle_left" and ".selection_handle_right" attributes, otherwise all
+     * existing Bezier handles would be treated as selected. */
+    for (const int i : selection_attribute_ids.index_range().drop_front(1)) {

@@ -50,6 +50,58 @@ float (*ED_curves_point_normals_array_create(const Curves *curves_id))[3];
 
 namespace blender::ed::curves {
 
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids(const bke::CurvesGeometry &curves);

@@ -51,2 +51,4 @@
 namespace blender::ed::curves {
 
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids(const bke::CurvesGeometry &curves);
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids(const int size);

@@ -52,1 +52,4 @@
 
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids(const bke::CurvesGeometry &curves);
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids(const int size);
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids();

@@ -53,0 +54,4 @@
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids(const int size);
+Span<bke::AttributeIDRef> get_curves_selection_attribute_ids();
+
+class SelectionAttributeWriterList {

@@ -53,0 +63,4 @@
+                               const bke::AttrDomain selection_domain);
+  ~SelectionAttributeWriterList();
+
+  inline const Span<bke::AttributeIDRef> &attribute_ids() const

@@ -53,0 +67,4 @@
+  {
+    return attribute_ids_;
+  }
+  inline const int size() const

@@ -53,0 +90,4 @@
+  }
+};
+
+typedef std::function<void(

@@ -53,0 +91,4 @@
+};
+
+typedef std::function<void(
+    const IndexRange range, const Span<float3> positions, const int selection_attribute_index)>

@@ -53,0 +94,4 @@
+    const IndexRange range, const Span<float3> positions, const int selection_attribute_index)>
+    SelectableRangeConsumer;
+
+void foreach_selectable_point_range(const bke::CurvesGeometry &curves,

@@ -184,0 +240,4 @@
+    const eCustomDataType create_type,
+    const bke::AttributeIDRef &attribute_id = ".selection");
+
+template<typename Fn>

@@ -776,2 +776,2 @@
-
-  attributes.remove(".selection");
+  Span<std::string> selection_attribute_names = get_curves_selection_attribute_names(curves);
+  for (const bke::AttributeIDRef selection_attribute_id : selection_attribute_names) {

@@ -74,30 +76,140 @@ IndexMask retrieve_selected_points(const Curves &curves_id, IndexMaskMemory &mem
   return retrieve_selected_points(curves, memory);
 }
 
+static const std::array<std::string, 3> selection_attribute_names_{

@@ -77,0 +89,4 @@
+
+Span<std::string> get_curves_all_selection_attribute_names()
+{
+  return Span<std::string>(selection_attribute_names_.data(), selection_attribute_names_.size());

@@ -77,0 +153,4 @@
+  range_consumer(curves.points_range(), positions[0], selection_attribute_names[0]);
+  if (selection_attribute_names.size() > 1) {
+    const OffsetIndices<int> points_by_curve = curves.points_by_curve();
+    for (const int attribute_i : IndexRange(1, 2)) {

@@ -53,0 +55,4 @@
+ * [".selection", ".selection_handle_left", ".selection_handle_right"] otherwise. */
+Span<std::string> get_curves_selection_attribute_names(const bke::CurvesGeometry &curves);
+
+/* Get all possible curve selection attribute names. */

@@ -53,0 +84,4 @@
+    return selections_[index];
+  }
+
+  bke::GSpanAttributeWriter &operator[](const std::string &attribute_name);

@@ -53,0 +100,4 @@
+using SelectableRangeConsumer =
+    blender::FunctionRef<void(const IndexRange range,
+                              const Span<float3> positions,
+                              const std::string &selection_attribute_name)>;

@@ -53,0 +102,4 @@
+                              const Span<float3> positions,
+                              const std::string &selection_attribute_name)>;
+/**
+ * Traverses all ranges of control points posible select. Callback function is provided with a

@@ -826,3 +828,2 @@
     }
-
-    BKE_id_attributes_active_set(&curves_id->id, active_attribute.c_str());
+    if (layer) {

@@ -77,0 +110,4 @@
+  }
+}
+
+inline MutableSpan<bke::GSpanAttributeWriter> init_selection_writers(

@@ -78,2 +224,3 @@
                                                      const bke::AttrDomain selection_domain,
-                                                     const eCustomDataType create_type)
+                                                     const eCustomDataType create_type,
+                                                     const bke::AttributeIDRef &attribute_id)

@@ -53,0 +88,4 @@
+                                    SelectableRangeConsumer range_consumer);
+
+/**
+ * Same logic as in foreach_selectable_point_range, just ranges reference curves insted of

@@ -184,0 +244,4 @@
+bke::GSpanAttributeWriter &selection_attribute_writer_by_name(
+    MutableSpan<bke::GSpanAttributeWriter> selections, StringRef attribute_name);
+
+inline void foreach_selection_attribute_writer(

@@ -64,1 +64,3 @@
-IndexMask retrieve_selected_points(const bke::CurvesGeometry &curves, IndexMaskMemory &memory)
+IndexMask retrieve_selected_points(const bke::CurvesGeometry &curves,
+                                   IndexMaskMemory &memory,
+                                   const std::string &attribute_name)

@@ -164,3 +163,1 @@
-      ".selection", bke::AttrDomain::Point);
-  selection.span.take_back(num_points_to_add).fill(true);
-  selection.finish();
+  for (const StringRef selection_name : ed::curves::get_curves_selection_attribute_names(curves)) {

@@ -63,2 +63,3 @@
 
-IndexMask retrieve_selected_points(const bke::CurvesGeometry &curves, IndexMaskMemory &memory)
+IndexMask retrieve_selected_points(const bke::CurvesGeometry &curves,
+                                   IndexMaskMemory &memory,

@@ -77,0 +85,4 @@
+             selection_attribute_names;
+}
+
+Span<std::string> get_curves_all_selection_attribute_names()

@@ -77,0 +110,4 @@
+  }
+}
+
+Vector<bke::GSpanAttributeWriter> &init_selection_writers(

@@ -77,0 +124,4 @@
+  return writers;
+}
+
+inline void finish_attribute_writers(MutableSpan<bke::GSpanAttributeWriter> attribute_writers)

@@ -77,0 +157,4 @@
+  MutableSpan<bke::GSpanAttributeWriter> selection_writers = init_selection_writers(
+      writers_buffer, curves, selection_domain);
+
+  /* TODO: maybe add threading */

@@ -53,0 +73,4 @@
+                                 const Span<std::string> selection_attribute_names =
+                                     get_curves_all_selection_attribute_names());
+
+using SelectableRangeConsumer = blender::FunctionRef<void(

@@ -184,0 +231,4 @@
+bke::GSpanAttributeWriter ensure_selection_attribute(
+    bke::CurvesGeometry &curves,
+    const bke::AttrDomain selection_domain,
+    const eCustomDataType create_type,

@@ -184,0 +232,4 @@
+    bke::CurvesGeometry &curves,
+    const bke::AttrDomain selection_domain,
+    const eCustomDataType create_type,
+    const std::string &attribute_name = ".selection");

@@ -77,0 +156,4 @@
+    bke::AttrDomain selection_domain,
+    blender::FunctionRef<void(bke::GSpanAttributeWriter &selection)> fn)
+{
+  Vector<bke::GSpanAttributeWriter> writers_buffer = init_selection_writers(curves,

@@ -3129,1 +3112,3 @@
-            new_closest.curves_id = &curves_id;
+          const IndexMask elements(curves.attributes().domain_size(selection_domain));
+          const ed::curves::SelectionRangeFn range_consumer =
+              [&](IndexRange range, Span<float3> positions, StringRef selection_attribute_name) {