Fix #119544: Cage modifier deformation ignored in next modifier #119718

Hans Goudey · 2024-03-20T22:20:47+01:00

Hans Goudey commented

2024-03-20 22:20:47 +01:00

When the edit mesh modifier stack first deforms the original edit mesh,
it creates deformed positions in a separate array. That array is copied
to the mesh's vertex positions if a subsequent modifier requires an
actual mesh rather than a mesh wrapper.

However, if that last deform modifier is the last "on cage" modifier
and the next modifier requires a real Mesh, we hit a code path that
didn't copy the temporary position array, since it was contained in the
separate EditMeshData struct that must be handled manually.

This was a regression in 91b27ab637. In the future I hope to
make this simpler by expanding the use of implicit sharing and making
the conversion from original BMesh to a Mesh more lazy / const correct.

When the edit mesh modifier stack first deforms the original edit mesh, it creates deformed positions in a separate array. That array is copied to the mesh's vertex positions if a subsequent modifier requires an actual mesh rather than a mesh wrapper. However, if that last deform modifier is the last "on cage" modifier and the next modifier requires a real Mesh, we hit a code path that didn't copy the temporary position array, since it was contained in the separate `EditMeshData` struct that must be handled manually. This was a regression in 91b27ab637334383b57b. In the future I hope to make this simpler by expanding the use of implicit sharing and making the conversion from original BMesh to a Mesh more lazy / const correct.

Hans Goudey added 1 commit 2024-03-20 22:20:55 +01:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

95f66e021a Fix #119544 : Cage modifier deformation ignored in next modifier

When the edit mesh modifier stack first deforms the original edit mesh,
it creates deformed positions in a separate array. That array is copied
to the mesh's vertex positions if a subsequent modifier requires an
actual mesh rather than a mesh wrapper.

However, if that last deform modifier is the last "on cage" modifier
and the next modifier requires a real Mesh, we hit a code path that
didn't copy the temporary position array, since it was contained in the
separate `EditMeshData` struct that must be handled manually.

This was a regression in 91b27ab637. In the future I hope to
make this simpler by expanding the use of implicit sharing and making
the conversion from original BMesh to a Mesh more lazy / const correct.

Hans Goudey added this to the Modeling project 2024-03-20 22:21:19 +01:00

Hans Goudey added this to the 4.1 milestone 2024-03-20 22:21:25 +01:00

Hans Goudey commented

2024-03-20 22:21:33 +01:00

@blender-bot build

Hans Goudey requested review from Brecht Van Lommel 2024-03-20 22:22:24 +01:00

Brecht Van Lommel approved these changes 2024-03-20 23:11:52 +01:00

Hans Goudey merged commit ddcfc46ee6 into blender-v4.1-release

2024-03-20 23:16:11 +01:00

Hans Goudey referenced this issue from a commit

2024-03-20 23:16:13 +01:00

Fix #119544: Cage modifier deformation ignored in next modifier

Hans Goudey deleted branch fix-cage-no-copy-deformed

2024-03-20 23:16:18 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #119544: Cage modifier deformation ignored in next modifier #119718