Fix #119397: X-Ray not available in Rendered mode when using Workbench #119769

Closed

Fermin-Lozano wants to merge 3 commits from Fermin-Lozano/blender:fix-#119397 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Fermin-Lozano commented

2024-03-22 00:18:15 +01:00

Contributor

Description of the problem:
X-Ray is not available in Rendered mode when using Workbench, when it could have it as it always available in Solid mode.

Proposed solution:
Whenever there are checks to see if X-Ray is enabled, there are usually conditions depending of the shading mode (i.e. Solid, Wireframe, Rendered...) and X-Ray is disabled the moment Rendered mode is active. The proposed solution adds additional conditions that make the X-Ray feature always available when using Workbench.

Description of the problem: X-Ray is not available in Rendered mode when using Workbench, when it could have it as it always available in Solid mode. Proposed solution: Whenever there are checks to see if X-Ray is enabled, there are usually conditions depending of the shading mode (i.e. Solid, Wireframe, Rendered...) and X-Ray is disabled the moment Rendered mode is active. The proposed solution adds additional conditions that make the X-Ray feature always available when using Workbench.

Fermin-Lozano added 3 commits 2024-03-22 00:18:24 +01:00

c5c0009dbe UI changes to enable X-Ray in Rendered mode with Workbench

73bb2dc63f Add `Scene` argument to `XRAY_ACTIVE` to enable X-Ray in Rendered mode when using Workbench

acc6c3f1e6 Disable shading override in Rendered mode when using Workbench

Fermin-Lozano changed title from ~~WIP: Fix #119397: X-Ray not available in Rendered mode when using Workbench~~ to Fix #119397: X-Ray not available in Rendered mode when using Workbench

2024-03-22 00:30:26 +01:00

Iliya Katushenock added this to the User Interface project 2024-03-22 12:39:49 +01:00

Iliya Katushenock added the

label 2024-03-22 12:40:16 +01:00

Fermin-Lozano requested review from Julian Eisel 2024-03-23 12:10:22 +01:00

Fermin-Lozano requested review from Clément Foucault 2024-03-23 12:14:01 +01:00

Jeroen Bakker commented

2024-04-15 11:14:14 +02:00

Member

Hi @Fermin-Lozano and thanks for the patch. I do believe this fix first needs to have a discussion about how to solve the issue as the user expectation might be different.

You proposal adds some confusion to the user as it introduces 2 distict ways to enable/disable xray mode in rendered mode

XRay button in viewport
XRay option in render panel

Which of those ways have now more priority over the other. And is this what the user always expect. The current solution doesn't have this confusion by disabling the option in the 3d viewport.

Looking into the issue of the original report I think that using 2 3d viewports both in solid mode with different settings would have solved it.

If the user wants to have a single 3d viewport and just an option to switch between 2 different sets of draw options, we should implement presets for 3d viewport drawing mode. (which was always the plan, but it never got priority)

See scripts/presets folder and #116223 how to implement presets. Might need some trickery to add this clearly in the UI though.

Hi @Fermin-Lozano and thanks for the patch. I do believe this fix first needs to have a discussion about how to solve the issue as the user expectation might be different. You proposal adds some confusion to the user as it introduces 2 distict ways to enable/disable xray mode in rendered mode - XRay button in viewport - XRay option in render panel Which of those ways have now more priority over the other. And is this what the user always expect. The current solution doesn't have this confusion by disabling the option in the 3d viewport. Looking into the issue of the original report I think that using 2 3d viewports both in solid mode with different settings would have solved it. If the user wants to have a single 3d viewport and just an option to switch between 2 different sets of draw options, we should implement presets for 3d viewport drawing mode. (which was always the plan, but it never got priority) See `scripts/presets` folder and #116223 how to implement presets. Might need some trickery to add this clearly in the UI though.

Fermin-Lozano commented

2024-04-16 23:18:13 +02:00

Author

Contributor

Thanks for the reply @Jeroen-Bakker !. When I first saw the issue I though this could easily happen, but it passed the triage stage so I decided to give it a try.

If the conclusion is that it's better as it is right now, this PR and its associated issue can be closed.

Thanks for the reply @Jeroen-Bakker !. When I first saw the issue I though this could easily happen, but it passed the triage stage so I decided to give it a try. If the conclusion is that it's better as it is right now, this PR and its associated issue can be closed.

Fermin-Lozano closed this pull request

2024-04-21 15:39:36 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119769

No description provided.