Metal: Add AMD support for subpass transition #119784

Merged
Jeroen Bakker merged 5 commits from Jason-Fielder/blender:MetalAMDSubpassTransitionSupport into main 2024-04-11 15:24:05 +02:00
Member

Adds support for subpass transition for AMD/Intel IMR
GPUs. This enables correct functioning of EEVEE Next
deferred lighting pass on AMD platforms.

The emulation is consistent with the OpenGL approach
of generating additional texture bindings in the shader
for subpass inputs, and splitting render passes across
sub-pass boundaries.

Authored by Apple: Michael Parkin-White

Adds support for subpass transition for AMD/Intel IMR GPUs. This enables correct functioning of EEVEE Next deferred lighting pass on AMD platforms. The emulation is consistent with the OpenGL approach of generating additional texture bindings in the shader for subpass inputs, and splitting render passes across sub-pass boundaries. Authored by Apple: Michael Parkin-White
Jason Fielder added 1 commit 2024-03-22 13:40:10 +01:00
2df86a6db9 Metal: Add AMD support for subpass transition
Adds support for subpass transition for AMD/Intel IMR
GPUs. This enables correct functioning of EEVEE Next
deferred lighting pass on AMD platforms.

The emulation is consistent with the OpenGL approach
of generating additional texture bindings in the shader
for subpass inputs, and splitting render passes across
sub-pass boundaries.

Authored by Apple: Michael Parkin-White
Jason Fielder requested review from Clément Foucault 2024-03-22 13:42:14 +01:00
Jason Fielder requested review from Jeroen Bakker 2024-03-22 13:42:20 +01:00
Clément Foucault approved these changes 2024-03-22 14:51:42 +01:00
Dismissed
@ -3050,0 +3108,4 @@
}
}
else {
/* TODO: Read from generated images. */

What does this TODO refers to?

What does this TODO refers to?
First-time contributor

Apologies, left over, already addressed, will remove.

Apologies, left over, already addressed, will remove.
fclem marked this conversation as resolved
Jason Fielder added 1 commit 2024-03-22 14:54:01 +01:00
Clément Foucault approved these changes 2024-03-22 14:54:58 +01:00

Good, will ask @Jeroen-Bakker to test on intel mac.

Good, will ask @Jeroen-Bakker to test on intel mac.
Jeroen Bakker requested changes 2024-04-11 10:13:22 +02:00
Dismissed
Jeroen Bakker left a comment
Member

Shadows are working on Intel. (I don't have AMD GPU).
A small tweak requested to reduce compilation warnings.

Shadows are working on Intel. (I don't have AMD GPU). A small tweak requested to reduce compilation warnings.
@ -74,6 +74,62 @@ enum class Type {
SHORT4
};
static int to_component_count(const Type &type)
Member

Use BLI_INLINE Currently generates many compilation warning when used on backends that don't use this function.

Use `BLI_INLINE` Currently generates many compilation warning when used on backends that don't use this function.
First-time contributor

Thanks Jeroen, will resolve!

Good to confirm shadows working on Intel GPUs too. Will be performing a test pass on Intel later today to see where we are at overall.

Thanks Jeroen, will resolve! Good to confirm shadows working on Intel GPUs too. Will be performing a test pass on Intel later today to see where we are at overall.
Jeroen Bakker added the
Module
EEVEE & Viewport
Interest
Metal
labels 2024-04-11 10:13:44 +02:00
Jeroen Bakker added this to the 4.2 LTS milestone 2024-04-11 10:13:49 +02:00
Jeroen Bakker added this to the EEVEE & Viewport project 2024-04-11 10:13:52 +02:00
Jason Fielder added 3 commits 2024-04-11 14:53:39 +02:00
Jeroen Bakker approved these changes 2024-04-11 15:23:00 +02:00
Jeroen Bakker merged commit be32bc5b72 into main 2024-04-11 15:24:05 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119784
No description provided.