UI: Removal of Five Operator Confirmations #120036

Harley Acheson · 2024-03-28T20:52:31+01:00

Harley Acheson commented

2024-03-28 20:52:31 +01:00

Removal of confirmation dialogs for the following five operators. For
each of these the UI module felt that they are all either very explicit
actions and/or are easily undone.

ARMATURE_OT_separate (Move selected bones to a separate armature)
CURVE_OT_separate - “Move selected points to a new object”
OBJECT_OT_vertex_parent_set (Parent selected ob to selected vertices)
OBJECT_OT_parent_no_inverse_set (Make Parent w/o inverse correction)
FILE_OT_directory_new - (Create New Directory)

As discussed in our UI Module meeting of April 26th 2024.

Removal of confirmation dialogs for the following five operators. For each of these the UI module felt that they are all either very explicit actions and/or are easily undone. * ARMATURE_OT_separate (Move selected bones to a separate armature) * CURVE_OT_separate - “Move selected points to a new object” * OBJECT_OT_vertex_parent_set (Parent selected ob to selected vertices) * OBJECT_OT_parent_no_inverse_set (Make Parent w/o inverse correction) * FILE_OT_directory_new - (Create New Directory) --- As discussed in our UI Module meeting of [April 26th 2024](https://devtalk.blender.org/t/2024-03-26-user-interface-meeting/33772).

Harley Acheson added 1 commit 2024-03-28 20:52:42 +01:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

92a135ede7 UI: Remove of Five Operator Confirmations

Removal of the confirmations for the following five operators:
* ARMATURE_OT_separate (Move selected bones to a separate armature)
* CURVE_OT_separate - “Move selected points to a new object”
* OBJECT_OT_vertex_parent_set (Parent selected ob to selected vertices)
* OBJECT_OT_parent_no_inverse_set (Make Parent w/o inverse correction)
* FILE_OT_directory_new - (Create New Directory)

Harley Acheson added this to the User Interface project 2024-03-28 20:52:59 +01:00

Harley Acheson requested review from Hans Goudey 2024-03-28 20:53:28 +01:00

Hans Goudey approved these changes 2024-03-28 20:59:56 +01:00

Hans Goudey left a comment

Looks good to me, I'd just add some reasoning to the commit message though (side note, it would be nice if the meeting notes were a bit less terse and contained some of the thoughts/highlights from the conversation). Something like this maybe: "These operations are generally highly visible and easy or at least possible to undo, so the typical reasoning of avoiding losing user data doesn't apply".

Harley Acheson commented

2024-03-28 22:24:54 +01:00

@HooglyBoogly - I'd just add some reasoning to the commit message though

Good point, will do.

it would be nice if the meeting notes were a bit less terse and contained some of the thoughts/highlights from the conversation...

Also a good point. Will see what I can do.

The major reason for the terse notes were (obviously) just to serve as just enough information for me to act on.

But being terse also serves (at least) two other purposes. The first is me trying to avoid editorializing, quoting and paraphrasing others. One person's view of a thing can quite often be quite different from how other see the same thing. If that becomes an issue though we could just have meeting note approval or something.

And also adding much detail to some items can give the reader the idea that everything that happened was noted there. So if there is no note then we must not have talked about it, or anything else not on the agenda.

As a test I did another run through of the last meeting notes, adding much more detail and trying to avoid the above. https://devtalk.blender.org/t/2024-03-26-user-interface-meeting/33772

> @HooglyBoogly - I'd just add some reasoning to the commit message though Good point, will do. > it would be nice if the meeting notes were a bit less terse and contained some of the thoughts/highlights from the conversation... Also a good point. Will see what I can do. The major reason for the terse notes were (obviously) just to serve as just enough information for me to act on. But being terse also serves (at least) two other purposes. The first is me trying to avoid editorializing, quoting and paraphrasing others. One person's view of a thing can quite often be quite different from how other see the same thing. If that becomes an issue though we could just have meeting note approval or something. And also adding much detail to some items can give the reader the idea that everything that happened was noted there. So if there is no note then we must not have talked about it, or anything else not on the agenda. As a test I did another run through of the last meeting notes, adding much more detail and trying to avoid the above. https://devtalk.blender.org/t/2024-03-26-user-interface-meeting/33772

❤️ 1

Harley Acheson changed title from ~~UI: Remove of Five Operator Confirmations~~ to UI: Removal of Five Operator Confirmations

2024-03-28 22:27:12 +01:00

Harley Acheson commented

2024-03-28 22:50:54 +01:00

@blender-bot build

Harley Acheson added 2 commits 2024-03-29 00:04:07 +01:00

c4320a0cab Merge branch 'main' of projects.blender.org:blender/blender into RemoveConfirmations

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details