Anim: Update NLA "make single user" popup dialog #120082

Merged
Nate Rupsis merged 4 commits from NLA-make-single-user-model into main 2024-04-04 18:34:20 +02:00
Member

Update the NLA_OT_make_single_user dialogue and confirmation modal to make explicitly clear what's happening for the selected strips.

image

Update the `NLA_OT_make_single_user` dialogue and confirmation modal to make explicitly clear what's happening for the selected strips. ![image](https://projects.blender.org/blender/blender/attachments/cbb54aaa-d9d2-478a-93be-ee848bd36274)
Nate Rupsis added 1 commit 2024-03-29 22:24:42 +01:00
Nate Rupsis requested review from Sybren A. Stüvel 2024-03-29 22:25:21 +01:00
Nate Rupsis requested review from Harley Acheson 2024-03-29 22:25:22 +01:00
Nate Rupsis requested review from Christoph Lendenfeld 2024-03-29 22:25:22 +01:00
Member

Hey @nrupsis!

Keep in mind that my opinion should have little weight here. As in I think it far more important that these things make sense to the applicable users. So take the following only as gentle suggestions; you can have this dialog any way you wish.

In "Make selected single-user?" I think the subject of the sentence - the strip(s) - is hidden or implied. Selected what? I would generally make it explicit if there is room. Perhaps "Make selected strips single-user?"

I like how the body text is adding extra help and explanation. I think the "select" in the body text is a typo for "selected"? I honestly am not familiar with this particular operator, but is this description strictly correct? It sounds like it creates one single new action for the group of multiple strips. I assumed this was more that it creates separate actions for each one? If this situation is of multiple strips sharing a single action but decoupling from that sharing I might describe it like "Shared actions will be duplicated for each selected strip" or "Making single-user creates separate actions for each selected strip."

Icon selection seems fine, the button text also looks okay.

With our current confirmations we have two styles, one small and one large, and we have quite different usage styles (and behaviors) for the two of them to make them as unique as possible. To fit with the current style used by the other large confirmations your text would be a title with title case and no period of "Make Selected Single-User" and the content would be a sentence with terminating period of "Making single-user creates a new action for the selected strip(s)."

In the same style, my text above would be "Make Selected Strips Single-User" and "Shared actions will be duplicated for each selected strip." If I understand what this operator does of course. LOL.

Hey @nrupsis! Keep in mind that my opinion should have little weight here. As in I think it far more important that these things make sense to the applicable users. So take the following only as gentle suggestions; you can have this dialog any way you wish. In "Make selected single-user?" I think the subject of the sentence - the strip(s) - is hidden or implied. Selected what? I would generally make it explicit if there is room. Perhaps "Make selected strips single-user?" I like how the body text is adding extra help and explanation. I think the "select" in the body text is a typo for "selected"? I honestly am not familiar with this particular operator, but is this description strictly correct? It sounds like it creates one single new action for the group of multiple strips. I assumed this was more that it creates separate actions for each one? If this situation is of multiple strips sharing a single action but decoupling from that sharing I might describe it like "Shared actions will be duplicated for each selected strip" or "Making single-user creates separate actions for each selected strip." Icon selection seems fine, the button text also looks okay. With our current confirmations we have two styles, one small and one large, and we have quite different usage styles (and behaviors) for the two of them to make them as unique as possible. To fit with the current style used by the other large confirmations your text would be a title with title case and no period of "Make Selected Single-User" and the content would be a sentence with terminating period of "Making single-user creates a new action for the selected strip(s)." In the same style, my text above would be "Make Selected Strips Single-User" and "Shared actions will be duplicated for each selected strip." If I understand what this operator does of course. LOL.
Author
Member

@Harley of course I care about your opinion!

Coming back with a fresh set of eyes, your changes make obvious sense. The only thing I'd change is use the term "Linked" instead of "Shared". We'd only ever run this operator because we "Linked Duplicate" in the first place, so keep that terminology I think makes sense. Happy to discuss it tho.

Here are the changes:

image

@Harley of course I care about your opinion! Coming back with a fresh set of eyes, your changes make obvious sense. The only thing I'd change is use the term "Linked" instead of "Shared". We'd only ever run this operator because we "Linked Duplicate" in the first place, so keep that terminology I think makes sense. Happy to discuss it tho. Here are the changes: ![image](/attachments/cbb54aaa-d9d2-478a-93be-ee848bd36274)
102 KiB
Nate Rupsis added 2 commits 2024-04-01 17:31:24 +02:00

I am a bit confused by the fact that the text says that Strips will be made single user. It's the action within the strip that is turned into a single user.
I think it's fine for the popup since you have the second line just below, but the operator description could be clearer I think

I am a bit confused by the fact that the text says that Strips will be made single user. It's the action within the strip that is turned into a single user. I think it's fine for the popup since you have the second line just below, but the operator description could be clearer I think
Author
Member

I am a bit confused by the fact that the text says that Strips will be made single user. It's the action within the strip that is turned into a single user.
I think it's fine for the popup since you have the second line just below, but the operator description could be clearer I think

@ChrisLend Confusion is a good indication something is missing.

Would a operator description of Make linked actions on selected strip(s) single user give more clarity?

Conceptually, this is very much like objects and object data. Linked objects are just objects that share the same object data. Here's what making an object single user looks like:

image

Perhaps Make linked action local to each strip?

Let me know if you have any other ideas.

> I am a bit confused by the fact that the text says that Strips will be made single user. It's the action within the strip that is turned into a single user. > I think it's fine for the popup since you have the second line just below, but the operator description could be clearer I think @ChrisLend Confusion is a good indication something is missing. Would a operator description of `Make linked actions on selected strip(s) single user` give more clarity? Conceptually, this is very much like objects and object data. Linked objects are just objects that share the same object data. Here's what making an object single user looks like: ![image](/attachments/77d08fe2-b78c-40f1-a524-9f696b15bed2) Perhaps `Make linked action local to each strip`? Let me know if you have any other ideas.

@nrupsis I like that, much clearer to me

@nrupsis I like that, much clearer to me
Nate Rupsis added 1 commit 2024-04-02 17:08:48 +02:00
Harley Acheson approved these changes 2024-04-02 18:14:38 +02:00
Harley Acheson left a comment
Member

Looks nice!

Looks nice!
Christoph Lendenfeld approved these changes 2024-04-04 10:47:26 +02:00
Christoph Lendenfeld left a comment
Member

also looks good to me now
thanks!

also looks good to me now thanks!
Nate Rupsis merged commit 298c9276e9 into main 2024-04-04 18:34:20 +02:00
Nate Rupsis deleted branch NLA-make-single-user-model 2024-04-04 18:34:22 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120082
No description provided.