Fix #119973 Compositor: Flip node produces artifacts #120149

Merged
Omar Emara merged 1 commits from zazizizou/blender:fix-flip-node-artefacts into blender-v4.1-release 2024-04-04 10:53:46 +02:00
Member

This fix partially reverts 70a8a9e.

The tiled compositor output canvas might change after the node tree is built. This makes the function determine_depending_area_of_interest() necessary for the canvas to be computed consistently correctly, every time canvas or areas of interests are evaluated in the node tree.

This fix partially reverts 70a8a9e. The tiled compositor output canvas might change after the node tree is built. This makes the function `determine_depending_area_of_interest()` necessary for the canvas to be computed consistently correctly, every time canvas or areas of interests are evaluated in the node tree.
Habib Gahbiche added 1 commit 2024-04-01 23:14:28 +02:00
Fix #119973 Compositor: Flip node produces artefacts
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
85bdfb8cdd
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR120149) when ready.
Hans Goudey changed title from Fix #119973 Compositor: Flip node produces artefacts to Fix #119973 Compositor: Flip node produces artifacts 2024-04-02 03:04:34 +02:00
Habib Gahbiche requested review from Omar Emara 2024-04-02 09:21:19 +02:00
Member

Does it work correctly with translated inputs?

Does it work correctly with translated inputs?
Author
Member

Does it work correctly with translated inputs?

Yes, though I didn't observe any wrong behavior with translated input before this patch

> Does it work correctly with translated inputs? Yes, though I didn't observe any wrong behavior with translated input before this patch
Omar Emara approved these changes 2024-04-02 19:30:41 +02:00
Member

@ThomasDinges Should this be added to the corrective release? It does not affect main, only blender-v4.1-release.

@ThomasDinges Should this be added to the corrective release? It does not affect `main`, only `blender-v4.1-release`.

@OmarEmaraDev Thanks, please add it to 4.1 only then. Once landed please add it to the 4.1.1 table at #119631

@OmarEmaraDev Thanks, please add it to 4.1 only then. Once landed please add it to the 4.1.1 table at https://projects.blender.org/blender/blender/issues/119631
Omar Emara merged commit dcb81a434d into blender-v4.1-release 2024-04-04 10:53:46 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120149
No description provided.