Cleanup: Mesh calculate edges file cleanup #120189

Iliya Katushenock · 2024-04-02T21:32:16+02:00

Iliya Katushenock commented

2024-04-02 21:32:16 +02:00

Trivial changes of code:

Const correctness.
Arguments order.
Use regular constructor instead of aggregate one.
Replace stateful iterators of corners by bke::mesh functions.
Offset Indices instead of manual prefix sum.
Slight changes of iterator names which is affected by cleanup.
Cpp allocator.
Explicit template parameter.

Trivial changes of code: 1. Const correctness. 2. Arguments order. 3. Use regular constructor instead of aggregate one. 4. Replace stateful iterators of corners by `bke::mesh` functions. 5. Offset Indices instead of manual prefix sum. 6. Slight changes of iterator names which is affected by cleanup. 7. Cpp allocator. 8. Explicit template parameter.

corner_edges_order_test.blend

901 KiB

Iliya Katushenock added 2 commits 2024-04-02 21:32:27 +02:00

e424aa44ab init

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

4f2d10fb29 progress

Iliya Katushenock requested review from Hans Goudey 2024-04-02 21:32:37 +02:00

Hans Goudey approved these changes 2024-04-02 21:37:06 +02:00

Hans Goudey commented

2024-04-02 21:37:24 +02:00

@blender-bot build

Hans Goudey merged commit 3f3df16ba2 into main

2024-04-02 22:49:08 +02:00

Hans Goudey referenced this issue from a commit

2024-04-02 22:49:09 +02:00

Cleanup: Mesh calculate edges file cleanup

Iliya Katushenock deleted branch cleanup_calc_edges

2024-04-03 06:09:37 +02:00

Johannes J. reviewed 2024-04-09 19:45:59 +02:00

source/blender/blenkernel/intern/mesh_calc_edges.cc

						
				@ -104,3 +105,3 @@

				    const int task_index = &edge_map - edge_maps.data();

				    int new_edge_index = edge_index_offsets[task_index];

				    int new_edge_index = edge_offsets[task_index].first();

Johannes J. commented

2024-04-09 19:45:59 +02:00

This might cause an assertion failure:

BLI_assert failed: source/blender/blenlib/BLI_index_range.hh:202, first(), at 'this->size() > 0'

Example repro: blender --background --python-expr 'import bpy; m = bpy.data.meshes.new("test"); m.update(calc_edges=True)'

This might cause an assertion failure: `BLI_assert failed: source/blender/blenlib/BLI_index_range.hh:202, first(), at 'this->size() > 0'` Example repro: `blender --background --python-expr 'import bpy; m = bpy.data.meshes.new("test"); m.update(calc_edges=True)'`

Iliya Katushenock commented

2024-04-09 19:55:23 +02:00

#120330

mod_moder marked this conversation as resolved

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cleanup: Mesh calculate edges file cleanup #120189