Fix #120133: Incorrect BG color Hovering Inactive #120262

Harley Acheson · 2024-04-04T18:29:55+02:00

Harley Acheson commented

2024-04-04 18:29:55 +02:00

Hovering on inactive menu items combines the colors in a way that does
not work correctly with light themes. This PR changes nothing but how
colors are mixed for hover + inactive, doing so similarly to hovering
active.

Offered as an alternative to #112380. I prefer this approach mostly because it only changes things in this particular state of hover on an inactive menu item and so requires less testing to ensure it has no unintended consequences.

In the complaint, F3 menu search - while in Light theme - shows incorrect coloring on the inactive portion of the highlighted line. This is shown in the top of the following capture, with below showing after this PR is applied:

Testing other areas of hovering inactive menu items I can't find any errors or changes. For example when viewing F3 search in Dark theme it still looks the same:

Hovering on inactive menu items combines the colors in a way that does not work correctly with light themes. This PR changes nothing but how colors are mixed for hover + inactive, doing so similarly to hovering active. --- Offered as an alternative to #112380. I prefer this approach mostly because it only changes things in this particular state of hover on an inactive menu item and so requires less testing to ensure it has no unintended consequences. In the complaint, F3 menu search - while in Light theme - shows incorrect coloring on the inactive portion of the highlighted line. This is shown in the top of the following capture, with below showing after this PR is applied: ![image](/attachments/cc07b0d6-43e5-46b7-a7bf-7459ce967d84) Testing other areas of hovering inactive menu items I can't find any errors or changes. For example when viewing F3 search in Dark theme it still looks the same: ![image](/attachments/ba0f561a-1868-4662-a80a-9463224e68f9)

image.png

20 KiB

image.png

13 KiB

👍 1

Harley Acheson added 1 commit 2024-04-04 18:30:05 +02:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

7ef4697c91 Fix #120133 : Incorrect BG color Hovering Inactive

Hovering on inactive menu items combines the colors in a way that does
not work correctly with light themes. This PR changes nothing but how
colors are mixed for hover + inactive, doing so similarly to hovering
active.

Harley Acheson added this to the User Interface project 2024-04-04 18:31:29 +02:00

Harley Acheson requested review from Pratik Borhade 2024-04-04 18:31:39 +02:00

Pratik Borhade approved these changes 2024-04-05 13:48:05 +02:00

Pratik Borhade left a comment

Hi, yes, this change is enough to fix #120133. Thanks 🙂
Some custom themes of user might broke but that's obvious after any change on "theme side"

Hi, yes, this change is enough to fix #120133. Thanks 🙂 Some custom themes of user might broke but that's obvious after any change on "theme side"

Harley Acheson commented

2024-04-05 17:05:29 +02:00

@blender-bot build

Harley Acheson referenced this issue from a commit

2024-04-05 18:08:56 +02:00

Fix #120133: Incorrect BG color Hovering Inactive