UI: Tooltips for Bone Collection Active & Selected #120268

Harley Acheson · 2024-04-04T19:31:14+02:00

Harley Acheson commented

2024-04-04 19:31:14 +02:00

Hovering over the filled and open circles of Bone Collection items does
not give any hints on what these indicate. This PR makes them say
"Active" and "Selected".

Hovering over the filled and open circles of Bone Collection items does not give any hints on what these indicate. This PR makes them say "Active" and "Selected". --- ![image](/attachments/2d366105-4a28-4798-80a0-ddeb352517b7) ![image](/attachments/1a6f0682-2542-43ff-92d0-a070fdec7a4e)

image.png

18 KiB

image.png

20 KiB

Harley Acheson added 1 commit 2024-04-04 19:31:24 +02:00

6a49a51bcf UI: Tooltips for Bone Collection Active & Selected

Hovering over the filled and open circles of Bone Collection items does
not give any hints on what these indicate. This PR makes them say
"Active" and "Selected".

Harley Acheson added this to the User Interface project 2024-04-04 19:31:43 +02:00

Harley Acheson requested review from Sybren A. Stüvel 2024-04-04 19:32:12 +02:00

Hans Goudey requested changes 2024-04-04 20:02:52 +02:00

source/blender/editors/interface/templates/interface_template_bone_collection_tree.cc Outdated

						
				@ -240,2 +245,4 @@

				      }

				      uiItemL(sub, "", icon);

				      uiBlock *block = uiLayoutGetBlock(sub);

				      uiBut *but = ui_but_last(block);

Hans Goudey commented

2024-04-04 20:02:50 +02:00

This is quite a hack honestly. It would be nice to look into other ways of accomplishing this. Possibly:

Adding an API to set the tooltip for a layout (doesn't that already exist?)
Adding an option to set the tooltip when creating a label layout item
Even better: Making this into an operator button or RNA property button that would have its description set automatically

This is quite a hack honestly. It would be nice to look into other ways of accomplishing this. Possibly: - Adding an API to set the tooltip for a layout (doesn't that already exist?) - Adding an option to set the tooltip when creating a label layout item - Even better: Making this into an operator button or RNA property button that would have its description set automatically

Harley marked this conversation as resolved

Harley Acheson commented

2024-04-04 20:08:12 +02:00

@HooglyBoogly - This is quite a hack honestly.

Yes, I think somewhere a kitten cries every time we need to use ui_but_last or access block->buttons.last

Will find something better.

> @HooglyBoogly - This is quite a hack honestly. Yes, I think somewhere a kitten cries every time we need to use `ui_but_last` or access `block->buttons.last` Will find something better.

Harley Acheson added 2 commits 2024-04-04 21:46:37 +02:00

ec26a7435f Merge branch 'main' of projects.blender.org:blender/blender into BoneCollectionActiveSelectedTip

f4300eab3c Set tooltip on the actual button, not row.

Harley Acheson commented

2024-04-04 21:49:50 +02:00

@HooglyBoogly - This is quite a hack honestly

We already have a variation of uiItemL that returns the uiBut. The only wrinkle being we have to change the type since we don't currently allow tooltips on labels. But this works better and is much less hacky.

> @HooglyBoogly - This is quite a hack honestly We already have a variation of uiItemL that returns the uiBut. The only wrinkle being we have to change the type since we don't currently allow tooltips on labels. But this works better and is much less hacky.

Hans Goudey commented

2024-04-04 21:55:00 +02:00

Mainly what I don't like is manipulation of the button's type, and direct access to the tooltip field which is also managed by higher level APIs. I think we should be more strict about not adding this sort of exception everywhere. That's the reason the UI code is so messy in the first place.

Harley Acheson added 1 commit 2024-04-05 20:58:38 +02:00

08c8cf9697 Allow setting tip when creating the label.

Harley Acheson commented

2024-04-05 21:00:43 +02:00

@HooglyBoogly - Mainly what I don't like is manipulation of the button's type, and direct access to the tooltip field which is also managed by higher level APIs

Yes, this now has an optional tooltip when setting the label, but not sure I like it any better since it just moves the button type change around.

> @HooglyBoogly - Mainly what I don't like is manipulation of the button's type, and direct access to the tooltip field which is also managed by higher level APIs Yes, this now has an optional tooltip when setting the label, but not sure I like it any better since it just moves the button type change around.

Sybren A. Stüvel requested changes 2024-04-09 15:18:02 +02:00

Dismissed

Sybren A. Stüvel left a comment

I agree with @HooglyBoogly when it comes to the hackyness of the code, but don't take my opinion on this as blocking for this PR -- I'm not in the UI module, and I don't know how much work it would be to do this cleanly.

As for the tooltips themselves, I think it's a great idea but the text is a bit too short and potentially confusing (is "selected' referring to the bone collection or the bones it contains?). I think these would be better:

Contains the active bone.
Contains one or more selected bones.

I agree with @HooglyBoogly when it comes to the hackyness of the code, but don't take my opinion on this as blocking for this PR -- I'm not in the UI module, and I don't know how much work it would be to do this cleanly. As for the tooltips themselves, I think it's a great idea but the text is a bit too short and potentially confusing (is "selected' referring to the bone collection or the bones it contains?). I think these would be better: - Contains the active bone. - Contains one or more selected bones.

Sybren A. Stüvel approved these changes 2024-04-09 15:18:44 +02:00

Sybren A. Stüvel left a comment

Approving the PR to speed things up; please adjust the tooltips before landing.

Harley Acheson added 2 commits 2024-04-10 00:55:52 +02:00

b47f8984cc Merge branch 'main' of projects.blender.org:blender/blender into BoneCollectionActiveSelectedTip

03a6e583f7 Text changes suggested by Sybren.

Sybren A. Stüvel added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Tooltips for Bone Collection Active & Selected #120268

Checkout