Fix #120265: Build tree view row after cancelling rename #120290

Pratik Borhade · 2024-04-05T11:13:43+02:00

Pratik Borhade commented

2024-04-05 11:13:43 +02:00

is_renaming_ is true even after cancelling the rename operation,
this will result in calling add_rename_button instead of building the active
row in TreeViewLayoutBuilder::build_row. To fix this, set
is_renaming_ to false once text edit operation is finished.

`is_renaming_` is true even after cancelling the rename operation, this will result in calling `add_rename_button` instead of building the active row in `TreeViewLayoutBuilder::build_row`. To fix this, set `is_renaming_` to false once text edit operation is finished.

Pratik Borhade added 1 commit 2024-04-05 11:13:54 +02:00

179b60c364 Fix #120265 : Build tree view row after cancelling rename

`is_renaming_` is true even after cancelling the rename operation,
this calls `add_rename_button` instead of building the active
row in `TreeViewLayoutBuilder::build_row`. To fix this, set
`is_renaming_` to false once text edit operation is finished.

Pratik Borhade requested review from Pablo Vazquez 2024-04-05 11:14:09 +02:00

Pratik Borhade requested review from Julian Eisel 2024-04-05 11:14:10 +02:00

Pratik Borhade added the

Module

User Interface

label 2024-04-05 11:14:40 +02:00

Pratik Borhade added 1 commit 2024-04-05 11:22:33 +02:00

17dabc3108 Formatting and if check

Pablo Vazquez commented

2024-04-05 11:58:45 +02:00

Functionality wise seems to behave as expected, code review I leave it to @JulianEisel

👍 1

Pablo Vazquez approved these changes 2024-04-05 11:59:03 +02:00

Julian Eisel reviewed 2024-04-05 18:27:11 +02:00

Julian Eisel left a comment

I would prefer to avoid such view-item specific handling in general UI code, there should be more general solutions. The way we deal with this in other cases is using the hacky UI_but_active_only(), and sending a notifier that will trigger another redraw when this returns false (meaning, the rename button was removed).

A good solution would be allowing some kind of on-rename-end callback to be set, which could do all the UI state updates and replace these ugly UI_but_active_only() hacks. I started looking into this but it turns out to be more finicky than I thought. Will look more into it.

I would prefer to avoid such view-item specific handling in general UI code, there should be more general solutions. The way we deal with this in other cases is using the hacky `UI_but_active_only()`, and sending a notifier that will trigger another redraw when this returns false (meaning, the rename button was removed). A good solution would be allowing some kind of on-rename-end callback to be set, which could do all the UI state updates and replace these ugly `UI_but_active_only()` hacks. I started looking into this but it turns out to be more finicky than I thought. Will look more into it.

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 120265-tree-view-build-row:PratikPB2123-120265-tree-view-build-row

git checkout PratikPB2123-120265-tree-view-build-row

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #120265: Build tree view row after cancelling rename #120290

Checkout