blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

Fix #120287: GPv3: Crash when converting file with annotations #120294

Closed
Falk David wants to merge 3 commits from filedescriptor/blender:fix-120287 into main
pull from: filedescriptor/blender:fix-120287
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 5 Commits 3 Files Changed 1 +7 -3
Falk David commented 2024-04-05 12:17:06 +02:00
Member
Copy Link

The greasepencil::convert::legacy_main function did not account for annotations.
They are bGPData IDs but shouldn't be converted to GPv3.

The fix does this by skipping over bGPData IDs that have the
GP_DATA_ANNOTATIONS flag set.

Note that this also covers the case where an ID is used
both as annotation and object data. In this case, the ID
remapping is skipped, but that is ok, because the
legacy data still has at least one user (annotations).

The `greasepencil::convert::legacy_main` function did not account for annotations. They are `bGPData` IDs but shouldn't be converted to GPv3. The fix does this by skipping over `bGPData` IDs that have the `GP_DATA_ANNOTATIONS` flag set. Note that this also covers the case where an ID is used both as annotation and object data. In this case, the ID remapping is skipped, but that is ok, because the legacy data still has at least one user (annotations).
Falk David added 1 commit 2024-04-05 12:17:15 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
272e884b2d Fix #120287: GPv3: Crash when converting file with annotations 
The `greasepencil::convert::legacy_main` function did not account for annotations.
They are `bGPData` IDs but shouldn't be converted to GPv3.

The fix does this by skipping over `bGPData` IDs that have the
`GP_DATA_ANNOTATIONS` flag set.
Note that this also covers the case where an ID is used
both as annotation and object data. In this case, the ID
remapping is skipped, but that is ok, because the
legacy data still has at least one user (annotations).
Falk David added this to the Grease Pencil project 2024-04-05 12:17:19 +02:00
Falk David requested review from Bastien Montagne 2024-04-05 12:17:26 +02:00
Falk David commented 2024-04-05 12:29:04 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Falk David added 2 commits 2024-04-05 15:44:17 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
2e72a185aa Merge branch 'main' into fix-120287
Falk David commented 2024-04-05 15:44:30 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Bastien Montagne requested changes 2024-04-11 16:55:13 +02:00
Bastien Montagne left a comment
Owner
Copy Link

Skipping remapping is not acceptable imho, this is assuming that the only usage of GPv2 IDs are object's data and annotations pointers... Forgetting things like driver targets, custom properties ID pointers, python-generated properties, and potentially other cases...

I have strong reserves regarding the fact that old GPv2 data needs to be kept around for annotations. Converting an ID type into another is already very complex from versioning/ID management PoV, but keeping legacy data for some use cases feels.... really not a good idea to me. And is going to make remapping a nightmare to handle. :(

Skipping remapping is not acceptable imho, this is assuming that the only usage of GPv2 IDs are object's data and annotations pointers... Forgetting things like driver targets, custom properties ID pointers, python-generated properties, and potentially other cases... I have strong reserves regarding the fact that old GPv2 data needs to be kept around for annotations. Converting an ID type into another is already _very_ complex from versioning/ID management PoV, but keeping legacy data for some use cases feels.... really not a good idea to me. And is going to make remapping a nightmare to handle. :(
Falk David commented 2024-04-11 17:37:37 +02:00
Author
Member
Copy Link

@mont29 What's your suggestion for fixing this crash then?

IMO we shouldn't make annotations any more complicated than they need to be. Converting annotations to CurvesGeometry seems like a lot of work for nothing.

@mont29 What's your suggestion for fixing this crash then? IMO we shouldn't make annotations any more complicated than they need to be. Converting annotations to `CurvesGeometry` seems like a lot of work for nothing.
Bastien Montagne commented 2024-04-12 11:38:53 +02:00
Owner
Copy Link

Talked with @filedescriptor directly, My suggestion is to detect and duplicate GPv2 IDs that would be used by both object and annotations.

Note that in theory, having a same GP ID used by both objects and annotations should not be possible - but it is trivial to do so through e.g. python RNA API or an add-on, so better sanitize the data before doing the conversion.

Talked with @filedescriptor directly, My suggestion is to detect and duplicate GPv2 IDs that would be used by both object and annotations. Note that in theory, having a same GP ID used by both objects and annotations should not be possible - but it is trivial to do so through e.g. python RNA API or an add-on, so better sanitize the data before doing the conversion.
Bastien Montagne commented 2024-04-12 16:34:46 +02:00
Owner
Copy Link

Alternative fix submitted as !120581.

Alternative fix submitted as !120581.
Bastien Montagne closed this pull request 2024-04-12 16:34:49 +02:00
All checks were successful
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Grease Pencil
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120294
No description provided.
Delete Branch "filedescriptor/blender:fix-120287"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?