WIP: Fix #119404: USD import: Incorrect translation for scaled bones #120328

Draft

Michael Kowalski wants to merge 2 commits from makowalski/blender:usd-skel-import-noisy-translations into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Michael Kowalski commented

2024-04-05 23:55:32 +02:00

Member

NOTE: This pull request is not yet ready for review.

This addresses an issue observed in #119404.

Non-unit scales in skeleton bind matrices can cause incorrect
translation values in the bone animation, because when computing
the translation components scaling is ignored.

This commit adds the code to apply the bind matrix scaling to
the translation.

Also added a call to normalize the bind transform when creating the
bones, to avoid an assertion failure in ED_armature_ebone_from_mat4()
when the transform has a non-unit scale.

To test, load the attached USD. Without the fix, very subtle changes in
translation cause big jumps in the animation.

**NOTE: This pull request is not yet ready for review.** This addresses an issue observed in #119404. Non-unit scales in skeleton bind matrices can cause incorrect translation values in the bone animation, because when computing the translation components scaling is ignored. This commit adds the code to apply the bind matrix scaling to the translation. Also added a call to normalize the bind transform when creating the bones, to avoid an assertion failure in ED_armature_ebone_from_mat4() when the transform has a non-unit scale. To test, load the attached USD. Without the fix, very subtle changes in translation cause big jumps in the animation.

skeleton_usd_with_schema.usda

1.1 MiB

Michael Kowalski added the

Pipeline, Assets & IO

labels 2024-04-05 23:55:32 +02:00

Michael Kowalski added 2 commits 2024-04-05 23:55:42 +02:00

06c3617a8d USD import: fix for scaled bind transforms

Normalizing the bind matrix.

Scaling bone translation curves by the bind
matrix scale.

8d4a89c9ae Merge branch 'main' into usd-skel-import-noisy-translations

Michael Kowalski added this to the USD project 2024-04-05 23:55:46 +02:00

Michael Kowalski changed title from ~~WIP: USD import: Incorrect translation for scaled bones~~ to WIP: Fix #119404: USD import: Incorrect translation for scaled bones

2024-04-06 00:30:09 +02:00

This pull request is marked as a work in progress.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u usd-skel-import-noisy-translations:makowalski-usd-skel-import-noisy-translations

git checkout makowalski-usd-skel-import-noisy-translations

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120328

No description provided.