blender
/
blender
134
398
Fork 579
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

Feature #120318: Add sculpt mask access in node tool #120378

Open
Prikshit singh wants to merge 3 commits from Prikshit-singh/blender:Feature/Sculpt_mask_node_tool into main
pull from: Prikshit-singh/blender:Feature/Sculpt_mask_node_tool
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 9 Commits 3 Files Changed 3 +149 -51
Prikshit singh commented 2024-04-07 18:35:40 +02:00
Contributor
Copy Link

Before:

blender_hBUcaVFYHJ

After:

blender_ZYq1ee5ZAz

tooltip:

blender_0v87GRHDvI

After implementing now it works something like this:

# Before: ![blender_hBUcaVFYHJ](/attachments/80942f9c-63c5-4ed2-bc43-b1dc2dc1cbb7) # After: ![blender_ZYq1ee5ZAz](/attachments/d528574f-8f09-414d-a220-a9cc3a6cb085) # tooltip: ![blender_0v87GRHDvI](/attachments/21f34954-af37-4959-a51d-3fb9aeb11bc1) After implementing now it works something like this:
blender_hBUcaVFYHJ.png
35 KiB
blender_ZYq1ee5ZAz.png
37 KiB
blender_0v87GRHDvI.png
41 KiB
❤️ 1 🚀 1
Prikshit singh added 1 commit 2024-04-07 18:35:49 +02:00
Prikshit singh requested review from Hans Goudey 2024-04-07 18:36:29 +02:00
Iliya Katushenock added this to the Nodes & Physics project 2024-04-07 18:39:23 +02:00
Iliya Katushenock added the
Module
Sculpt, Paint & Texture
Interest
Geometry Nodes
 labels 2024-04-07 18:39:33 +02:00
Prikshit singh requested review from Jacques Lucke 2024-04-08 05:15:30 +02:00
Jacques Lucke commented 2024-04-08 13:04:33 +02:00
Member
Copy Link

Thanks. Note that this is not a fix, but a new feature. The PR title should be changed.

Thanks. Note that this is not a fix, but a new feature. The PR title should be changed.
Prikshit singh changed title from Fix #120318: Add sculpt mask access in node tool to Feature #120318: Add sculpt mask access in node tool 2024-04-08 13:53:55 +02:00
Prikshit singh commented 2024-04-08 14:42:08 +02:00
Author
Contributor
Copy Link

Thanks. Note that this is not a fix, but a new feature. The PR title should be changed.

Done

> Thanks. Note that this is not a fix, but a new feature. The PR title should be changed. Done
Hans Goudey requested changes 2024-04-10 02:43:31 +02:00
Hans Goudey left a comment
Member
Copy Link

Thanks for working on this. It's not really what the design task describes though. There should be a new "Boolean/Float" enum property that changes the input socket type and the type of the stored attribute. The inversion should be done by the node itself for mesh sculpt mode mask storage, without input from the user.

Thanks for working on this. It's not really what the design task describes though. There should be a new "Boolean/Float" enum property that changes the input socket type and the type of the stored attribute. The inversion should be done by the node itself for mesh sculpt mode mask storage, without input from the user.
Prikshit singh commented 2024-04-10 05:20:00 +02:00
Author
Contributor
Copy Link

Thanks for working on this. It's not really what the design task describes though. There should be a new "Boolean/Float" enum property that changes the input socket type and the type of the stored attribute. The inversion should be done by the node itself for mesh sculpt mode mask storage, without input from the user.

Thanks, Now I understood, will work on that.

> Thanks for working on this. It's not really what the design task describes though. There should be a new "Boolean/Float" enum property that changes the input socket type and the type of the stored attribute. The inversion should be done by the node itself for mesh sculpt mode mask storage, without input from the user. Thanks, Now I understood, will work on that.
Prikshit singh commented 2024-04-11 21:04:01 +02:00
Author
Contributor
Copy Link

@HooglyBoogly I made some changes and the node looks and works something like this , your thoughts :

@HooglyBoogly I made some changes and the node looks and works something like this , your thoughts :
blender_ggv3feEVhr.mp4
3.5 MiB
Hans Goudey commented 2024-04-11 21:08:53 +02:00
Member
Copy Link

Looks better, nice! The behavior in sculpt mode when the node is set to "Boolean" seems wrong though, I'm not sure what happened there.

Looks better, nice! The behavior in sculpt mode when the node is set to "Boolean" seems wrong though, I'm not sure what happened there.
Prikshit singh commented 2024-04-11 21:14:27 +02:00
Author
Contributor
Copy Link

Thanks could you give me a clue how it should look like , also while defining the enums in DNA what should be the names of the boolean and float enum

Thanks could you give me a clue how it should look like , also while defining the enums in DNA what should be the names of the boolean and float enum
Hans Goudey commented 2024-04-11 21:31:08 +02:00
Member
Copy Link

That would be easier if you update the code and description of this PR.

I think the enum value can be defined in the node file actually, like enum class PatternMode {. That should make the naming clearer too.

That would be easier if you update the code and description of this PR. I think the enum value can be defined in the node file actually, like `enum class PatternMode {`. That should make the naming clearer too.
Prikshit singh commented 2024-04-11 21:35:37 +02:00
Author
Contributor
Copy Link

ok

ok
Prikshit singh added 1 commit 2024-04-11 22:52:43 +02:00
Prikshit singh requested review from Hans Goudey 2024-04-11 22:56:11 +02:00
Hans Goudey requested changes 2024-04-11 23:03:24 +02:00
Hans Goudey left a comment
Member
Copy Link

Getting there!

Getting there!
source/blender/nodes/geometry/nodes/node_geo_tool_selection.cc
@ -51,0 +66,4 @@
case GeometryComponent::Type::PointCloud:
return *attributes.lookup_or_default<float>(".selection", domain, true);
case GeometryComponent::Type::Mesh:
return *attributes.lookup_or_default<float>(".sculpt_mask", domain, true);
Hans Goudey commented 2024-04-11 22:59:35 +02:00
Member
Copy Link

This needs to be inverted (1.0 - value) since we store the inverse of selection. That can be done by inserting a field operation after the field input in node_geo_exec. Also the default values should be floats. And the default value should be 0 for .sculpt_mask.

This needs to be inverted (`1.0 - value`) since we store the inverse of selection. That can be done by inserting a field operation after the field input in `node_geo_exec`. Also the default values should be floats. And the default value should be 0 for `.sculpt_mask`.
Prikshit singh commented 2024-04-12 20:38:33 +02:00
Author
Contributor
Copy Link

I made all the necessary changes but still not able to understand this part ?

I made all the necessary changes but still not able to understand this part ?
Hans Goudey commented 2024-04-12 21:06:01 +02:00
Member
Copy Link

Could you clarify what you don't understand?

Could you clarify what you don't understand?
Prikshit singh commented 2024-04-12 21:09:10 +02:00
Author
Contributor
Copy Link

I don't understand where do i get the value from and what is the use of field operation here , to be specific why do we use field operation i didnt understand the use of it.

I don't understand where do i get the `value` from and what is the use of field operation here , to be specific why do we use field operation i didnt understand the use of it.
Hans Goudey commented 2024-04-12 21:12:34 +02:00
Member
Copy Link

Adding a FieldOperation here is like inserting an invisible node into the node graph before the set selection node. The value would be the input socket to that node. For an example, you could look at max_zero_fn and count_field in node_geo_duplicate_elements.cc

Adding a `FieldOperation` here is like inserting an invisible node into the node graph before the set selection node. The value would be the input socket to that node. For an example, you could look at `max_zero_fn` and `count_field` in `node_geo_duplicate_elements.cc`
Prikshit singh commented 2024-04-12 21:13:40 +02:00
Author
Contributor
Copy Link

ok

ok
Prikshit-singh marked this conversation as resolved
source/blender/nodes/geometry/nodes/node_geo_tool_selection.cc Outdated
@ -55,9 +80,16 @@ static void node_geo_exec(GeoNodeExecParams params)
}
if (params.user_data()->call_data->operator_data->mode == OB_MODE_OBJECT) {
params.set_output("Selection", true);
params.set_output("Float", false);
Hans Goudey commented 2024-04-11 23:00:34 +02:00
Member
Copy Link

false -> 1.0f

`false` -> `1.0f`
Prikshit singh commented 2024-04-13 21:00:07 +02:00
Author
Contributor
Copy Link

Done

Done
Prikshit-singh marked this conversation as resolved
source/blender/nodes/geometry/nodes/node_geo_tool_set_selection.cc Outdated
@ -83,0 +66,4 @@
if (Mesh *mesh = geometry.get_mesh_for_write()) {
if (params.user_data()->call_data->operator_data->mode == OB_MODE_SCULPT) {
Field<bool> inverted = invert_boolean_field(selection);
bke::try_capture_field_on_geometry(
Hans Goudey commented 2024-04-11 23:02:30 +02:00
Member
Copy Link

Writing to a float attribute with the boolean field isn't correct. ".sculpt_mask" should be written as a float attribute

Writing to a float attribute with the boolean field isn't correct. `".sculpt_mask"` should be written as a float attribute
Prikshit singh commented 2024-04-12 19:49:56 +02:00
Author
Contributor
Copy Link

how can i convert boolean field into float attribute

how can i convert boolean field into float attribute
Hans Goudey commented 2024-04-12 19:53:01 +02:00
Member
Copy Link

Check out uses of BKE_type_conversions.hh in geometry nodes.

Check out uses of `BKE_type_conversions.hh` in geometry nodes.
Prikshit-singh marked this conversation as resolved
Prikshit singh added 1 commit 2024-04-12 22:21:24 +02:00
Prikshit singh requested review from Hans Goudey 2024-04-12 22:21:48 +02:00
Prikshit singh commented 2024-04-17 19:14:37 +02:00
Author
Contributor
Copy Link

@HooglyBoogly any changes required to the latest PR

@HooglyBoogly any changes required to the latest PR
Merge conflict checking is in progress. Try again in few moments.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u Feature/Sculpt_mask_node_tool:Prikshit-singh-Feature/Sculpt_mask_node_tool
git checkout Prikshit-singh-Feature/Sculpt_mask_node_tool
Sign in to join this conversation.
Reviewers
No reviewers
Jacques Lucke
Hans Goudey
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Nodes & Physics
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120378
No description provided.
Delete Branch "Prikshit-singh/blender:Feature/Sculpt_mask_node_tool"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?