blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 768 Projects 19 Wiki Activity

Fix #120393: Outliner: Inconsistent dim on hidden items #120397

Merged
Pratik Borhade merged 5 commits from PratikPB2123/blender:120393-outliner-nonob-fade into main 2024-04-18 14:05:33 +02:00
Conversation 10 Commits 5 Files Changed 1 +39 -18
Pratik Borhade commented 2024-04-08 13:19:43 +02:00
Member
Copy Link

non object tree elements are not faded in outliner when object or parent
collection is hidden. So in case of non ID_OB, call element_should_draw_faded
and pass parent tree element as argument to decide the fade status.

Main PR
outliner-main outliner-PR
non object tree elements are not faded in outliner when object or parent collection is hidden. So in case of non ID_OB, call `element_should_draw_faded` and pass parent tree element as argument to decide the fade status. | Main | PR | | -- | -- | | ![outliner-main](/attachments/95845872-6f60-4176-bf85-1cfab1e6c661) | ![outliner-PR](/attachments/4fa84d61-28dd-4517-a4c7-3e45a740064a) |
outliner-main.png
24 KiB
outliner-PR.png
23 KiB
Pratik Borhade added 1 commit 2024-04-08 13:19:55 +02:00
bb05e6898e Fix #120393: Outliner: Inconsistent dim on hidden items 
non object tree elements are not faded in outliner when object or parent
collection is hidden. So in case of non ID_OB, call `element_should_draw_faded`
and pass parent tree element as argument to decide the fade status.
Pratik Borhade requested review from Pablo Vazquez 2024-04-08 13:20:17 +02:00
Pratik Borhade requested review from Julian Eisel 2024-04-08 13:20:17 +02:00
Pratik Borhade added the
Module
User Interface
 label 2024-04-08 13:20:34 +02:00
Pratik Borhade added 1 commit 2024-04-08 13:23:56 +02:00
Pablo Vazquez commented 2024-04-08 14:21:41 +02:00
Member
Copy Link

Thanks for working on it!

Haven't tested the patch yet but looking at the images it seems the Object icon (orange) is still fully opaque, while it should be dimmed. Similar to how object data icons are dimmed when the object is collapsed:

dimmed icons

In main, the Collection icon seems to dim properly when the item is hidden, also the other icons in the row (child data).

Thanks for working on it! Haven't tested the patch yet but looking at the images it seems the Object icon (orange) is still fully opaque, while it should be dimmed. Similar to how object data icons are dimmed when the object is collapsed: ![dimmed icons](/attachments/83694efe-095d-44c4-9e21-c3983a5a8a48) In main, the Collection icon seems to dim properly when the item is hidden, also the other icons in the row (child data). <video src="/attachments/c1bd6fd1-cf8f-4583-b040-a7d00160affd" controls></video>
Screen Recording 2024-04-08 at 14.22.47.mov
800 KiB
image.png
17 KiB
Pratik Borhade added 1 commit 2024-04-09 11:22:56 +02:00
Pratik Borhade commented 2024-04-09 11:25:01 +02:00
Author
Member
Copy Link

Thanks @pablovazquez for the review 🙂. Updated the PR to dim object icons if they are hidden.

Thanks @pablovazquez for the review 🙂. Updated the PR to dim object icons if they are hidden.
Pablo Vazquez commented 2024-04-09 11:47:54 +02:00
Member
Copy Link

@PratikPB2123 Awesome! Just one more thing, the hierarchy line is missing to be dimmed. Since the arrows dim I think the hierarchy lines should too.

@PratikPB2123 Awesome! Just one more thing, the hierarchy line is missing to be dimmed. Since the arrows dim I think the hierarchy lines should too. <video src="/attachments/65a1948e-b984-47ab-9c0d-3d7e4f97b52b" title="Screen Recording 2024-04-09 at 11.44.27.mov" controls></video>
Screen Recording 2024-04-09 at 11.44.27.mov
1.1 MiB
👍 1
Pratik Borhade added 1 commit 2024-04-09 12:44:46 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
32632035a0 Fade hierarchy line color
Pablo Vazquez commented 2024-04-09 13:02:42 +02:00
Member
Copy Link

Yay! Works great now! +1 from me, perhaps @JulianEisel wants to have a look at the code.

This is the current state:

Comparison

4.1 patch
4.1 4.2
Yay! Works great now! +1 from me, perhaps @JulianEisel wants to have a look at the code. This is the current state: <video src="/attachments/c993aa51-ffc1-4caa-b765-5d1ea88fe2f0" title="Screen Recording 2024-04-09 at 12.58.27.mov" controls></video> ### Comparison |4.1|patch| |----|----| |![4.1](/attachments/39ea5260-3c64-4cc7-b90e-5cc14fe6a3e9)|![4.2](/attachments/b567102b-cf9d-4bf3-b380-f8d9e5183e76)|
Screen Recording 2024-04-09 at 12.58.27.mov
904 KiB
image.png
90 KiB
image.png
93 KiB
Pablo Vazquez approved these changes 2024-04-09 13:02:54 +02:00
Julian Eisel approved these changes 2024-04-17 16:03:10 +02:00
Pratik Borhade commented 2024-04-18 12:39:32 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Pratik Borhade added 1 commit 2024-04-18 13:09:35 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
f23fdcf62c Merge branch 'main' into 120393-outliner-nonob-fade
Pratik Borhade commented 2024-04-18 13:10:49 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Pratik Borhade merged commit f1955e1c57 into main 2024-04-18 14:05:33 +02:00
Pratik Borhade deleted branch 120393-outliner-nonob-fade 2024-04-18 14:05:35 +02:00
Pratik Borhade commented 2024-04-18 14:06:12 +02:00
Author
Member
Copy Link

Merged, thanks for reviewing 🙂

Merged, thanks for reviewing 🙂
❤️ 1
Pablo Vazquez commented 2024-04-18 17:10:57 +02:00
Member
Copy Link

@PratikPB2123 sorry I missed this, thought I'd mention it here before making a new bug report:

Bug

Actions and Modifiers are not getting grayed out properly:

actions and modifiers in Outliner

Improvements

Optional improvements, let me know if I should make a new design task for it:

Each modifier could be grayed out if both screen and render visibility is off:
modifier

As well as ViewLayers disabled from render, in the Scene display mode in Outliner:
viewlayer

And in the same display mode, Collections are also missing grayed out:
Collections

Thanks!

@PratikPB2123 sorry I missed this, thought I'd mention it here before making a new bug report: ## Bug Actions and Modifiers are not getting grayed out properly: ![actions and modifiers in Outliner](/attachments/cd3996d8-db1b-47e9-ab07-4baf58788328) ---- ## Improvements Optional improvements, let me know if I should make a new design task for it: Each modifier could be grayed out if both screen and render visibility is off: ![modifier](/attachments/54e93d4d-5c93-48d2-8756-538b9289468c) As well as ViewLayers disabled from render, in the Scene display mode in Outliner: ![viewlayer](/attachments/6ac7a6dd-6975-4f26-b71b-605c335d5c7b) And in the same display mode, Collections are also missing grayed out: ![Collections](/attachments/689092c7-d24b-4bad-97ff-7ad59b9db1cf) Thanks!
image.png
49 KiB
image.png
90 KiB
image.png
14 KiB
image.png
26 KiB
Pratik Borhade commented 2024-04-18 17:53:57 +02:00
Author
Member
Copy Link

Hi, I'll take a look tomorrow. A design task will help for optional improvements 😅

Hi, I'll take a look tomorrow. A design task will help for optional improvements 😅
Pratik Borhade commented 2024-04-19 10:32:26 +02:00
Author
Member
Copy Link

Actions and Modifiers are not getting grayed out properly:

Created: !120813

> Actions and Modifiers are not getting grayed out properly: Created: !120813
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Julian Eisel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120397
No description provided.
Delete Branch "PratikPB2123/blender:120393-outliner-nonob-fade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?