Fix #120421: Animated "Burn metadata into image" ignored during render #120429

Philipp Oeser · 2024-04-09T14:11:00+02:00

Philipp Oeser commented

2024-04-09 14:11:00 +02:00

Seems like scene RenderData only gets synched once from Scene to
BaseRender in RE_InitState .
Animation on it is only evaluating on the scene, so the the BaseRender
RenderData is not properly updated here.

However R_STAMP_DRAW is part of that and it is the BaseRender
RenderData that is checked in do_render_full_pipeline (not the
Scene one) to determine if we want to stamp.

Later calls to BKE_render_result_stamp_info / renderresult_stampinfo
/ stampdata always get passed the scene, so individual animation stamp
details (such as Render Time) work properly.

So to resolve, use the Scene RenderData (rather than the
BaseRender one) for proper animation update.

NOTE: I noticed a comment about thread safety in RE_InitState, not
sure if this is relevant here
NOTE: this (not updating animation of members of RenderData) might
actually be a problem elsewhere, too -- havent checked on this in detail
though

Seems like scene `RenderData` only gets synched once from `Scene` to `BaseRender` in `RE_InitState` . Animation on it is only evaluating on the scene, so the the `BaseRender` `RenderData` is not properly updated here. However `R_STAMP_DRAW` is part of that and it is the `BaseRender` `RenderData` that is checked in `do_render_full_pipeline` (not the `Scene` one) to determine if we want to stamp. Later calls to `BKE_render_result_stamp_info` / `renderresult_stampinfo` / `stampdata` always get passed the scene, so individual animation stamp details (such as Render Time) work properly. So to resolve, use the `Scene` `RenderData` (rather than the `BaseRender` one) for proper animation update. NOTE: I noticed a comment about thread safety in `RE_InitState`, not sure if this is relevant here NOTE: this (not updating animation of members of `RenderData`) might actually be a problem elsewhere, too -- havent checked on this in detail though

Philipp Oeser added 1 commit 2024-04-09 14:11:11 +02:00

b5aef5615c Fix #120421 : Animated "Burn metadata into image" ignored during render

Seems like scene `RenderData` only gets synched once from `Scene` to
`BaseRender` in `RE_InitState` .
Animation on it is only evaluating on the scene, so the the `BaseRender`
`RenderData` is not properly updated here.

However `R_STAMP_DRAW` is part of that and it is the `BaseRender`
`RenderData` that is checked in `do_render_full_pipeline` (not the
`Scene` one) to determine if we want to stamp.

Later calls to `BKE_render_result_stamp_info` / `renderresult_stampinfo`
/ `stampdata` always get passed the scene, so individual animation stamp
details (such as Render Time) work properly.

So to resolve, use the `Scene` `RenderData` (rather than the
`BaseRender` one) for proper animation update.

NOTE: I noticed a comment about thread safety in `RE_InitState`, not
sure if this is relevant here
NOTE: this (not updating animation of members of `RenderData`) might
actually be a problem elsewhere, too -- havent checked on this in detail
though

Philipp Oeser added this to the Render & Cycles project 2024-04-09 14:11:38 +02:00

Philipp Oeser added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #120421: Animated "Burn metadata into image" ignored during render #120429