Cycles: Allow get_apple_gpu_architecture to report non Apple GPUs #120448

Alaska · 2024-04-10T02:02:50+02:00

Alaska commented

2024-04-10 02:02:50 +02:00

get_apple_gpu_architecture will now report if the GPU being checked
is not a Apple GPU.

At the moment this has no functional changes. But it reduces the
chances of mistakes in the future where a developer tries to enable
a feature on newer Apple GPUs using get_apple_gpu_architecture,
and accidentally enables it on unsupported AMD and Intel GPUs.
(E.G. The issue that was fixed with !120299)

`get_apple_gpu_architecture` will now report if the GPU being checked is not a Apple GPU. At the moment this has no functional changes. But it reduces the chances of mistakes in the future where a developer tries to enable a feature on newer Apple GPUs using `get_apple_gpu_architecture`, and accidentally enables it on unsupported AMD and Intel GPUs. (E.G. The issue that was fixed with !120299)

Alaska added 1 commit 2024-04-10 02:02:59 +02:00

173b2f4e89 More complex 120299

Alaska referenced this pull request

2024-04-10 02:03:43 +02:00

Cycles: Properly default to Metal-RT off unless GPU is a M3 or newer #120299

Alaska commented

2024-04-10 02:05:58 +02:00

@Sergey commented that we may want this code change in #120299 (comment), but expressed concerns about it being a bigger change that may be more risky (which was a concern for that pull request because we needed to backport it to 4.1.1 to fix major issues on AMD GPU Macs, and reducing risk is a priority).

Since this code change only has a impact on future development, there is no need to risk backporting this to 4.1.X

@Sergey commented that we may want this code change in https://projects.blender.org/blender/blender/pulls/120299#issuecomment-1163700, but expressed concerns about it being a bigger change that may be more risky (which was a concern for that pull request because we needed to backport it to 4.1.1 to fix major issues on AMD GPU Macs, and reducing risk is a priority). Since this code change only has a impact on future development, there is no need to risk backporting this to 4.1.X

Alaska requested review from Sergey Sharybin 2024-04-10 02:06:17 +02:00

Alaska requested review from Brecht Van Lommel 2024-04-10 02:06:24 +02:00

Alaska added 1 commit 2024-04-10 02:09:15 +02:00

781b9e1806 Adjust code comment

Alaska added 1 commit 2024-04-10 02:48:13 +02:00