GPv3: Cleanup: Rename keymap functions to gpencil_legacy #120506

Merged
Lukas Tönne merged 1 commits from LukasTonne/blender:gp3-keymap-legacy-rename into main 2024-04-11 12:56:28 +02:00
Member

This should reduce the confusion a bit when more GPv3 keymaps are added
using the grease_pencil prefix.

This should reduce the confusion a bit when more GPv3 keymaps are added using the `grease_pencil` prefix.
Lukas Tönne added 1 commit 2024-04-11 10:13:19 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
82e5d6d125
GPv3: Cleanup: Rename keymap functions to `gpencil_legacy`.
This should reduce the confusion a bit when more GPv3 keymaps are added
using the `grease_pencil` prefix.
Lukas Tönne added this to the Grease Pencil project 2024-04-11 10:13:24 +02:00
Author
Member

@blender-bot build

@blender-bot build
Member

Hi, I know this is not required but for consistency we could also rename existing functions gpencil_ -> gpencil_legacy in default and ic keymap? :)

Hi, I know this is not required but for consistency we could also rename existing functions `gpencil_` -> `gpencil_legacy` in default and ic keymap? :)
Member

@PratikPB2123 Which functions are you taking about?

@PratikPB2123 Which functions are you taking about?
Member
For example: https://projects.blender.org/blender/blender/src/branch/main/scripts/presets/keyconfig/keymap_data/blender_default.py#L8810-L8833
Author
Member

@PratikPB2123 I think those functions are ok, since they deal with tool settings, which we are still using the same way. The keymaps are specifically for the legacy object types, so indicating that the keymap functions are for legacy features makes more sense.

@PratikPB2123 I think those functions are ok, since they deal with tool settings, which we are still using the same way. The keymaps are specifically for the legacy object types, so indicating that the keymap functions are for legacy features makes more sense.
Falk David approved these changes 2024-04-11 12:52:35 +02:00
Falk David left a comment
Member

Thanks, looks good.

Thanks, looks good.
Lukas Tönne merged commit 483802b62d into main 2024-04-11 12:56:28 +02:00
Lukas Tönne deleted branch gp3-keymap-legacy-rename 2024-04-11 12:56:31 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120506
No description provided.