Anim: Add 'Select Left' and 'Select Right Handles' entries in Graph Editor #120570

Open
Nika Kutsniashvili wants to merge 1 commits from nickberckley/blender:select-handles into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

View File

@ -225,10 +225,18 @@ class GRAPH_MT_select(Menu):
props.mode = 'RIGHT'
layout.separator()
props = layout.operator("graph.select_key_handles", text="Select Handles")
props = layout.operator("graph.select_key_handles", text="Select Both Handles")
props.left_handle_action = 'SELECT'
props.right_handle_action = 'SELECT'
props.key_action = 'KEEP'
props = layout.operator("graph.select_key_handles", text="Select Left Handles")
props.left_handle_action = 'SELECT'
props.right_handle_action = 'KEEP'
Review

Should this be DESELECT? (Also equivalently for left_handle_action in "Select Right Handles".) At least, my understanding was that the use case for this is to quickly select just the left or right handles, to grab and move them around.

Should this be `DESELECT`? (Also equivalently for `left_handle_action` in "Select Right Handles".) At least, my understanding was that the use case for this is to quickly select *just* the left or right handles, to grab and move them around.

It can be. But before we have mechanism to choose between keeping selection or not, think this is more useful, because it gives you ability to quickly select both handles without key.

It can be. But before we have mechanism to choose between keeping selection or not, think this is more useful, because it gives you ability to quickly select both handles without key.
Review

(Sorry for the delayed response!)

I guess it just seems kind of esoteric to me. From the name I would expect both the key and the opposite handle to be KEEP, or both to be DESELECT. Having one be DESELECT and the other KEEP feels odd and unexpected to me.

If selecting both handles + deselecting the key is a common enough use case to justify this (IMO) unexpected behavior, then I think it's common enough to instead just make its own menu item. "Select Only Handles" or something like that. And that way the user can immediately jump to the selection state they want to be in, without having to juggle or consider the current selection state to get there.

(Sorry for the delayed response!) I guess it just seems kind of esoteric to me. From the name I would expect both the key and the opposite handle to be `KEEP`, or both to be `DESELECT`. Having one be `DESELECT` and the other `KEEP` feels odd and unexpected to me. If selecting both handles + deselecting the key is a common enough use case to justify this (IMO) unexpected behavior, then I think it's common enough to instead just make its own menu item. "Select Only Handles" or something like that. And that way the user can immediately jump to the selection state they want to be in, without having to juggle or consider the current selection state to get there.
props.key_action = 'DESELECT'
props = layout.operator("graph.select_key_handles", text="Select Right Handles")
props.left_handle_action = 'KEEP'
props.right_handle_action = 'SELECT'
props.key_action = 'DESELECT'
props = layout.operator("graph.select_key_handles", text="Select Key")
props.left_handle_action = 'DESELECT'
props.right_handle_action = 'DESELECT'