UI: Fix and improve a few messages #120649

Merged
Hans Goudey merged 2 commits from pioverfour/blender:dp_fix_messages into main 2024-04-15 20:02:49 +02:00
Member
  • "Log Encoding with Chroma inset and rotation": add "of primaries" in
    the description of the AgX Log color space to better explain the
    operation, based on wording in !106355.
  • Remove a few double spaces.
  • Make Line Art title case everywhere, to convey it's the system /
    brand / product name and not the generic concept.
  • "Copy Absolute coordinates or Normal vector" -> "of Normal Vector":
    typo.
  • "Makes a link between selected output in input sockets" ->
    "Make...", "output and input": typo.
  • "Purge Unused Data From This File" -> "from this": title case as per
    HIGs.
  • GPencil -> Grease Pencil: no reason to use an abbreviation here.
  • "Around Current Frame" -> "Around Frame": actual name of the
    onion-skinning method.
  • "... (layer height for layer tool, i.e.)" -> "(i.e. the layer height
    for the layer tool)": put "i.e." at the start of the sentence.
  • Expand description of toe-in stereo camera option.
  • "Children collections their parent-collection-specific settings" ->
    "Children collections with their...": typo.
  • "Generate vertex weights base on..." -> "based on" : typo, lower
    case.
  • Expand description of GP modifier properties, based on their mesh
    counterparts.
  • "AEnvelope" -> "Envelope": typo.
  • "Falloff type the feather" -> "of the feather": typo.
  • "usually make transition as long as effect strip": rephrase.
  • "When disabled a users extensions directory is created" -> "a
    user's": typo.
  • "successfull" -> "successful": typo.
  • "Remove all attributes... a single wildcard (*).": remove trailing
    ".".
  • "..., use "Save Preferences."": remove trailing ".".

Some issues reported by Marina Veselkova and Tamar Mebonia.

- "Log Encoding with Chroma inset and rotation": add "of primaries" in the description of the AgX Log color space to better explain the operation, based on wording in !106355. - Remove a few double spaces. - Make Line Art title case everywhere, to convey it's the system / brand / product name and not the generic concept. - "Copy Absolute coordinates or Normal vector" -> "of Normal Vector": typo. - "Makes a link between selected output in input sockets" -> "Make...", "output and input": typo. - "Purge Unused Data From This File" -> "from this": title case as per HIGs. - GPencil -> Grease Pencil: no reason to use an abbreviation here. - "Around Current Frame" -> "Around Frame": actual name of the onion-skinning method. - "... (layer height for layer tool, i.e.)" -> "(i.e. the layer height for the layer tool)": put "i.e." at the start of the sentence. - Expand description of toe-in stereo camera option. - "Children collections their parent-collection-specific settings" -> "Children collections with their...": typo. - "Generate vertex weights base on..." -> "based on" : typo, lower case. - Expand description of GP modifier properties, based on their mesh counterparts. - "AEnvelope" -> "Envelope": typo. - "Falloff type the feather" -> "of the feather": typo. - "usually make transition as long as effect strip": rephrase. - "When disabled a users extensions directory is created" -> "a user's": typo. - "successfull" -> "successful": typo. - "Remove all attributes... a single wildcard (*).": remove trailing ".". - "..., use "Save Preferences."": remove trailing ".". Some issues reported by Marina Veselkova and Tamar Mebonia.
Damien Picard added the
Module
User Interface
label 2024-04-15 01:16:00 +02:00
Damien Picard added 1 commit 2024-04-15 01:16:06 +02:00
81b6cd3018 UI: Fix and improve a few messages
- "Log Encoding with Chroma inset and rotation": add "of primaries" in
  the description of the AgX Log color space to better explain the
  operation, based on wording in !106355.
- Remove a few double spaces.
- Make Line Art title case everywhere, to convey it's the system /
  brand / product name and not the generic concept.
- "Copy Absolute coordinates or Normal vector" -> "of Normal Vector":
typo.
- "Makes a link between selected output in input sockets" ->
  "Make...", "output and input": typo.
- "Purge Unused Data From This File" -> "from this": title case as per
  HIGs.
- GPencil -> Grease Pencil: no reason to use an abbreviation here.
- "Around Current Frame" -> "Around Frame": actual name of the
  onion-skinning method.
- "... (layer height for layer tool, i.e.)" -> "(i.e. the layer height
  for the layer tool)": put "i.e." at the start of the sentence.
- Expand description of toe-in stereo camera option.
- "Children collections their parent-collection-specific settings" ->
  "Children collections with their...": typo.
- "Generate vertex weights base on..." -> "based on" : typo, lower
  case.
- Expand description of GP modifier properties, based on their mesh
  counterparts.
- "AEnvelope" -> "Envelope": typo.
- "Falloff type the feather" -> "of the feather": typo.
- "usually make transition as long as effect strip": rephrase.
- "When disabled a users extensions directory is created" -> "a
  user's": typo.
- "successfull" -> "successful": typo.
- "Remove all attributes... a single wildcard (*).": remove trailing
  ".".
- "..., use "Save Preferences."": remove trailing ".".

Some issues reported by Marina Veselkova and Tamar Mebonia.
Damien Picard reviewed 2024-04-15 01:30:20 +02:00
@ -348,3 +348,3 @@
bitdepth: 32f
description: |
Log Encoding with Chroma inset and rotation, and with 25 Stops of Dynamic Range
Log Encoding with Chroma inset and rotation of primaries, and with 25 Stops of Dynamic Range
Author
Member

Add "of primaries" to better explain the operation, based on wording in !106355.

Add "of primaries" to better explain the operation, based on wording in !106355.
@ -4622,3 +4622,3 @@
BLO_reportf_wrap(basefd->reports,
RPT_INFO,
RPT_("Read packed library: '%s', parent '%s'"),
RPT_("Read packed library: '%s', parent '%s'"),
Author
Member

double spaces

double spaces
@ -571,3 +571,3 @@
"Include Animations",
"Export animations if available (exporting animations will enforce the decomposition of "
"node transforms into <translation> <rotation> and <scale> components)");
"node transforms into <translation> <rotation> and <scale> components)");
Author
Member

double spaces

double spaces
@ -9512,3 +9512,3 @@
false,
"Absolute Coordinates",
"Copy Absolute coordinates or Normal vector");
"Copy Absolute coordinates of Normal vector");
Author
Member

typo

typo
@ -1588,3 +1588,3 @@
true,
"Show In Front",
"Show line art grease pencil in front of everything");
"Show Line Art grease pencil in front of everything");
Author
Member

Make Line Art title case everywhere, to convey it's the system /
brand / product name and not the generic concept.

Make Line Art title case everywhere, to convey it's the system / brand / product name and not the generic concept.
@ -1205,3 +1205,3 @@
ibuf, ima->flag & IMA_HIGH_BITDEPTH, ibuf->planes >= 8);
const char *texture_format_description = GPU_texture_format_name(texture_format);
ofs += BLI_snprintf_rlen(str + ofs, len - ofs, RPT_(", %s"), texture_format_description);
ofs += BLI_snprintf_rlen(str + ofs, len - ofs, RPT_(", %s"), texture_format_description);
Author
Member

double spaces

double spaces
@ -1456,3 +1456,3 @@
/* identifiers */
ot->name = "Make Links";
ot->description = "Makes a link between selected output in input sockets";
ot->description = "Make a link between selected output and input sockets";
Author
Member

typo

typo
@ -2217,3 +2217,3 @@
op,
unused_message_popup_width_compute(C),
IFACE_("Purge Unused Data From This File"),
IFACE_("Purge Unused Data from this File"),
Author
Member

title case as per HIGs

title case as per HIGs
@ -439,3 +439,3 @@
if (use_cache && !is_first) {
uiItemL(layout, "Cached from the first line art modifier.", ICON_INFO);
uiItemL(layout, "Cached from the first Line Art modifier.", ICON_INFO);
Author
Member

Make Line Art title case everywhere, to convey it's the system / brand / product name and not the generic concept

Make Line Art title case everywhere, to convey it's the system / brand / product name and not the generic concept
@ -291,3 +291,3 @@
Object *ob = CTX_data_active_object(C);
if (!ob || ob->type != OB_GPENCIL_LEGACY) {
WM_report(RPT_ERROR, "No active object or active object isn't a GPencil object");
WM_report(RPT_ERROR, "No active object, or active object isn't a Grease Pencil object");
Author
Member

no reason to use an abbreviation here

no reason to use an abbreviation here
@ -193,3 +193,3 @@
BKE_reportf(reports,
RPT_ERROR,
"%s: Can't write to asset %s: %s",
"%s: Can't write to asset %s: %s",
Author
Member

double spaces

double spaces
@ -187,3 +187,3 @@
BKE_reportf(reports,
RPT_ERROR,
"An exception occurred invoking USD hook '%s'. Please see the console for details",
"An exception occurred invoking USD hook '%s'. Please see the console for details",
Author
Member

double spaces

double spaces
@ -764,3 +764,3 @@
BKE_reportf(reports,
RPT_WARNING,
"%s: Mismatch in bind xforms and joint counts for skeleton %s",
"%s: Mismatch in bind xforms and joint counts for skeleton %s",
Author
Member

double spaces

double spaces
@ -283,3 +283,3 @@
"Start Frame",
"Starting frame of range of paths to display/calculate "
"(not for 'Around Current Frame' Onion-skinning method)");
"(not for 'Around Frame' Onion-skinning method)");
Author
Member

actual name of the onion-skinning method

actual name of the onion-skinning method
@ -3060,1 +3060,3 @@
prop, "Brush Height", "Affectable height of brush (layer height for layer tool, i.e.)");
prop,
"Brush Height",
"Affectable height of brush (i.e. the layer height for the layer tool)");
Author
Member

put "i.e." at the start of the sentence

put "i.e." at the start of the sentence
@ -425,0 +425,4 @@
"TOE",
0,
"Toe-in",
"Rotated cameras, looking at the same point at the convergence distance"},
Author
Member

Expand description of toe-in stereo camera option.

Expand description of toe-in stereo camera option.
@ -695,3 +695,3 @@
RNA_def_property_ui_text(prop,
"Collection Children",
"Children collections their parent-collection-specific settings");
"Children collections with their parent-collection-specific settings");
Author
Member

typo

typo
@ -762,3 +762,3 @@
prop = RNA_def_property(srna, "lineart_usage", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, rna_collection_lineart_usage);
RNA_def_property_ui_text(prop, "Usage", "How to use this collection in line art");
RNA_def_property_ui_text(prop, "Usage", "How to use this collection in Line Art calculation");
Author
Member

add "calculation" to mirror the object Line Art description

add "calculation" to mirror the object Line Art description
@ -50,3 +50,3 @@
ICON_MOD_VERTEX_WEIGHT,
"Vertex Weight Angle",
"Generate Vertex Weights base on stroke angle"},
"Generate vertex weights based on stroke angle"},
Author
Member

typo

typo
@ -2439,2 +2439,3 @@
RNA_def_property_boolean_sdna(prop, nullptr, "flag", GP_ARRAY_USE_OB_OFFSET);
RNA_def_property_ui_text(prop, "Use Object Offset", "Enable object offset");
RNA_def_property_ui_text(
prop, "Use Object Offset", "Add another object's transformation to the total offset");
Author
Member

Expand description of GP modifier properties, based on their mesh
counterparts.

Expand description of GP modifier properties, based on their mesh counterparts.
@ -1036,3 +1036,3 @@
RNA_def_property_enum_sdna(prop, nullptr, "falloff");
RNA_def_property_enum_items(prop, rna_enum_proportional_falloff_curve_only_items);
RNA_def_property_ui_text(prop, "Falloff", "Falloff type the feather");
RNA_def_property_ui_text(prop, "Falloff", "Falloff type of the feather");
Author
Member

typo

typo
@ -56,3 +56,3 @@
ICON_MOD_VERTEX_WEIGHT,
"Vertex Weight Proximity",
"Generate Vertex Weights base on distance to object"},
"Generate vertex weights based on distance to object"},
Author
Member

typo

typo
@ -8672,3 +8672,3 @@
RNA_def_property_override_flag(prop, PROPOVERRIDE_OVERRIDABLE_LIBRARY);
RNA_def_property_ui_text(
prop, "Camera Object", "Use specified camera object for generating line art");
prop, "Camera Object", "Use specified camera object for generating Line Art strokes");
Author
Member

Add "strokes" to reuse a message from the legacy modifier.

Add "strokes" to reuse a message from the legacy modifier.
@ -9541,2 +9541,3 @@
RNA_def_property_boolean_sdna(prop, nullptr, "flag", MOD_GREASE_PENCIL_ARRAY_USE_OB_OFFSET);
RNA_def_property_ui_text(prop, "Use Object Offset", "Enable object offset");
RNA_def_property_ui_text(
prop, "Use Object Offset", "Add another object's transformation to the total offset");
Author
Member

Expand description of GP modifier properties, based on their mesh
counterparts.

Expand description of GP modifier properties, based on their mesh counterparts.
@ -10338,3 +10339,3 @@
srna = RNA_def_struct(brna, "GreasePencilEnvelopeModifier", "Modifier");
RNA_def_struct_ui_text(
srna, "Grease Pencil Envelope Modifier", "AEnvelope stroke effect modifier");
srna, "Grease Pencil Envelope Modifier", "Envelope stroke effect modifier");
Author
Member

Typo

Typo
@ -6549,3 +6549,3 @@
RNA_def_property_enum_sdna(prop, nullptr, "falloff");
RNA_def_property_enum_items(prop, rna_enum_proportional_falloff_curve_only_items);
RNA_def_property_ui_text(prop, "Falloff", "Falloff type the feather");
RNA_def_property_ui_text(prop, "Falloff", "Falloff type of the feather");
Author
Member

typo

typo
@ -1476,3 +1476,3 @@
RNA_def_struct_sdna(srna, "GP_Sculpt_Guide");
RNA_def_struct_path_func(srna, "rna_GPencilSculptGuide_path");
RNA_def_struct_ui_text(srna, "GPencil Sculpt Guide", "Guides for drawing");
RNA_def_struct_ui_text(srna, "Grease Pencil Sculpt Guide", "Guides for drawing");
Author
Member

no reason to use an abbreviation here

no reason to use an abbreviation here
@ -2313,1 +2309,3 @@
"effect strip)");
RNA_def_property_ui_text(prop,
"Use Default Fade",
"Fade effect using the built-in default (usually makes the transition "
Author
Member

slightly rephrase "usually make transition" -> "usually makes the transition"

slightly rephrase "usually make transition" -> "usually makes the transition"
@ -5691,2 +5691,2 @@
RNA_def_property_ui_text(
prop, "Duplicate GPencil", "Causes grease pencil data to be duplicated with the object");
RNA_def_property_ui_text(prop,
"Duplicate Grease Pencil",
Author
Member

no reason to use an abbreviation

no reason to use an abbreviation
@ -6680,3 +6681,3 @@
"Custom Directory",
"Manually set the path for extensions to be stored. "
"When disabled a users extensions directory is created");
"When disabled a user's extensions directory is created");
Author
Member

typo

typo
@ -42,3 +42,3 @@
.dependent_field({2, 3})
.description(
"Whether the sampling was successfull. It can fail when the sampled group is empty");
"Whether the sampling was successful. It can fail when the sampled group is empty");
Author
Member

typo

typo
@ -157,3 +157,3 @@
"Wildcard",
"Remove all attributes that match the pattern which is allowed to contain a single "
"wildcard (*)."},
"wildcard (*)"},
Author
Member

trailing "."

trailing "."
@ -47,3 +47,3 @@
.dependent_field({3, 4})
.description(
"Whether the sampling was successfull. It can fail when the sampled group is empty");
"Whether the sampling was successful. It can fail when the sampled group is empty");
Author
Member

typo

typo
@ -956,3 +956,3 @@
BKE_reportf(bf_reports->reports,
RPT_WARNING,
"%d libraries have overrides needing resync (auto resynced in %.0fm%.2fs), "
"%d libraries have overrides needing resync (auto resynced in %.0fm%.2fs), "
Author
Member

double spaces

double spaces
@ -2569,3 +2569,3 @@
op,
title.c_str(),
IFACE_("To make changes to Preferences permanent, use \"Save Preferences.\""),
IFACE_("To make changes to Preferences permanent, use \"Save Preferences\""),
Author
Member

trailing "."

trailing "."
Damien Picard requested review from Hans Goudey 2024-04-15 01:31:12 +02:00
Member

"Purge Unused Data From This File" -> "from this": title case as per HIGs.

We use MLA title case, in which case this should be Purge Unused Data from This File, according to https://titlecaseconverter.com/.

> "Purge Unused Data From This File" -> "from this": title case as per HIGs. We use MLA title case, in which case this should be _Purge Unused Data from This File_, according to https://titlecaseconverter.com/.
Author
Member

@JulianEisel My mistake, thanks. Will change!

@JulianEisel My mistake, thanks. Will change!
Hans Goudey approved these changes 2024-04-15 15:44:13 +02:00
Dismissed
Hans Goudey approved these changes 2024-04-15 16:02:22 +02:00
Damien Picard added 1 commit 2024-04-15 19:43:12 +02:00
Hans Goudey merged commit abc0bf814f into main 2024-04-15 20:02:49 +02:00
Damien Picard deleted branch dp_fix_messages 2024-04-15 20:38:44 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120649
No description provided.