Fix #120617: GPencil: Respect draw plane when stroke placement is 'STROKE' #120651

Open
YimingWu wants to merge 3 commits from ChengduLittleA/blender:fix-120617 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

When drawing in GPencil and stroke placement is set as 'STROKE', it will
not honor the selection of "Draw Plane". This fix ensures that the
drawing plane is still respected.

When drawing in GPencil and stroke placement is set as 'STROKE', it will not honor the selection of "Draw Plane". This fix ensures that the drawing plane is still respected.
YimingWu added the
Module
Grease Pencil
label 2024-04-15 04:18:24 +02:00
YimingWu added 1 commit 2024-04-15 04:18:34 +02:00
When drawing in GPencil and stroke placement is set as 'STROKE', it will
not honor the selection of "Draw Plane". This fix ensures that the UI
reflects the same logic.
Author
Member

In hindsight it might be better if we actually honour the draw plane direction but place the draw plane on the stroke start point? 🤔

In hindsight it might be better if we actually honour the draw plane direction but place the draw plane on the stroke start point? 🤔
YimingWu requested review from Falk David 2024-04-15 04:20:15 +02:00
Member

I think the fix would be to make it use the draw plane setting in STROKE mode, yes. This shouldn't be too difficult. I'm actually surprised this doesn't work in GPv3.

I think the fix would be to make it use the draw plane setting in `STROKE` mode, yes. This shouldn't be too difficult. I'm actually surprised this doesn't work in GPv3.
Author
Member

I'll try doing that :D

I'll try doing that :D
YimingWu added 2 commits 2024-04-23 09:25:45 +02:00
YimingWu changed title from Fix #120617: GPencil: Deactive draw plane when stroke placement is 'STROKE' to Fix #120617: GPencil: Respect draw plane when stroke placement is 'STROKE' 2024-04-23 09:26:10 +02:00
Author
Member

I'm not sure if this is completely working as expected, needs more testing

I'm not sure if this is completely working as expected, needs more testing
YimingWu requested review from Matias Mendiola 2024-04-23 09:28:37 +02:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-120617:ChengduLittleA-fix-120617
git checkout ChengduLittleA-fix-120617
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120651
No description provided.