Modifiers: Affect all selected objects when holding alt #120695

Hans Goudey · 2024-04-16T14:00:09+02:00

Hans Goudey commented

2024-04-16 14:00:09 +02:00

Support holding alt while invoking, add, apply, and remove
modifier operators in the property editor to affect all selected
editable objects instead of just the active object.

Though the alt key is not that visible, it's consistent with the
existing multi-object property editing shortcut. If/when multi-
object editing is every made the default, the alt key could
be reversed here too.

Changes as part of #120230.

Support holding alt while invoking, add, apply, and remove modifier operators in the property editor to affect all selected editable objects instead of just the active object. Though the alt key is not that visible, it's consistent with the existing multi-object property editing shortcut. If/when multi- object editing is every made the default, the alt key could be reversed here too. Changes as part of #120230.

👍 5 ❤️ 13 🎉 5 🚀 4

Hans Goudey added 1 commit 2024-04-16 14:00:17 +02:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

4dc6ebe212 Modifiers: Affect all selected objects when holding alt

Hans Goudey commented

2024-04-16 14:50:28 +02:00

@blender-bot build

Hans Goudey requested review from Pablo Vazquez 2024-04-16 14:50:38 +02:00

Pablo Vazquez commented

2024-04-16 17:03:06 +02:00

Add, Apply, and Remove seem to work well!

It just feels a bit arbitrary that only those options work. Any technical limitation that's stopping us from adding support for the few remaining options? Especially Move First/Last can be super useful.

Add, Apply, and Remove seem to work well! It just feels a bit arbitrary that only those options work. Any technical limitation that's stopping us from adding support for the few remaining options? Especially `Move First/Last` can be super useful. ![modifier options that work on multiple objects](/attachments/caed8eba-1337-4d1f-842c-a04f39cf0de0)

image.png

91 KiB

❤️ 2

Hans Goudey commented

2024-04-16 17:23:54 +02:00

No, nothing technical. "Move to Nodes" is a bit annoying since it's implemented in Python, but I think you're right that it's worth doing.

Pablo Vazquez commented

2024-04-16 17:36:59 +02:00

I think you're right that it's worth doing.

It'd be great if it can be as part of this. At some point we'd have to add support for it anyway.

Since a few Blender versions ago we can use Alt when editing text fields too. Doesn't get more complete than this :D

> I think you're right that it's worth doing. It'd be great if it can be as part of this. At some point we'd have to add support for it anyway. Since a few Blender versions ago we can use `Alt` when editing text fields too. Doesn't get more complete than this :D <video src="/attachments/5ee21f79-8110-4f12-a3b8-7c67cf8bd576" title="rename_multiple_modifiers.mov" controls></video>

rename_multiple_modifiers.mov

749 KiB

❤️ 3

Hans Goudey added 5 commits 2024-04-16 18:02:23 +02:00

48c572870e Merge branch 'main' into modifier-multi-object-alt

f78217d6e6 Support move to index operator

4cebb740f3 Support copy operator

0ed98b04f4 Avoid "Use" in boolean property name

6b1509e85c Support move to nodes operator

slwk1d commented

2024-04-17 10:36:32 +02:00

First-time contributor

Love to see this getting implemented!

I have some questions regarding the implementation: I assume this works when you have the same kind of modifier on multiple objects, so if for example you have a subdivision modifier on one and a displace modifier on another, holding alt and deleting won't delete both. If that's the case, how does it work when you have the same modifier multiple times on the same object? For example: I select 2 objects, one has a displace and a subsidivision modifer, the other has 2 displace modifiers. If I hold alt and delete the displace modifier on the first, will the 2 displace modifiers on the other one both get deleted? If not, how does it chooses which one?
This could take advantage of the concept of active modifier: currently we can select one modifier to make it active, but maybe this can be expanded to select multiple modifiers, I made this proposal some time ago: https://blender.community/c/rightclickselect/k2jK/

I ask this also because I, but I think many other people, are seeing this implementation as the ground work for then be able to edit the parameters of modifiers on multiple objects, which again I think relies on how this implementation is handled. Thanks!

Love to see this getting implemented! I have some questions regarding the implementation: I assume this works when you have the same kind of modifier on multiple objects, so if for example you have a subdivision modifier on one and a displace modifier on another, holding alt and deleting won't delete both. If that's the case, how does it work when you have the same modifier multiple times on the same object? For example: I select 2 objects, one has a displace and a subsidivision modifer, the other has 2 displace modifiers. If I hold alt and delete the displace modifier on the first, will the 2 displace modifiers on the other one both get deleted? If not, how does it chooses which one? This could take advantage of the concept of active modifier: currently we can select one modifier to make it active, but maybe this can be expanded to select multiple modifiers, I made this proposal some time ago: https://blender.community/c/rightclickselect/k2jK/ I ask this also because I, but I think many other people, are seeing this implementation as the ground work for then be able to edit the parameters of modifiers on multiple objects, which again I think relies on how this implementation is handled. Thanks!

Hans Goudey commented

2024-04-17 14:11:44 +02:00

Hi, this is all name-based, just like the existing multi-object editing with modifier values. I'm not sure editing the active modifier on each object sounds more convenient.

👍 6

Pablo Vazquez commented

2024-04-18 12:04:33 +02:00

It works great! It's quite fun to use and opens up new ways of working.

One last thing that I noticed, is that sometimes I want to use Move to First/Last on other objects but they are grayed out because the active object only has 1 modifier.

But I know that other objects have multiple modifiers, so I still want to use those functions.

How about: in a similar way that Copy to Selected is only available when there are multiple objects selected, the Move to First/Last operators should also be always available if there are multiple objects selected.

Yes, in some cases moving first/last won't do anything, but that's fine. It's like applying Shade Smooth on objects already smooth, it's better to be able to do it sometimes than not at all.

I think it fits this patch since it's related to multi object editing.

It works great! It's quite fun to use and opens up new ways of working. One last thing that I noticed, is that sometimes I want to use `Move to First/Last` on other objects but they are grayed out because the active object only has 1 modifier. ![single modifier](/attachments/7024018d-0b84-4867-aafb-0f4e058c63ef) But I know that other objects _have_ multiple modifiers, so I still want to use those functions. How about: in a similar way that `Copy to Selected` is only available when there are multiple objects selected, the `Move to First/Last` operators should also be always available if there are multiple objects selected. Yes, in some cases moving first/last won't do anything, but that's fine. It's like applying Shade Smooth on objects already smooth, it's better to be able to do it sometimes than not at all. I think it fits this patch since it's related to multi object editing.

image.png

35 KiB

Hans Goudey added 2 commits 2024-04-18 15:03:47 +02:00

7710fb357e Merge branch 'main' into modifier-multi-object-alt

0099e88604 Remove disabling of "Move to First" and "Move to Last"

Hans Goudey commented

2024-04-18 15:04:42 +02:00

Thanks, good point! It was much simpler to just remove the code that disabled the operators. What do you think about that? It seems fine to me, the end result for users should be basically the same anyway.

👍 1

Pablo Vazquez commented

2024-04-18 16:31:59 +02:00

What do you think about that?

I think it's fine. It's pretty obvious at a glance when the modifier we're working on is either first or last, and these operators are not usually accessed in other ways.

> What do you think about that? I think it's fine. It's pretty obvious at a glance when the modifier we're working on is either first or last, and these operators are not usually accessed in other ways.

Pablo Vazquez approved these changes 2024-04-18 16:32:16 +02:00

Hans Goudey merged commit 9a7f4a3b58 into main

2024-04-18 17:41:04 +02:00

Hans Goudey referenced this issue from a commit

2024-04-18 17:41:05 +02:00

Modifiers: Affect all selected objects when holding alt

Hans Goudey deleted branch modifier-multi-object-alt

2024-04-18 17:41:07 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Modifiers: Affect all selected objects when holding alt #120695