Fix #120731: sculpt trim tool crash #120733
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#120733
Loading…
Reference in New Issue
No description provided.
Delete Branch "PratikPB2123/blender:120731-trim-tool-crash"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Caused by
f7d5ec8661
initialize_cursor_info
requiresgesture_data.operation
initialized.So move allocation outside of
init_operation
I can not find @Sean-Kim in reviewers list so tagging in comments ;)
Ugh, sorry. Don't know how I missed this crash before submitting the PR. Appreciate you taking a stab at the fix.
Made a note of what I noticed, but it's late at night here and I won't be able to check replies until tomorrow.
@ -727,3 +727,3 @@
initialize_cursor_info(*C, *op, *gesture_data);
init_operation(*gesture_data, *op);
initialize_cursor_info(*C, *op, *gesture_data);
The order of
initialze_cursor_info
and theninit_operation
is actually still needed. This fix would just introduce other errors on the following line:For now, this is probably best fixed by adding something like
gesture_data->operation = reinterpret_cast<gesture::Operation *>(MEM_cnew<TrimOperation>(__func__));
above
initialize_cursor_info
Hi, this will cause the memory leak. I would instead call
initialize_cursor_info
insideinit_operation
after operation is initialized.This allocation is already occurring in the existing code inside
init_operation
and is cleaned up when theunique_ptr
goes out of scope by theGestureData
destructor, but I agree that movinginitialize_cursor_info
intoinit_operation
is also a fine way of solving this.Pointer was created in _exec function, it'll be freed once we exit the _exec function. So the earlier allocated memory in
initialize_cursor_info
is not freed.BTW, I ended up moving allocation outside of init_operation 👀