Fix #114000: EEVEE-Next: Fade/Facing overlays #120976

Jeroen Bakker · 2024-04-23T13:50:47+02:00

Jeroen Bakker commented

2024-04-23 13:50:47 +02:00

The fade and facing overlays use a depth equal test. EEVEE next uses
multiple samples to construct the depth and the depth can be different
than the death-center pixel depth.

This PR uses depth-less tests, but in case of the facing overlays it
can produce some artifacts at sharp edges where the normals bleeds.

Other solution would be to render the depth center depth buffer when
one of these overlays are turned on, but that adds overhead as that
will most likely be redrawn for each draw loop.

The fade and facing overlays use a depth equal test. EEVEE next uses multiple samples to construct the depth and the depth can be different than the death-center pixel depth. This PR uses depth-less tests, but in case of the facing overlays it can produce some artifacts at sharp edges where the normals bleeds. Other solution would be to render the depth center depth buffer when one of these overlays are turned on, but that adds overhead as that will most likely be redrawn for each draw loop.

Jeroen Bakker added this to the 4.2 LTS milestone 2024-04-23 13:50:47 +02:00

Jeroen Bakker added the

Module

EEVEE & Viewport

label 2024-04-23 13:50:47 +02:00

Jeroen Bakker self-assigned this 2024-04-23 13:50:47 +02:00

Jeroen Bakker added 1 commit 2024-04-23 13:50:52 +02:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

9cc6d0122f Fix #114000 : EEVEE-Next: Fade/Facing overlays

The fade and facing overlays use a depth equal test. EEVEE next uses
multiple samples to construct the depth and the depth can be different
than the death-center pixel depth.

This PR uses depth-less tests, but in case of the facing overlays it
can produce some artifacts at sharp edges where the normals bleeds.

Other solution would be to render the depth center depth buffer when
one of these overlays are turned on, but that adds overhead as that
will most likely be redrawn for each draw loop.

Jeroen Bakker added this to the EEVEE & Viewport project 2024-04-23 13:50:58 +02:00

Jeroen Bakker requested review from Clément Foucault 2024-04-23 13:51:04 +02:00

Clément Foucault approved these changes 2024-04-23 14:14:13 +02:00

Clément Foucault left a comment

This is exactly how I was thinking of fixing it.

This PR uses depth-less tests, but in case of the facing overlays it
can produce some artifacts at sharp edges where the normals bleeds.

This is something we should fix on EEVEE's side as it affects all overlays, but not exactly sure how yet.

This is exactly how I was thinking of fixing it. > This PR uses depth-less tests, but in case of the facing overlays it can produce some artifacts at sharp edges where the normals bleeds. This is something we should fix on EEVEE's side as it affects all overlays, but not exactly sure how yet.

Jeroen Bakker commented

2024-04-23 14:17:33 +02:00

@blender-bot build

Jeroen Bakker merged commit ee46030a5a into main

2024-04-23 14:45:52 +02:00

Jeroen Bakker referenced this issue from a commit

2024-04-23 14:46:00 +02:00

Fix #114000: EEVEE-Next: Fade/Facing overlays

Sign in to join this conversation.

No reviewers