Fix #113925: GPv3: eval_frame needs to be updated for modifier result #121022

Lukas Tönne · 2024-04-24T14:52:09+02:00

Lukas Tönne commented

2024-04-24 14:52:09 +02:00

Grease pencil runtime data stores the "current" frame in the
eval_frame property. This is updated before modifier evaluation, but
also used after modifiers, e.g. by the spreadsheet.

If the GeometrySet that is returned by the nodes modifier is created
during the nodes evaluation (as is the case with the Delete node) then
the resulting geometry set has eval_frame == 0. To fix this the
eval_frame is now also update after modifier evaluation.

This will only set the correct eval_frame for the top level
geometry set. Other GeometrySets like instances may not have the correct
frame value. This is a more general problem with the design that is out
of scope here.

Grease pencil runtime data stores the "current" frame in the `eval_frame` property. This is updated before modifier evaluation, but also used after modifiers, e.g. by the spreadsheet. If the GeometrySet that is returned by the nodes modifier is created during the nodes evaluation (as is the case with the Delete node) then the resulting geometry set has `eval_frame == 0`. To fix this the `eval_frame` is now also update _after_ modifier evaluation. This will only set the correct `eval_frame` for the __top level__ geometry set. Other GeometrySets like instances may not have the correct frame value. This is a more general problem with the design that is out of scope here.

Lukas Tönne added 1 commit 2024-04-24 14:52:18 +02:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

17978db160 Fix #113925 : GPv3: eval_frame needs to be updated for modifier result.

Grease pencil runtime data stores the "current" frame in the
`eval_frame` property. This is updated before modifier evaluation, but
also used after modifiers, e.g. by the spreadsheet.

If the GeometrySet that is returned by the nodes modifier is created
during the nodes evaluation (as is the case with the Delete node) then
the resulting geometry set has `eval_frame == 0`. To fix this the
`eval_frame` is now also update _after_ modifier evaluation.

This will only set the correct `eval_frame` for the __top level__
geometry set. Other GeometrySets like instances may not have the correct
frame value. This is a more general problem with the design that is out
of scope here.

Lukas Tönne added this to the Grease Pencil project 2024-04-24 14:52:25 +02:00

Lukas Tönne requested review from Falk David 2024-04-24 14:52:42 +02:00

Lukas Tönne commented

2024-04-24 14:52:50 +02:00

@blender-bot build

Falk David approved these changes 2024-04-24 14:59:01 +02:00

Lukas Tönne merged commit 3fac9df65f into main

2024-04-24 15:31:42 +02:00

Lukas Tönne deleted branch fix-gp-eval-frame

2024-04-24 15:31:45 +02:00

Lukas Tönne referenced this issue from a commit

2024-04-24 15:31:47 +02:00

Fix #113925: GPv3: eval_frame needs to be updated for modifier result

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #113925: GPv3: eval_frame needs to be updated for modifier result #121022