IO: Use FileHandler in Node Editors #121051

Guillermo Venegas · 2024-04-24T22:32:06+02:00

Guillermo Venegas commented

2024-04-24 22:32:06 +02:00

Use FileHandlers to handle file drag-n-drop in Node Editors. Drop-boxes
still remain since they handle Images ID drag-n-drop.

This also allows to open/drag-n-drop multiple files at once.

Also this will allow add-ons to also support drag-n-drop for images and movies in
node editors while still providing access to Blender's native support
since File Handlers let users choose which to invoke if there's
multiple configured.

Note:
This makes to NODE_OT_add_file to do natively what
NWAddMultipleImages(NodeWrangler operator) does.

Use `FileHandlers` to handle file drag-n-drop in Node Editors. Drop-boxes still remain since they handle Images ID drag-n-drop. This also allows to open/drag-n-drop multiple files at once. Also this will allow add-ons to also support drag-n-drop for images and movies in node editors while still providing access to Blender's native support since File Handlers let users choose which to invoke if there's multiple configured. Note: This makes to `NODE_OT_add_file` to do natively what `NWAddMultipleImages`(`NodeWrangler` operator) does. <video src="https://projects.blender.org/attachments/dd4b1248-eea2-4763-9bd0-0d7b586f639f" title="2024-04-24 14-30-38.mp4" controls></video>

2024-04-24 14-30-38.mp4

2.3 MiB

2024-04-25 14-22-00.mp4

1.6 MiB

❤️ 6 🎉 9

Guillermo Venegas added 1 commit 2024-04-24 22:32:15 +02:00

57016f8864 use fh in node

Guillermo Venegas reviewed 2024-04-24 22:37:15 +02:00

source/blender/editors/space_node/node_add.cc Outdated

						
				@ -717,0 +750,4 @@

				      node->id = (ID *)image;

				    }

				    nodes.append(node);

				    position[1] -= node->height * 2;

Guillermo Venegas commented

2024-04-24 22:37:13 +02:00

At this point I can't get the real node size I believe, needs first a node draw call(?), it's ok to leave as this way?

Iliya Katushenock commented

2024-04-25 14:18:24 +02:00

I think this can be modal operator with timer (to perform animation) to looks like usual nodes spreading.

Hans Goudey commented

2024-04-25 15:45:34 +02:00

I don't think node->height has any meaningful value, it's only used for custom-sized nodes.

The modal operation with a timer like Iliya suggests could be pretty cool. But using some hardcoded value here would be fine too. It's probably around 200 or something, would require some testing though.

I don't think `node->height` has any meaningful value, it's only used for custom-sized nodes. The modal operation with a timer like Iliya suggests could be pretty cool. But using some hardcoded value here would be fine too. It's probably around 200 or something, would require some testing though.

Guillermo Venegas commented

2024-04-25 22:25:09 +02:00

Added a animation (and updated video in description), looks better

🎉 1

guishe marked this conversation as resolved

Guillermo Venegas added 1 commit 2024-04-24 22:41:34 +02:00

83d1f47346 remove duplicated call

Guillermo Venegas added 1 commit 2024-04-25 02:29:07 +02:00

f23fa8128e format

Hans Goudey requested review from Hans Goudey 2024-04-25 03:13:49 +02:00

Guillermo Venegas added 1 commit 2024-04-25 14:08:44 +02:00

6b48820808 scripts format