Refactor: move keyingset enums to animrig #121132

Christoph Lendenfeld · 2024-04-26T15:51:49+02:00

2024-04-26 15:51:49 +02:00

No functional changes expected.

This PR moves the enums
eModifyKey_Modes and eModifyKey_Returns to animrig
as enum classes.

Functions that take or return that value were also modified.

No functional changes expected. This PR moves the enums `eModifyKey_Modes` and `eModifyKey_Returns` to animrig as enum classes. Functions that take or return that value were also modified.

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2024-04-26 15:51:49 +02:00

Christoph Lendenfeld added 1 commit 2024-04-26 15:52:00 +02:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

563db41da7 move enum to animrig

Christoph Lendenfeld commented

2024-04-26 15:56:31 +02:00

@blender-bot build

Sybren A. Stüvel commented

2024-04-30 12:09:22 +02:00

Although I do think it's good to move things into the animrig module, I don't see the particular upside to this move. If some #include "ED_keyframing.hh" were removed, then it would be different, but as it is now, it just adds yet another header to include. Or am I missing something?

Although I do think it's good to move things into the `animrig` module, I don't see the particular upside to this move. If some `#include "ED_keyframing.hh"` were removed, then it would be different, but as it is now, it just adds yet another header to include. Or am I missing something?

Christoph Lendenfeld commented

2024-04-30 12:42:26 +02:00

@dr.sybren By moving the keying set code to animrig, we can remove the editor include from the auto-keying code.
I am just trying to go there with small steps disentangling/modernising the keying set code as I go.
Though I see how that wasn't clear at all from the PR description. I will make an overarching TODO to track the progress and have the goal stated centrally.

@dr.sybren By moving the keying set code to animrig, we can remove the editor include from the auto-keying code. I am just trying to go there with small steps disentangling/modernising the keying set code as I go. Though I see how that wasn't clear at all from the PR description. I will make an overarching TODO to track the progress and have the goal stated centrally.

Sybren A. Stüvel approved these changes 2024-05-02 11:39:11 +02:00

Sybren A. Stüvel left a comment

That's the info I was missing, indeed -- the current PR doesn't remove any #include yet, so I was a bit 'hmmmmmmm'.

In any case, good move forward, let's keep moving!

That's the info I was missing, indeed -- the current PR doesn't remove any `#include` yet, so I was a bit 'hmmmmmmm'. In any case, good move forward, let's keep moving!

Christoph Lendenfeld merged commit 5b7a0ed1b5 into main

2024-05-02 12:00:50 +02:00

Christoph Lendenfeld referenced this issue from a commit

2024-05-02 12:00:52 +02:00

Refactor: move keyingset enums to animrig

Christoph Lendenfeld deleted branch refactor_move_keyingset_enums

2024-05-02 12:00:53 +02:00

Christoph Lendenfeld referenced this pull request

2024-05-02 12:43:14 +02:00

Move Keying Set code to animrig #121336

Sign in to join this conversation.

No reviewers