Refactoring: Nodes: Convention way to change type of reroute node #121146

Iliya Katushenock · 2024-04-26T21:00:51+02:00

Iliya Katushenock commented

2024-04-26 21:00:51 +02:00

Direct changing of built-in node socket type is UB. Even for reroute.
API to do this was disabled in 4a4916db45.
Correct way to perform change of socket type of built-in node is to
change node properties.

This is not really the issue for the most of the nodes except of reroute.
But while all this years, reroute node have no properties. And there is no
way to add custom reroute node for add-on's. So, only way to fix the issue
is to lets to users to change reroute socket type is to add and expose api.
Or just to hide reroute type propagation as internal thing.

This change simply add and expose type property of socket, refactor node to
use dynamic declaration system and add storage structure to the node.

Additional note, in order to support custom socket types in this built-in
node, this is necessary to use char idname[64] field instead of usual
eNodeSocketDatatype info in bNode::custom1.

There is no change of how reroute nodes are updated by node tree, so now
we just call update of each node on the bNodeTreeType::update call. But
this can be improved in future, especially by moving reroute nodes update
in main node tree update class.

This is also fix for #121110.

Direct changing of built-in node socket type is UB. Even for reroute. API to do this was disabled in 4a4916db459cfe9edb7a67a1d8183e56fd115b47. Correct way to perform change of socket type of built-in node is to change node properties. This is not really the issue for the most of the nodes except of reroute. But while all this years, reroute node have no properties. And there is no way to add custom reroute node for add-on's. So, only way to fix the issue is to lets to users to change reroute socket type is to add and expose api. Or just to hide reroute type propagation as internal thing. This change simply add and expose type property of socket, refactor node to use dynamic declaration system and add storage structure to the node. Additional note, in order to support custom socket types in this built-in node, this is necessary to use `char idname[64]` field instead of usual `eNodeSocketDatatype` info in `bNode::custom1`. There is no change of how reroute nodes are updated by node tree, so now we just call update of each node on the `bNodeTreeType::update` call. But this can be improved in future, especially by moving reroute nodes update in main node tree update class. This is also fix for #121110.

old reroutes test.blend

904 KiB

Iliya Katushenock added 1 commit 2024-04-26 21:01:02 +02:00

4dc8f4d5ee init

Iliya Katushenock added this to the Nodes & Physics project 2024-04-26 21:01:07 +02:00

Iliya Katushenock requested review from Jacques Lucke 2024-05-06 16:34:03 +02:00

Iliya Katushenock requested review from Hans Goudey 2024-05-06 16:34:04 +02:00

Jacques Lucke reviewed 2024-05-06 16:43:01 +02:00

source/blender/makesdna/DNA_node_types.h

						
				@ -1005,1 +1005,4 @@

				typedef struct NodeReroute {

				  /* Idname of sockets type is used just to support custom socket types. */

				  char type_idname[64];

Jacques Lucke commented

2024-05-06 16:43:01 +02:00

Let's use char *. Takes up less space.

Let's use `char *`. Takes up less space.

Iliya Katushenock commented

2024-05-06 16:46:49 +02:00

I do not see the reason to make this structure smaller. This string will not be larger and a lot of distributed allocations is not something i'd like to do without reason\

This pull request has changes conflicting with the target branch.

source/blender/blenloader/intern/versioning_400.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u fix_121110:mod_moder-fix_121110

git checkout mod_moder-fix_121110

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Refactoring: Nodes: Convention way to change type of reroute node #121146

Checkout