Geometry Nodes: Nodes to expose matrix components #121283

Merged

Jacques Lucke merged 12 commits from mod_moder/blender:matrix_inputs into main

2024-05-01 21:31:20 +02:00

Iliya Katushenock commented

2024-04-30 21:24:44 +02:00

Member

These nodes allow working with the raw values that make up a matrix. This can be used to construct a 4x4 matrix directly, without using the Combine Transform node. This allows building transforms with arbitrary skew, or projection matrices.

These nodes allow working with the raw values that make up a matrix. This can be used to construct a 4x4 matrix directly, without using the `Combine Transform` node. This allows building transforms with arbitrary skew, or projection matrices. ![image](/attachments/d5bef4e7-3a8c-4dc2-8b15-9afbbc5d5d21)

78 KiB

👍 5 👀 3 🎉 3 🚀 3

Iliya Katushenock added the

label 2024-04-30 21:24:44 +02:00

Iliya Katushenock added 3 commits 2024-04-30 21:24:55 +02:00

56ffcab971 init

3cc3b91129 ormat

8946c96949 cleanup

Iliya Katushenock added this to the Nodes & Physics project 2024-04-30 21:24:59 +02:00

Iliya Katushenock added 1 commit 2024-04-30 21:34:34 +02:00

a266bf82ec Cleanup

Iliya Katushenock added 2 commits 2024-04-30 21:53:20 +02:00

68b8252b95 progress

3befeb04f5 Merge branch 'matrix_inputs' of projects.blender.org:mod_moder/blender into matrix_inputs

Iliya Katushenock added 4 commits 2024-05-01 11:35:28 +02:00

ab4d17f77a Merge branch 'main' into matrix_inputs

ab17a9c950 delete matrix input node

e3bbe56426 renaming

198b3dd34e renaming to digits

Iliya Katushenock requested review from Jacques Lucke 2024-05-01 11:35:53 +02:00

Iliya Katushenock added 1 commit 2024-05-01 12:02:14 +02:00

1c04981626 missed names

Jacques Lucke requested changes 2024-05-01 14:01:08 +02:00

Dismissed

Jacques Lucke left a comment

Member

I have a feeling that these nodes can be implemented more efficiently without having to iterate over all values 16 times, but that can be optimized separately. It's nice to have a simpler implementation now.

The other main new thing is that the outputs come after the inputs. Will gather some feedback about that.

I have a feeling that these nodes can be implemented more efficiently without having to iterate over all values 16 times, but that can be optimized separately. It's nice to have a simpler implementation now. The other main new thing is that the outputs come after the inputs. Will gather some feedback about that.

source/blender/nodes/NOD_static_types.h Outdated

						
				@ -268,6 +268,7 @@ DefNode(FunctionNode, FN_NODE_ALIGN_ROTATION_TO_VECTOR, 0, "ALIGN_ROTATION_TO_VE

				DefNode(FunctionNode, FN_NODE_AXIS_ANGLE_TO_ROTATION, 0, "AXIS_ANGLE_TO_ROTATION", AxisAngleToRotation, "Axis Angle to Rotation", "")

				DefNode(FunctionNode, FN_NODE_BOOLEAN_MATH, 0, "BOOLEAN_MATH", BooleanMath, "Boolean Math", "")

				DefNode(FunctionNode, FN_NODE_COMBINE_COLOR, 0, "COMBINE_COLOR", CombineColor, "Combine Color", "")

				DefNode(FunctionNode, FN_NODE_COMBINE_MATRIX, 0, "COMBINE_MATRIX", CombineMatrix, "Combine Matrix", "")

Jacques Lucke commented

2024-05-01 13:58:06 +02:00

Member

Description: Construct a 4x4 matrix from its individual values

Description: `Construct a 4x4 matrix from its individual values`

mod_moder marked this conversation as resolved

source/blender/nodes/NOD_static_types.h Outdated

						
				@ -291,6 +292,7 @@ DefNode(FunctionNode, FN_NODE_ROTATE_VECTOR, 0, "ROTATE_VECTOR", RotateVector, "

				DefNode(FunctionNode, FN_NODE_ROTATION_TO_AXIS_ANGLE, 0, "ROTATION_TO_AXIS_ANGLE", RotationToAxisAngle, "Rotation to Axis Angle", "")

				DefNode(FunctionNode, FN_NODE_ROTATION_TO_EULER, 0, "ROTATION_TO_EULER", RotationToEuler, "Rotation to Euler", "")

				DefNode(FunctionNode, FN_NODE_SEPARATE_COLOR, 0, "SEPARATE_COLOR", SeparateColor, "Separate Color", "")

				DefNode(FunctionNode, FN_NODE_SEPARATE_MATRIX, 0, "SEPARATE_MATRIX", SeparateMatrix, "Separate Matrix", "")

Jacques Lucke commented

2024-05-01 13:58:34 +02:00

Member

Description: Split a 4x4 matrix into its individual values

Description: `Split a 4x4 matrix into its individual values`

mod_moder marked this conversation as resolved

source/blender/nodes/function/nodes/node_fn_combine_matrix.cc Outdated

						
				@ -0,0 +40,4 @@

				  column_d.add_input<decl::Float>("Column 4 Row 4").default_value(1.0f);

				}

				static void step_copy(const IndexMask &mask,

Jacques Lucke commented

2024-05-01 13:55:38 +02:00

Member

Maybe copy_with_stride is a better name here. Same in the other node.

Maybe `copy_with_stride` is a better name here. Same in the other node.

mod_moder marked this conversation as resolved

Iliya Katushenock requested review from Jacques Lucke 2024-05-01 15:59:18 +02:00

Iliya Katushenock added 1 commit 2024-05-01 15:59:23 +02:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

9c01f9c05a progress

Simon Thommes commented

2024-05-01 16:18:59 +02:00

Member

Just chatted with @JacquesLucke about this. My initial reaction to seeing the screenshots is that there has to be a less bloated solution in terms of UI, but after some more consideration I don't really think there is much to say against the utility and consistency this brings.

I do think that ideally we wouldn't present this as the only way to access this data though, so I'd like to propose adding get(/set ?) nodes for specific matrix elements by indices so they can be in the same release.

Such would be at least a Matrix Element node with Matrix, Row, Column inputs and the value field of that element as output.
There could be one to Replace Matrix Element as well and in some way this also relates to future list functionality, so maybe this still needs a desing task to figure things out.

Just chatted with @JacquesLucke about this. My initial reaction to seeing the screenshots is that there has to be a less bloated solution in terms of UI, but after some more consideration I don't really think there is much to say against the utility and consistency this brings. I do think that ideally we wouldn't present this as the only way to access this data though, so I'd like to propose adding get(/set ?) nodes for specific matrix elements by indices so they can be in the same release. Such would be at least a `Matrix Element` node with `Matrix`, `Row`, `Column` inputs and the value field of that element as output. There could be one to `Replace Matrix Element` as well and in some way this also relates to future list functionality, so maybe this still needs a desing task to figure things out.

Iliya Katushenock commented

2024-05-01 16:28:42 +02:00

Author

Member

Not sure this is actually good idea to use index to access data of attribute component.
We do not do this for vector and color.

Not sure this is actually good idea to use index to access data of attribute component. We do not do this for vector and color.

Jacques Lucke commented

2024-05-01 21:08:28 +02:00

Member

@blender-bot build

@blender-bot build

Jacques Lucke approved these changes 2024-05-01 21:14:15 +02:00

Jacques Lucke left a comment

Member

Thanks for working on this node.
Can you make a separate patch for a Matrix Element node like the one Simon described? I have to think about use-cases for it a bit more, but would be nice to have a patch already.

Thanks for working on this node. Can you make a separate patch for a Matrix Element node like the one Simon described? I have to think about use-cases for it a bit more, but would be nice to have a patch already.

Iliya Katushenock commented

2024-05-01 21:21:26 +02:00

Author

Member

This is pretty trivial node group with Index Switch node.

This is pretty trivial node group with Index Switch node.

Jacques Lucke referenced this issue from a commit

2024-05-01 21:31:20 +02:00

Geometry Nodes: support working with raw matrix values

Jacques Lucke merged commit 831e91c357 into main

2024-05-01 21:31:20 +02:00

Iliya Katushenock deleted branch matrix_inputs

2024-05-01 21:35:54 +02:00

Iliya Katushenock commented

2024-05-03 13:12:29 +02:00

Author

Member

I have tried to check some different ways to combine component of matrix: https://projects.blender.org/mod_moder/blender/src/branch/tmp_optimiza_combine_matrix_node
In result, current approach the most faster.

I have tried to check some different ways to combine component of matrix: https://projects.blender.org/mod_moder/blender/src/branch/tmp_optimiza_combine_matrix_node In result, current approach the most faster.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121283

No description provided.