EEVEE-Next: Fixing shifted blur for non constant Shutter Curve #121320

Vitalijs Komasilovs · 2024-05-01T21:55:04+02:00

2024-05-01 21:55:04 +02:00

For non-constant Shutter Curve inverted cumulative distribution function had -inf values, which resulted in missing one side of the motion blur.

Fixes #117755

Actual root cause is as follows:

BKE_curvemapping_evaluateF produces 0 for the last element due to clipping.
cdf_from_curvemapping results in cdf with 1.0f as last two elements.
cdf_invert fails to interpolate between two equal elements.

Fix eliminates potential division by zero in cdf_invert.
Another option is to fix cdf_from_curvemapping and introduce some arbitrary rule for equal subsequent values in CDF (e.g. add epsilon).

For non-constant Shutter Curve inverted cumulative distribution function had -inf values, which resulted in missing one side of the motion blur. Fixes #117755 Actual root cause is as follows: - `BKE_curvemapping_evaluateF` produces `0` for the last element due to clipping. - `cdf_from_curvemapping` results in `cdf` with 1.0f as last two elements. - `cdf_invert` fails to interpolate between two equal elements. Fix eliminates potential division by zero in `cdf_invert`. Another option is to fix `cdf_from_curvemapping` and introduce some arbitrary rule for equal subsequent values in CDF (e.g. add epsilon).

Vitalijs Komasilovs added 1 commit 2024-05-01 21:55:13 +02:00

7f2e2167fd EEVEE-Next: Fixing -inf values in inverted CDF

Iliya Katushenock added this to the EEVEE & Viewport project 2024-05-01 21:57:33 +02:00

Vitalijs Komasilovs changed title from ~~EEVEE-Next: Fixing shifted blur for non constant Shutter Curve~~ to WIP: EEVEE-Next: Fixing shifted blur for non constant Shutter Curve

2024-05-02 13:36:27 +02:00

Vitalijs Komasilovs changed title from ~~WIP: EEVEE-Next: Fixing shifted blur for non constant Shutter Curve~~ to EEVEE-Next: Fixing shifted blur for non constant Shutter Curve

2024-05-02 13:36:44 +02:00

Clément Foucault requested review from Clément Foucault 2024-05-02 13:57:43 +02:00

Clément Foucault commented

2024-05-09 19:21:13 +02:00

Thanks for finding the cause of the issue! The fix was a bit more involved as the code that was doing the interpolation was wrong. See 6efb69a5fe

Thanks for finding the cause of the issue! The fix was a bit more involved as the code that was doing the interpolation was wrong. See 6efb69a5fea75001ff209d1cdfdccab654846465

Clément Foucault closed this pull request

2024-05-09 19:21:19 +02:00

Vitalijs Komasilovs deleted branch eevee-next-fix-shutter-curve

2024-05-10 09:51:56 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

EEVEE-Next: Fixing shifted blur for non constant Shutter Curve #121320

Pull request closed