Object: add Shade Auto Smooth operator #121494

Jacques Lucke · 2024-05-06T18:53:38+02:00

Jacques Lucke commented

2024-05-06 18:53:38 +02:00

Based on the design in #120230.

Replaces the Shade Smooth by Angle with Shade Auto Smooth in the menu.
The new operator automatically adds and removes the modifier instead of being a destructive operation.
The Shade Smooth and Shade Flat operators now remove the Smooth by Angle modifier automatically.
Add a pin option to modifiers, which limits dragging and keeps the modifier after newly added modifiers in the list.

Based on the design in #120230. * Replaces the `Shade Smooth by Angle` with `Shade Auto Smooth` in the menu. * The new operator automatically adds and removes the modifier instead of being a destructive operation. * The `Shade Smooth` and `Shade Flat` operators now remove the `Smooth by Angle` modifier automatically. * Add a pin option to modifiers, which limits dragging and keeps the modifier after newly added modifiers in the list. ![image](/attachments/24bc7f30-b9b2-45be-a53b-8f0e4a4bb99f)

2024-05-06 19-01-23.mp4

755 KiB

image.png

34 KiB

👍 6 ❤️ 3 🎉 3 🚀 2

Jacques Lucke added 3 commits 2024-05-06 18:53:47 +02:00

1d94a012d3 rename operator

76b8cb0a23 Revert "rename operator"

This reverts commit 1d94a012d3.

1d5bcdfeec initial shade auto smooth operator

Jacques Lucke added 1 commit 2024-05-06 19:00:35 +02:00

c4251bfe56 shade mesh smooth as part of operator

Jacques Lucke requested review from Dalai Felinto 2024-05-06 19:02:57 +02:00

Jacques Lucke requested review from Hans Goudey 2024-05-06 19:02:58 +02:00

Jacques Lucke referenced this pull request

2024-05-06 19:05:07 +02:00

Smooth by Angle Usability Improvements #120230

Jacques Lucke added 2 commits 2024-05-06 20:10:17 +02:00

6162a9fd8f Merge branch 'main' into shade-auto-smooth

769248d7b1 remove shade smooth by angle operator from menu

Jacques Lucke changed title from ~~WIP: Object: add Shade Auto Smooth operator~~ to Object: add Shade Auto Smooth operator

2024-05-06 20:12:00 +02:00

Hans Goudey approved these changes 2024-05-07 00:05:41 +02:00

Hans Goudey left a comment

Thanks. This works well. We'll be in an intermediate state until the "Shade Smooth" and "Shade Flat" operators remove the modifier too. But that can be done separately using parts of this code.

source/blender/editors/object/object_edit.cc

						
				@ -1713,0 +1772,4 @@

				    bNodeTree *node_group = reinterpret_cast<bNodeTree *>(node_group_id);

				    node_group->ensure_topology_cache();

				    const StringRefNull angle_identifier = node_group->interface_inputs()[1]->identifier;

Hans Goudey commented

2024-05-07 00:01:22 +02:00

Missing BKE_node_runtime.hh include

Missing `BKE_node_runtime.hh` include

JacquesLucke marked this conversation as resolved

Dalai Felinto commented

2024-05-07 10:44:36 +02:00

Besides the Shade Smooth/Shade Flat changes appointed by Hans we also the "stick to bottom" option is required for this to really shine. I think we should wait for this all to be tested together before we merge.

❤️ 2

Jacques Lucke added 2 commits 2024-05-07 11:22:07 +02:00

dc56bd52aa Merge branch 'main' into shade-auto-smooth

5d770f7634 add missing include

Jacques Lucke added 2 commits 2024-05-07 12:19:00 +02:00

52fd25dc7f Merge branch 'main' into shade-auto-smooth

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

5693565ecb remove modifier in Shade Smooth/Flat operator

Dalai Felinto commented

2024-05-07 12:28:00 +02:00

@blender-bot package

Blender Bot commented

2024-05-07 12:28:04 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121494) when ready.

Dalai Felinto commented

2024-05-07 15:25:04 +02:00

I think the "Auto Smooth" option on the operation should not be saved (PROP_SKIP_SAVE).
Right now if I do:

Shade Auto Smooth
Shade Auto Smooth + on the redo panel set it to False
Shade Flat
Shade Auto Smooth

The last time this is call it does nothing. This is also how it works in 4.0.

I think the "Auto Smooth" option on the operation should not be saved (PROP_SKIP_SAVE). Right now if I do: * Shade Auto Smooth * Shade Auto Smooth + on the redo panel set it to False * Shade Flat * Shade Auto Smooth The last time this is call it does nothing. This is also how it works in 4.0.

Hans Goudey added 1 commit 2024-05-07 20:43:17 +02:00

d0e108729a Merge branch 'main' into shade-auto-smooth

Hans Goudey commented

2024-05-07 22:29:25 +02:00

I think the "Auto Smooth" option on the operation should not be saved (PROP_SKIP_SAVE).

Looked into implementing this, and actually I'm having a bunch of trouble filling the operator's value from the active modifier. Menus seem hardcoded to use exec rather than invoke, so I can't give the angle a starting value.

But anyway, in the angle was saved with the operator properties in 4.0 (PROP_SKIP_SAVE) was not used.

The last time this is call it does nothing

Not sure what you mean by this. "Shade Auto Smooth" after "Shade Flat" will do the same thing as it always does.

In conclusion, I'd leave the angle-saving as-is.

>I think the "Auto Smooth" option on the operation should not be saved (PROP_SKIP_SAVE). Looked into implementing this, and actually I'm having a bunch of trouble filling the operator's value from the active modifier. Menus seem hardcoded to use `exec` rather than `invoke`, so I can't give the angle a starting value. But anyway, in the angle was saved with the operator properties in 4.0 (PROP_SKIP_SAVE) was not used. >The last time this is call it does nothing Not sure what you mean by this. "Shade Auto Smooth" after "Shade Flat" will do the same thing as it always does. In conclusion, I'd leave the angle-saving as-is.

Jacques Lucke commented

2024-05-07 22:55:37 +02:00

I don't think you need to initialize the angle value from the modifier to justify adding PROP_SKIP_SAVE to the "Auto Smooth" option.

I don't think you need to initialize the angle value from the modifier to justify adding `PROP_SKIP_SAVE` to the "Auto Smooth" option.

Hans Goudey commented

2024-05-07 23:01:57 +02:00

Agh, sorry, I was talking about the angle, everyone else was talking about the boolean option!

Hans Goudey added 1 commit 2024-05-07 23:06:11 +02:00