UI: Mesh Bevel Status Display #121796

Merged
Harley Acheson merged 6 commits from Harley/blender:StatusBevel into main 2024-05-15 18:12:35 +02:00
Member

While using the mesh Bevel operator, show the changing values on the
area header and keymap entries on the Status Bar using the new system
that shows icons and toggles. Approximately 30% shorter display.


I have tried to make this as short and concise as possible. The following illustrates the differences, current above, PR below.

image

The following inset captures are taken at 2.0x Resolution scale

This PR moves the changing values, Offset amount, Segment count, and profile amount to the area header:

image

Note this does change the text for the offset value as you change "Width Type", here showing percent:

image

On the status bar, the value mode (whether you are dragging the Width / Segments / Profile), highlight the selected mode:

image

Toggles are grouped together and highlighted when enabled:

image

Settings with with multiple modes are placed at the end to minimize jiggling as they change:

image

While using the mesh Bevel operator, show the changing values on the area header and keymap entries on the Status Bar using the new system that shows icons and toggles. Approximately 30% shorter display. --- I have tried to make this as short and concise as possible. The following illustrates the differences, current above, PR below. ![image](/attachments/49af254e-3ad4-4e0b-b7a4-f0c58f046613) The following inset captures are taken at 2.0x Resolution scale This PR moves the changing values, Offset amount, Segment count, and profile amount to the area header: ![image](/attachments/65e7c71a-ef7f-4c64-a5a2-0828c2219b4b) Note this does change the text for the offset value as you change "Width Type", here showing percent: ![image](/attachments/a6dd46e3-2c8d-4a51-8aa0-d897f1b49f49) On the status bar, the value mode (whether you are dragging the Width / Segments / Profile), highlight the selected mode: ![image](/attachments/a57508fe-fc9c-4dc5-849e-e65684f7cedf) Toggles are grouped together and highlighted when enabled: ![image](/attachments/03f96f21-d80e-441c-93f1-c6543d0428b5) Settings with with multiple modes are placed at the end to minimize jiggling as they change: ![image](/attachments/cd1d1bbf-d093-4d09-8101-2ce5e204f495)
Harley Acheson added 1 commit 2024-05-14 19:14:42 +02:00
While using the mesh Bevel operator, show the changing values on the
area header and keymap entries on the Status Bar using the new system
that shows icons and toggles. Approximately 30% shorter display.
Harley Acheson added this to the Module: User Interface project 2024-05-14 19:16:26 +02:00
Harley Acheson requested review from Pablo Vazquez 2024-05-14 19:16:33 +02:00
Pablo Vazquez approved these changes 2024-05-14 19:28:10 +02:00
Pablo Vazquez left a comment
Member

Super nice! Bevel was one of the worst offenders in this area.

Thanks!

Super nice! Bevel was one of the worst offenders in this area. Thanks!
Author
Member

@pablovazquez

There are some things in this that could be contentious. The movement of the offset values from the status bar to the area header, the slight change of order, the choice of what is on the header versus status bar, my choices to shorten some text like "Clamp", "Harden", "Seam", and "Sharp".

So not sure how much review this requires. Maybe have @brecht wade in to make sure we are on the right track?

@pablovazquez There are some things in this that could be contentious. The movement of the offset values from the status bar to the area header, the slight change of order, the choice of what is on the header versus status bar, my choices to shorten some text like "Clamp", "Harden", "Seam", and "Sharp". So not sure how much review this requires. Maybe have @brecht wade in to make sure we are on the right track?
Harley Acheson added 1 commit 2024-05-14 19:44:01 +02:00
Harley Acheson added 1 commit 2024-05-14 19:48:36 +02:00
Member

The movement of the offset values from the status bar to the area header
the choice of what is on the header versus status bar

This is consistent with what we discussed and what has been worked on already for other tools.

Status Bar: Shortcuts and toggle indicators.
Header: Values.

the slight change of order

This was done to prevent jittering text. Which I bet most people agree is better than the previous order with a jumpy UI.

my choices to shorten some text like "Clamp", "Harden", "Seam", and "Sharp".

These are terms users are already familiar with. I don't think they are confusing in this context.

> The movement of the offset values from the status bar to the area header > the choice of what is on the header versus status bar This is consistent with what we discussed and what has been worked on already for other tools. Status Bar: Shortcuts and toggle indicators. Header: Values. > the slight change of order This was done to prevent jittering text. Which I bet most people agree is better than the previous order with a jumpy UI. > my choices to shorten some text like "Clamp", "Harden", "Seam", and "Sharp". These are terms users are already familiar with. I don't think they are confusing in this context.
Harley Acheson added 2 commits 2024-05-15 17:12:19 +02:00
Merge branch 'main' of projects.blender.org:blender/blender into StatusBevel
All checks were successful
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
74d7451099
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson added 1 commit 2024-05-15 17:33:28 +02:00
Removing unused function variable
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
565845caaa
Author
Member

@blender-bot build

@blender-bot build
Author
Member

This is consistent with what we discussed and what has been worked on already for other tools.

True. And code change is trivial and doesn't actually change the functionality. Let's go for it.

> This is consistent with what we discussed and what has been worked on already for other tools. True. And code change is trivial and doesn't actually change the functionality. Let's go for it.
Harley Acheson merged commit 3fbc603137 into main 2024-05-15 18:12:35 +02:00
Harley Acheson deleted branch StatusBevel 2024-05-15 18:12:37 +02:00

I was just checking this, seems all fine to me.

I was just checking this, seems all fine to me.
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121796
No description provided.