UI: Toggle Camera Guides in Viewport Overlays #121923

Merged
Harley Acheson merged 5 commits from Harley/blender:OverlayCameraGuides into main 2024-05-27 18:16:14 +02:00
Member

Allow toggling camera composition guides in the 3DView Overlay popover.


@pablovazquez

In our last UI Meeting you mentioned that someone requested the ability to toggle on/off all camera composition guides (safe areas, thirds, etc) with one checkbox in the 3DView overlay popover. Here's something to test.

CameraGuides.gif

Allow toggling camera composition guides in the 3DView Overlay popover. --- @pablovazquez In our [last UI Meeting](https://devtalk.blender.org/t/2024-05-07-user-interface-meeting/34387) you mentioned that someone requested the ability to toggle on/off all camera composition guides (safe areas, thirds, etc) with one checkbox in the 3DView overlay popover. Here's something to test. ![CameraGuides.gif](/attachments/88e562ec-855d-4a32-b42c-7718941cc181)
Harley Acheson added 1 commit 2024-05-17 19:21:41 +02:00
e8fcb0285b UI: Toggle Camera Guides in Viewport Overlays
Allow toggling camera composition guides in the 3DView Overlay popover.
Harley Acheson added this to the User Interface project 2024-05-17 19:22:56 +02:00
Harley Acheson requested review from Pablo Vazquez 2024-05-17 19:23:03 +02:00
First-time contributor

Wanted this for so long and always forgot to make a request, thank you for getting ahead of me!

Wanted this for so long and always forgot to make a request, thank you for getting ahead of me!
Author
Member

Wanted this for so long and always forgot to make a request, thank you for getting ahead of me!

Note this this does not turn off/on the passepartout. We couldn't agree on that. It seems like that might make composition more difficult and that has an easy single checkmark anyway.

Comments on passepartout would be appreciated. Or on anything to do with this of course.

> Wanted this for so long and always forgot to make a request, thank you for getting ahead of me! Note this this does not turn off/on the passepartout. We couldn't agree on that. It seems like that might make composition more difficult and that has an easy single checkmark anyway. Comments on passepartout would be appreciated. Or on anything to do with this of course.
First-time contributor

Comments on passepartout would be appreciated.

Mmm, I see why it might be handy to be able to disable it as well, but at least for me the big benefit it's having the possibility to toggle camera composition guides but not other overlays. Especially since, currently, if you turn off all overlays you still have passpartout enabled.

and that has an easy single checkmark anyway.

Good point.

One thing though that always bugged me is that turning off overlays disables also the camera background image, when many times I would have loved to turn off guides (or all overlays) but still be able to see the background image.

> Comments on passepartout would be appreciated. Mmm, I see why it might be handy to be able to disable it as well, but at least for me the big benefit it's having the possibility to toggle camera composition guides but not other overlays. Especially since, currently, if you turn off all overlays you still have passpartout enabled. > and that has an easy single checkmark anyway. Good point. One thing though that always bugged me is that turning off overlays disables also the camera background image, when many times I would have loved to turn off guides (or all overlays) but still be able to see the background image.
First-time contributor

I agree with keeping passepartout outside of overlays, since it doesn't "block" the view like other overlays, which is usually why one wants to toggle them off. It's a bit of an exception in that regard.

I agree with keeping passepartout outside of overlays, since it doesn't "block" the view like other overlays, which is usually why one wants to toggle them off. It's a bit of an exception in that regard.
First-time contributor

I agree that the passp shouldn't be part of the checkbox action.

I agree that the passp shouldn't be part of the checkbox action.
Harley Acheson added 1 commit 2024-05-18 18:47:38 +02:00
Pablo Vazquez approved these changes 2024-05-21 15:11:34 +02:00
Pablo Vazquez left a comment
Member

Thanks for working on it!

Thanks for working on it!
First-time contributor

Thanks for adding the guides toggle! This will be very helpful for me in the current movie production.
The reason I also requested the passepartout toggle is because I currently often paint curves onto meshes from the camera's pov and with the passepartout I can not paint over the outer edges. It's also made very complicated for me to toggle the passepartout because of the setup we have for the production. I end up going into anim files to change it, then back to the lighting file and then by the end of the day I put the passepartout back the way the animators set it up.
I also turn the passepartout off/transparent to arrange objects in space (like clouds in the sky) while looking from the camera, a one click solution would just be really convenient for this.

Thanks for adding the guides toggle! This will be very helpful for me in the current movie production. The reason I also requested the passepartout toggle is because I currently often paint curves onto meshes from the camera's pov and with the passepartout I can not paint over the outer edges. It's also made very complicated for me to toggle the passepartout because of the setup we have for the production. I end up going into anim files to change it, then back to the lighting file and then by the end of the day I put the passepartout back the way the animators set it up. I also turn the passepartout off/transparent to arrange objects in space (like clouds in the sky) while looking from the camera, a one click solution would just be really convenient for this.
Member

I think it is worth looking into a solution for passepartout. It is a camera property that can't be changed if the camera is linked, which can happen often in production.

However, it can be its own patch. A toggle for Camera Guides I think no-one is against as it is pretty useful. Passepartout is a separate setting.

I think it is worth looking into a solution for passepartout. It is a camera property that can't be changed if the camera is linked, which can happen often in production. However, it can be its own patch. A toggle for Camera Guides I think no-one is against as it is pretty useful. Passepartout is a separate setting.
Harley Acheson added 2 commits 2024-05-22 00:15:07 +02:00
Member

Thanks for the update! For context: feedback on the latest UI module was to make this only show up while in camera view, but other than that we all agree this should go in.

Thanks for the update! For context: feedback on the latest UI module was to make this only show up while in camera view, but other than that we all agree this should go in.
Harley Acheson added 1 commit 2024-05-27 17:31:52 +02:00
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
ed9470b19c
Merge branch 'main' of projects.blender.org:blender/blender into OverlayCameraGuides
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit 392ac52ebb into main 2024-05-27 18:16:14 +02:00
Harley Acheson deleted branch OverlayCameraGuides 2024-05-27 18:16:18 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121923
No description provided.