GPv3: Refactor: Use GPv2 point times as is #122367

Falk David · 2024-05-28T12:51:41+02:00

Falk David commented

2024-05-28 12:51:41 +02:00

During the conversion of GPv3 to GPv2, we computed the
time difference between the points. So we we're keeping track
of the time a point was created relative to the previous point.

There doesn't seem to be a good reason to do this.
It can also go very wrong in case the times of two points are
very close to one another (which can result in catastrophic
cancellation).

With this change, the time delta values are now the time
a point was created, relative to the first point.

During the conversion of GPv3 to GPv2, we computed the time difference between the points. So we we're keeping track of the time a point was created relative to the previous point. There doesn't seem to be a good reason to do this. It can also go very wrong in case the times of two points are very close to one another (which can result in catastrophic cancellation). With this change, the time delta values are now the time a point was created, relative to the first point.

Falk David added 1 commit 2024-05-28 12:51:50 +02:00

GPv3: Refactor: Use GPv2 point times as is

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

e75f67a328

During the conversion of GPv3 to GPv2, we computed the
time difference between the points. So we we're keeping track
of the time a point was created after the point before it.

There doesn't seem to be a good reason to do this.
It also can go very wrong in case the times of two points are
very close to one another (which can result in catastrophic
cancellation).

Falk David added this to the Grease Pencil project 2024-05-28 12:51:56 +02:00

Falk David requested review from Lukas Tönne 2024-05-28 12:52:07 +02:00

Lukas Tönne approved these changes 2024-05-28 13:01:12 +02:00

Falk David commented

2024-05-28 17:13:36 +02:00

@blender-bot build

Falk David merged commit 94b4542afe into main

2024-05-30 14:12:36 +02:00

Falk David referenced this issue from a commit

2024-05-30 14:12:37 +02:00

GPv3: Refactor: Use GPv2 point times as is

Falk David deleted branch gpv3-refactor-use-current-delta-times