Extensions: New status message when checking for update #122378

Merged
Dalai Felinto merged 3 commits from ideasman42/blender:pr-sync-message-update into main 2024-05-28 18:39:51 +02:00
- Sync repo: {remote_url}
+ Checking repository "{remote_name}" for updates...

- Sync downloading remote data
+ Refreshing extensions list for "{remote_name}"...

- sync: invalid manifest ({error_msg}) reading {remote_url}!"
+ Repository error: invalid manifest ({error_msg}) for repository "{remote_name}"!

- Sync complete: {:s}".format(remote_url)
+ Extensions list for "{remote_name}" updated

Note, this is working as expected (from Blender anyways), however I can't test test_cli.py at the moment here.


Old messages:

New messages:


Co-authored by Pablo Vazquez

``` - Sync repo: {remote_url} + Checking repository "{remote_name}" for updates... - Sync downloading remote data + Refreshing extensions list for "{remote_name}"... - sync: invalid manifest ({error_msg}) reading {remote_url}!" + Repository error: invalid manifest ({error_msg}) for repository "{remote_name}"! - Sync complete: {:s}".format(remote_url) + Extensions list for "{remote_name}" updated ``` --- Note, this is working as expected (from Blender anyways), however I can't test test_cli.py at the moment here. --- Old messages: <img src="https://projects.blender.org/attachments/9d4db8f5-ef9a-48c8-9e56-cb534aa9aed5" width=650> New messages: <img src="https://projects.blender.org/attachments/0245bcb7-6c4e-47e4-a616-0cf831761b47" width=450> --- Co-authored by Pablo Vazquez
Dalai Felinto requested review from Campbell Barton 2024-05-28 16:13:56 +02:00
Dalai Felinto added this to the Python API project 2024-05-28 16:14:21 +02:00
Campbell Barton approved these changes 2024-05-28 16:23:04 +02:00
Campbell Barton left a comment
Owner

Accepting with minor requests.

Accepting with minor requests.
@ -1657,3 +1658,3 @@
"""
request_exit = False
request_exit |= message_status(msg_fn, "Sync repo: {:s}".format(remote_url))
request_exit |= message_status(msg_fn, f'Checking repository "{remote_name}" for updates...')

Prefer to use str.format over f-strings. Also oter strings in this PR.

Prefer to use `str.format` over f-strings. Also oter strings in this PR.
dfelinto marked this conversation as resolved
@ -3035,6 +3052,7 @@ def argparse_create_client_sync(subparsers: "argparse._SubParsersAction[argparse
func=lambda args: subcmd_client.sync(
msg_fn_from_args(args),
remote_url=args.remote_url,
remote_name=args.remote_name if args.remote_name else args.remote_url,

Less verbose (in the else case):

remote_name=args.remote_name if args.remote_name else remote_url_params_strip(args.remote_url)
Less verbose (in the else case): ``` remote_name=args.remote_name if args.remote_name else remote_url_params_strip(args.remote_url) ```
dfelinto marked this conversation as resolved
Author
Owner

Ok, merging now. Note that I had to copy remote_url_params_strip function to the unittest.

Ok, merging now. Note that I had to copy remote_url_params_strip function to the unittest.
Dalai Felinto changed title from WIP: Extensions: New status message when checking for update to Extensions: New status message when checking for update 2024-05-28 18:37:27 +02:00
Dalai Felinto force-pushed pr-sync-message-update from bc88281c07 to 6c44756377 2024-05-28 18:37:53 +02:00 Compare
Dalai Felinto force-pushed pr-sync-message-update from 6c44756377 to 656c41c490 2024-05-28 18:39:32 +02:00 Compare
Dalai Felinto merged commit 4b57951604 into main 2024-05-28 18:39:51 +02:00
Dalai Felinto deleted branch pr-sync-message-update 2024-05-28 18:39:55 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122378
No description provided.