blender/blender
165
518
Fork 791
Code Issues 6.8k Pull Requests 942 Projects 21 Wiki Activity

Fix: Add leftColor variable only to handle shader #122803

Merged
Jacques Lucke merged 1 commits from laurynas/blender:fix-curves-handle-drawing into main 2024-06-13 19:32:45 +02:00
Conversation 5 Commits 1 Files Changed 1 +5 -1
Laurynas Duburas commented 2024-06-05 21:54:43 +02:00
Contributor
Copy Link

Variable leftColor is added to global variable overlay_edit_smooth_color_iface in current version.
In result it is added to every following shader using overlay_edit_smooth_color_iface.

Variable `leftColor` is added to global variable `overlay_edit_smooth_color_iface` in current version. In result it is added to every following shader using `overlay_edit_smooth_color_iface`.
Laurynas Duburas added 1 commit 2024-06-05 21:54:54 +02:00
Laurynas Duburas requested review from Hans Goudey 2024-06-05 21:55:15 +02:00
Hans Goudey reviewed 2024-06-05 22:46:40 +02:00
Hans Goudey left a comment
Member
Copy Link

I have to say unfortunately I don't really understand the problem. Is it that finalColor is missing?

I have to say unfortunately I don't really understand the problem. Is it that `finalColor` is missing?
Laurynas Duburas commented 2024-06-05 23:11:58 +02:00
Author
Contributor
Copy Link

No. Some shaders get leftColor though they do not need it.
Try changing that line, to:

.vertex_out(overlay_edit_smooth_color_iface.smooth(Type::VEC4, "leftColor")
                    .smooth(Type::VEC4, "leftColor"))

The error duplicate member 'leftColor' will occur during overlay_edit_particle_strand compilation., though overlay_edit_particle_strand has nothing to do the leftColor.

Everything is working right now, but it is wrong doing.

No. Some shaders get `leftColor` though they do not need it. Try changing that line, to: ```c .vertex_out(overlay_edit_smooth_color_iface.smooth(Type::VEC4, "leftColor") .smooth(Type::VEC4, "leftColor")) ``` The error `duplicate member 'leftColor'` will occur during `overlay_edit_particle_strand` compilation., though `overlay_edit_particle_strand` has nothing to do the `leftColor`. Everything is working right now, but it is wrong doing.
Laurynas Duburas changed title from Fix: Add leftColor variable only to handle shader to WIP: Fix: Add leftColor variable only to handle shader 2024-06-10 21:03:53 +02:00
Jacques Lucke commented 2024-06-10 21:15:57 +02:00
Member
Copy Link

Is there a reason for why this is WIP?

Is there a reason for why this is WIP?
Hans Goudey commented 2024-06-10 21:16:16 +02:00
Member
Copy Link

Aha, I see, thanks!

Aha, I see, thanks!
Laurynas Duburas commented 2024-06-10 21:21:55 +02:00
Author
Contributor
Copy Link

It will be obsolete, if #122910 is accepted.
#122910 is almost completed, so I decided to mark this one WIP not to waste anyone's time.

It will be obsolete, if #122910 is accepted. #122910 is almost completed, so I decided to mark this one WIP not to waste anyone's time.
Laurynas Duburas commented 2024-06-12 14:36:50 +02:00
Author
Contributor
Copy Link

The #122910 will hang for a while so I'm activating this one.

More realistic problem scenario. Define variable leftColor in
overlay_edit_particle_strand_vert.glsl or any other defined bellow overlay_edit_curves_handle in overlay_edit_mode_info.hh. Draw manager will fail to init with duplicate member 'leftColor'.

The #122910 will hang for a while so I'm activating this one. More realistic problem scenario. Define variable `leftColor` in `overlay_edit_particle_strand_vert.glsl` or any other defined bellow `overlay_edit_curves_handle` in `overlay_edit_mode_info.hh`. Draw manager will fail to init with `duplicate member 'leftColor'`.
Laurynas Duburas changed title from WIP: Fix: Add leftColor variable only to handle shader to Fix: Add leftColor variable only to handle shader 2024-06-12 14:36:55 +02:00
Jacques Lucke approved these changes 2024-06-13 19:32:03 +02:00
Jacques Lucke merged commit d954e74963 into main 2024-06-13 19:32:45 +02:00
Laurynas Duburas deleted branch fix-curves-handle-drawing 2024-06-13 20:14:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Jacques Lucke
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122803
No description provided.
Delete Branch "laurynas/blender:fix-curves-handle-drawing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?