WIP: anim/baklava-action-editor-bindings-and-camera-binding-selector #122834

Sybren A. Stüvel · 2024-06-06T17:03:02+02:00

Sybren A. Stüvel commented

2024-06-06 17:03:02 +02:00

Merge #122500 and #122672 in one branch, for demo'ing at the module meeting.

Sybren A. Stüvel added the

Module

Animation & Rigging

label 2024-06-06 17:03:02 +02:00

Sybren A. Stüvel added 20 commits 2024-06-06 17:03:07 +02:00

WIP on a 'binding' selector in the UI 8fe1922284

- Rename the enum property `AnimData.action_binding` to
  `.action_binding_enum` to move it out of the way.
- Add a new pointer property `AnimData.action_binding`
- Use `template_search()` to show the selector

This has a few issues though:

- The `Binding.name` property is used for display & edit of the name.
  This should be using `name_display` instead.
- It doesn't seem to be possible to show an icon.
- `template_search()` eats up reports, so that choosing an incompatible
  binding is silently ignored (instead of showing the actual message).

Swap name property to name_display c8a43689de

Merge remote-tracking branch 'origin/main' into anim/baklava-binding-selector 5760816435

Add AnimData.action_bindings collection property cbb62fa14d

Merge remote-tracking branch 'origin/main' into anim/baklava-binding-selector a1ceb31e8d

Anim: Add struct icon for action bindings 7996343329

Add a temp icon for action bindings. This is now just the "link" icon,
which shouldn't be reused for this.

Anim: add Animation panel to Camera properties b2ab04a9b6

This is a proof-of-concept panel, to figure out how to present the
Action selector in object data property panels.

WIP: start of porting the Animation editor stuff to the Action editor 5dc82b8d4d

Doesn't work yet.

Bare minimum is working somewhat (unit test + Action dopesheet mode) 615e23aa3e

Moar porting of the old Animation mode for dopesheet e13b96ca78

Add separate filter mode to show all Bindings in the Action editor 9cfcb02c68

Merge remote-tracking branch 'origin/main' into anim/baklava-action-editor-bindings 85de4fc60e

Add missing include 7c69ffd668

Merge remote-tracking branch 'origin/main' into anim/baklava-binding-selector b6aeae4ea7

Hackishly get Action selector in the Camera properties panel c89a6201b1

Merge remote-tracking branch 'origin/main' into anim/baklava-binding-selector 0139c16fed

Merge remote-tracking branch 'origin/main' into anim/baklava-action-editor-bindings bd6b621c5e

Anim: use Binding display name in dope sheet 5f66b7a5a9

Use the binding's display name in the dope sheet channel list, rather than
its internal name.

Anim: avoid crash when switching to the graph editor 421aa0b3b1

The anim filtering code for bindings was not respecting the
`ANIMFILTER_FCURVESONLY` flag, and thus always returning an
`bAnimListElem` for the binding itself.

Now, if the flag is there, it ignores the binding's expansion state, and
then always produces elements for the FCurves for that binding.

Merge branch 'anim/baklava-binding-selector' into anim/baklava-action-editor-bindings-and-camera-binding-selector

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.