Fix #122423: Clear Handlers for Non-Temporary Regions on Exit #122922

Harley Acheson · 2024-06-08T17:27:47+02:00

Harley Acheson commented

2024-06-08 17:27:47 +02:00

On Region exit ensure that operator handler pointers to it are set to
nullptr. Currently this is happening only for temporary region UI
handlers.

Testing must be in debug mode.

When joining screen areas, one area and its regions will be removed. With the changes in b25eefbf9a the closed regions will not have operator handler pointers cleared. wm_gizmomaps_handled_modal_update tries to detect this situation (has a comment of "Happens on render or when joining areas") by checking if the handler's region is null and will early return. Unfortunately this test passes because the region pointer is not cleared, pointing at deallocated ram. Then it dies trying to get that region's gizmo map.

The referenced commit replaced the region handler clearing with a new one that is only run for RGN_TYPE_TEMPORARY regions. This PR puts back the old call to WM_event_modal_handler_region_replace afterward. This fixes the errors when joining areas and does not seem to affect anything shown in #122132, but I am not running ASAN. This also seems related to #120612 and wasn't sure how to test that.

On Region exit ensure that operator handler pointers to it are set to nullptr. Currently this is happening only for temporary region UI handlers. --- Testing must be in debug mode. When joining screen areas, one area and its regions will be removed. With the changes in b25eefbf9acb51df61bb264686d9da42d2499e18 the closed regions will not have operator handler pointers cleared. `wm_gizmomaps_handled_modal_update` tries to detect this situation (has a comment of "Happens on render or when joining areas") by checking if the handler's region is null and will early return. Unfortunately this test passes because the region pointer is not cleared, pointing at deallocated ram. Then it dies trying to get that region's gizmo map. The referenced commit replaced the region handler clearing with a new one that is only run for RGN_TYPE_TEMPORARY regions. This PR puts back the old call to `WM_event_modal_handler_region_replace` afterward. This fixes the errors when joining areas and does not seem to affect anything shown in #122132, but I am not running ASAN. This also seems related to #120612 and wasn't sure how to test that.

Harley Acheson added this to the User Interface project 2024-06-08 17:28:14 +02:00

Harley Acheson requested review from Campbell Barton 2024-06-08 17:28:22 +02:00

Harley Acheson force-pushed Fix122423b from 5707074bdc to aa77a28fa6

2024-06-08 17:39:34 +02:00

Compare

Harley Acheson changed target branch from main to blender-v4.2-release

2024-06-08 17:40:05 +02:00

Harley Acheson added this to the 4.3 milestone 2024-06-08 17:48:23 +02:00

Harley Acheson modified the milestone from 4.3 to 4.2 LTS

2024-06-08 17:48:34 +02:00

Harley Acheson changed title from ~~Fix #122423 - Clear Handlers for Non-Temporary Regions on Exit~~ to Fix #122423: Clear Handlers for Non-Temporary Regions on Exit

2024-06-08 22:47:35 +02:00

Harley Acheson force-pushed Fix122423b from aa77a28fa6 to 62277f00c7

2024-06-18 19:54:19 +02:00

Compare

Campbell Barton referenced this issue from a commit

2024-06-19 01:50:06 +02:00

Fix #122423: Clear handlers for non-temporary regions on exit

Campbell Barton approved these changes 2024-06-19 01:50:09 +02:00

Campbell Barton manually merged commit ad625d8dc4 into blender-v4.2-release

2024-06-19 01:58:07 +02:00

Harley Acheson deleted branch Fix122423b

2024-06-19 03:34:41 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #122423: Clear Handlers for Non-Temporary Regions on Exit #122922