GPv3: Render evaluated geometry #122985
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#122985
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "casey-bianco-davis/blender:GPv3-Curve-Geometry-Overlay"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is for rendered geometry and does not apply for edit mode overlays.
Note: This is hard to test without #122966
Sorry if this is dumb question, but when recently Bezier drawing and editing was implemented for Curves type I thought it was for grease pencil too? Don't they share CurvesGeometry?
They do share
CurvesGeometry
but the evaluated geometry was not being sent to the GPU, nor the triangulation; that's what this PR does.@ -314,3 +314,3 @@
const bke::CurvesGeometry &curves = info.drawing.strokes();
const OffsetIndices<int> points_by_curve = curves.points_by_curve();
const OffsetIndices<int> eval_points_by_curve = curves.evaluated_points_by_curve();
If there is no other variable called
points_by_curve
, no need to change the variable name here. Same with elsewhere.@ -580,2 +580,4 @@
}
template<typename T>
static Array<T> attribute_interpolate(const VArray<T> input, const bke::CurvesGeometry &curves)
It's important to avoid allocating a separate array for points if there are only poly curves in the drawing.
For that I suggest passing the array as a reference argument and returning a VArray that either references the original or the newly allocated and filled array.
GPv3: Display bézier geometry.to GPv3: Display Bézier geometryeval_points_by_curve
topoints_by_curve
3fcda1d9c5@ -629,3 +641,2 @@
if (visible_strokes.contains(curve_i)) {
tris_start_offsets[pos] = t_offset;
pos++;
tris_start_offsets[pos++] = t_offset;
This change is unrelated, best to just leave it out. Personally I choose to increment variables on separate lines just so the order is more obvious at a glance.
Code looks good to me. Nice that this is such a small change.
I'm getting some memory leaks when I tried this out:
@casey-bianco-davis anything you wouldn't expect here?
With this change, loading files from GPv2 that used curve editng with bezier curves look correct now :)
I could not get memory errors to occur.
@filedescriptor The log you got appears to be mentioning code unrelated to this PR, but as I cannot replicate the error I am not sure.
@blender-bot build
GPv3: Display Bézier geometryto GPv3: Render evaluated geometry