Fix #123576: VSE Crash: Preview render fails if two Scene strips are stacked #123731

Sergey Sharybin · 2024-06-25T16:14:56+02:00

Sergey Sharybin commented

2024-06-25 16:14:56 +02:00

The issue was caused by the ImBuf of the scene strip render sharing the float
buffer pixels with the ImBuf from the render result. If the render result is
ever gets freed (i.e., by a request to perform another render) it'll leave the
strip ImBuf pointing to a freed memory.

This was caused by the #109788.

The simple solution is to restore the code to the state prior to the ImBuf
refactor in the RenderRsult. A better solution would be to use implicit
sharing, similar to how it was done in the #108045.

The issue was caused by the ImBuf of the scene strip render sharing the float buffer pixels with the ImBuf from the render result. If the render result is ever gets freed (i.e., by a request to perform another render) it'll leave the strip ImBuf pointing to a freed memory. This was caused by the #109788. The simple solution is to restore the code to the state prior to the ImBuf refactor in the RenderRsult. A better solution would be to use implicit sharing, similar to how it was done in the #108045.

Sergey Sharybin added 1 commit 2024-06-25 16:15:04 +02:00

Fix #123576 : VSE Crash: Preview render fails if two Scene strips are stacked 4f25737983

The issue was caused by the ImBuf of the scene strip render sharing the float
buffer pixels with the ImBuf from the render result. If the render result is
ever gets freed (i.e., by a request to perform another render) it'll leave the
strip ImBuf pointing to a freed memory.

This was caused by the #109788.

The simple solution is to restore the code to the state prior to the ImBuf
refactor in the RenderRsult. A better solution would be to use implicit
sharing, similar to how it was done in the #108045.

Sergey Sharybin requested review from Brecht Van Lommel 2024-06-25 16:15:41 +02:00

Brecht Van Lommel approved these changes 2024-06-25 16:55:28 +02:00

Sergey Sharybin merged commit 0081c4b64a into blender-v4.2-release

2024-06-26 09:58:59 +02:00

Sergey Sharybin referenced this issue from a commit

2024-06-26 09:59:00 +02:00

Fix #123576: VSE Crash: Preview render fails if two Scene strips are stacked

Sergey Sharybin deleted branch fix_123576

2024-06-26 09:59:13 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #123576: VSE Crash: Preview render fails if two Scene strips are stacked #123731