VSE: Standardize reset retiming operator #123973

John Kiril Swenson · 2024-07-01T02:40:42+02:00

2024-07-01 02:40:42 +02:00

Every retiming operator works on selected items -- either just selected
retiming keys or retiming keys and selected strips. However, the reset
retiming operator only works on the active strip.

This patch standardizes the behavior so that reset works the same
way as the other retiming operators: All selected strips or strips
associated with selected retiming keys have their retiming reset.
This gives more control to the user to reset many strips' retiming in bulk.

Every retiming operator works on selected items -- either just selected retiming keys or retiming keys and selected strips. However, the reset retiming operator only works on the active strip. This patch standardizes the behavior so that reset works the same way as the other retiming operators: All selected strips or strips associated with selected retiming keys have their retiming reset. This gives more control to the user to reset many strips' retiming in bulk.

John Kiril Swenson added 1 commit 2024-07-01 02:41:00 +02:00

VSE: Standardize reset retiming operator 880818f90c

Every retiming operator works on selected items -- either just selected
retiming keys or retiming keys and selected strips. However, the reset
retiming operator only works on the active strip.

This patch standardizes the behavior so that reset retiming works the
same way as the other retiming operators. This gives more control to the
user to reset many strips' retiming in bulk.

John Kiril Swenson requested review from Richard Antalik 2024-07-01 02:41:21 +02:00

John Kiril Swenson requested review from Aras Pranckevicius 2024-07-01 02:43:54 +02:00

John Kiril Swenson added 1 commit 2024-07-01 03:07:05 +02:00

Move retiming_key_overlap to Retiming Reset 0f3b3fb10d

John Kiril Swenson added 1 commit 2024-07-01 04:20:59 +02:00

Add check to make sure retiming is allowed 2682252256

John Kiril Swenson referenced this pull request

2024-07-01 05:10:23 +02:00

VSE: Fix retiming menu polling #123979

Richard Antalik requested changes 2024-07-01 20:19:04 +02:00

Dismissed

Richard Antalik left a comment

The reset retiming operator is not supposed to run when "retiming mode" (some key is selected) is active.

I would make this run purely on normal selection. IMO key selection is bad and error prone proxy to strip selection. Also not sure if this would be beneficial for any workflow.

The reset retiming operator is not supposed to run when "retiming mode" (some key is selected) is active. I would make this run purely on normal selection. IMO key selection is bad and error prone proxy to strip selection. Also not sure if this would be beneficial for any workflow.

👍 1

John Kiril Swenson added 1 commit 2024-07-01 22:10:22 +02:00

Change reset operator to only work on strip sel 581839625f

John Kiril Swenson commented

2024-07-01 22:13:36 +02:00

The reset retiming operator is not supposed to run when "retiming mode" (some key is selected) is active.

I would make this run purely on normal selection. IMO key selection is bad and error prone proxy to strip selection. Also not sure if this would be beneficial for any workflow.

True, I've made the changes.

It may not make much of a difference but by standardizing the behavior hopefully it can be a little less confusing to new users, and give the ability to reset two+ strips at once without much headache. When trying out this operator for the first time I couldn't quite figure out which strips it was targeting since the behavior was different than other retiming ops.

> The reset retiming operator is not supposed to run when "retiming mode" (some key is selected) is active. > > I would make this run purely on normal selection. IMO key selection is bad and error prone proxy to strip selection. Also not sure if this would be beneficial for any workflow. True, I've made the changes. It may not make much of a difference but by standardizing the behavior hopefully it can be a little less confusing to new users, and give the ability to reset two+ strips at once without much headache. When trying out this operator for the first time I couldn't quite figure out which strips it was targeting since the behavior was different than other retiming ops.

Richard Antalik approved these changes 2024-07-01 22:27:58 +02:00

Richard Antalik merged commit 607445da5f into blender-v4.2-release

2024-07-01 23:13:04 +02:00

Richard Antalik referenced this issue from a commit

2024-07-01 23:13:06 +02:00

VSE: Standardize reset retiming operator

John Kiril Swenson deleted branch vse-improve-reset-retiming

2024-07-02 00:58:10 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: Standardize reset retiming operator #123973