Fix #124161: Interacting During Startup Can Crash Blender #124258

Harley Acheson · 2024-07-05T20:18:31+02:00

Harley Acheson commented

2024-07-05 20:18:31 +02:00

If you left-button drag your mouse while Blender is loading (on the
empty grey screen) it can cause crashes in File Browser, Asset Browser,
and Outliner. This PR just adds error checking to avoid this in every
way I could make this occur.

If you left-button drag your mouse while Blender is loading (on the empty grey screen) it can cause crashes in File Browser, Asset Browser, and Outliner. This PR just adds error checking to avoid this in every way I could make this occur.

Harley Acheson added 1 commit 2024-07-05 20:18:42 +02:00

Fix #124161 : Interacting During Startup Can Crash Blender 7a220391ff

If you left-button drag your mouse while Blender is loading (on the
empty grey screen) it can cause crashes in File Browser, Asset Browser,
and Outliner. This PR just adds error checking to avoid this in every
way I could make this occur.

Harley Acheson added this to the Module: User Interface project 2024-07-05 20:18:58 +02:00

Harley Acheson requested review from Hans Goudey 2024-07-05 20:19:05 +02:00

Hans Goudey reviewed 2024-07-08 14:41:23 +02:00

Hans Goudey left a comment

It seems like it might be better to check for this at a higher level, like in the event handling code. The specific operators that are fixed in this PR don't look very special, so I'm guessing the problem would exist in other areas too.

Hans Goudey requested review from Hans Goudey 2024-07-08 14:41:37 +02:00

Julian Eisel commented

2024-07-09 17:30:41 +02:00

Can't recreate this (didn't try that hard), but I wonder if this works (and if it's a good way to go about it).

Can't recreate this (didn't try that hard), but I wonder if [this](https://pablovazquez.art/paste/#XQAAAQATCAAAAAAAAAAyGkkJwvwRfVDeCk9H2SRoLFgzPWJpxeINRgxFqCtNibsN+okSNS2BCMdY36XhNoG61ctbRPeaeC2QNsHce144v6jo7PzG5qiqBK4li9CHfBrF7Ds4bPfIK7hJszoUg3XAw9gHj8EbJWZHMfCcavMfqH3/My0wYm+NLJpDH9YdbENh3L+AEZCzcuuKTL1AgsfyWyfwfH+/oKxYO7jiAwvnZJax6Okdl17BjD9Djh4NGE4kx15FeHDckB9d98VJR5fWU4kwDeG2XLL0KA9r1BcTTKti3IJSpjz8yTEMlKYuxTKkwZQYAMRMzrlu7e2dpyI8qNsqD/D4+ToKTGhDbOAbQWhlVHbzIcMR496vauUdykROpQ4nKKjBeTHym7WeQSMWwXc/OXFOg/zHpaXROfpVUOesDvmt7tk52dNAzWs43nZnZ8VK4s8HsG6Cy5XFFWu2maMWMt5eG6RuEc3/MbQv8tzP+DCSpy0EEbug2tsh/MYMqgzjrkDmskp4BKdNDgLn/AZZtZzEFaTT8ghiK88RypVimjehmQrF0NUTyn093qkob6gJkdOVV2kti+L5ZrKcRR+TNP0vizX89Hvpwjn1Y6F6yU8RldgZrEe7/ss32L4aShHNlDI1KbQ4T0+I6NRi8l6wbu2ftvf7+FFEAJ9k8sMM7FdsOX+QFxhN99+3d26VL3qyqrPQDNxuKfUy2MdinPoBfEvr7+M0zDVxFsEPD4h4GvpVxVwo0TKdV7gZOB9MCt6YzhacYwsEtBg5/x7lavMwCP5TFs5WrxME6S2onZp2Q7cJ/6bGQiErDMb+/+oqSv58OG53brGkXogx9Zrv0xAYSEkQcknOJXtge3FV56INvpDGar8XC775DMCq0si2NLqMxP5803sCRzaJiiemB7vNABBWQqI4y98pxTHqFfnvNfhFrQToo1XdG7E4dfaEgSs737v/DGk0GIkW+u9vwQOUuvlJrfEAypuBF96pqe6dmI0xDvnrOBkO3OyuZ4wYVGy9T0yMSFurDiFi0cVsp/2msfY=) works (and if it's a good way to go about it).

Harley Acheson commented

2024-07-09 17:53:12 +02:00

@JulianEisel

I have gotten pretty good at recreating this - basically a drag selection during load - so will give your idea a check in main. This issue is fairly obscure, hard to reproduce, easy to avoid, and would have existed a long time.

@JulianEisel I have gotten pretty good at recreating this - basically a drag selection during load - so will give your idea a check in main. This issue is fairly obscure, hard to reproduce, easy to avoid, and would have existed a long time.

Harley Acheson commented

2024-07-09 18:52:12 +02:00

@JulianEisel - Can't recreate this (didn't try that hard)...

It is quite difficult to recreate. I just set my default layout so it contains just a File Browser, Asset Browser and Outliner. During startup - while it is still showing a grey screen - do left-mouse drags like for selection.

I wonder if this works (and if it's a good way to go about it).

The changes in area_query make sense. They do get hit during normal operation, which is great since we don't need to consider hidden regions there. So this is probably a good idea.

The change in wm_event_system.cc I couldn't get to hit no matter how hard I tried.

With that applied the errors in the complaint still occurred though. With File Browser we are in file_select_exec with sfile->layout being nullptr. In Outliner it can be various things, but all I could repeat just now was outliner_shows_mode_column with space_outliner.runtime.tree_display as nullptr.

> @JulianEisel - Can't recreate this (didn't try that hard)... It is quite difficult to recreate. I just set my default layout so it contains just a File Browser, Asset Browser and Outliner. During startup - while it is still showing a grey screen - do left-mouse drags like for selection. > I wonder if this works (and if it's a good way to go about it). The changes in area_query make sense. They do get hit during normal operation, which is great since we don't need to consider hidden regions there. So this is probably a good idea. The change in wm_event_system.cc I couldn't get to hit no matter how hard I tried. With that applied the errors in the complaint still occurred though. With File Browser we are in `file_select_exec` with sfile->layout being nullptr. In Outliner it can be various things, but all I could repeat just now was `outliner_shows_mode_column` with space_outliner.runtime.tree_display as nullptr.

Julian Eisel referenced this pull request

2024-07-30 13:02:33 +02:00

Crash when interacting with window while blender is starting #124161

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u Fix24161:Harley-Fix24161

git checkout Harley-Fix24161

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #124161: Interacting During Startup Can Crash Blender #124258

Checkout