Cleanup: Restructure and rename relax_face_sets.cc #124563

Sean Kim · 2024-07-12T01:32:47+02:00

Sean Kim commented

2024-07-12 01:32:47 +02:00

In preparation for the topology relax brush which shares much of this
code, this commit renames the file and distinguishes between methods
that will and will not be shared between the topology relax and face set
relax brushes.

In preparation for the topology relax brush which shares much of this code, this commit renames the file and distinguishes between methods that will and will not be shared between the topology relax and face set relax brushes.

Sean Kim added 1 commit 2024-07-12 01:32:58 +02:00

Cleanup: Restructure and rename relax_face_sets.cc 82e6d37e60

In preparation for the topology relax brush which shares much of this
code, this commit renames the file and distinguishes between methods
that will and will not be shared between the topology relax and face set
relax brushes.

Sean Kim requested review from Hans Goudey 2024-07-12 01:33:14 +02:00

Sean Kim reviewed 2024-07-12 01:34:32 +02:00

source/blender/editors/sculpt_paint/brushes/relax.cc Outdated

						
				@ -0,0 +610,4 @@

				}  // namespace relax_cc

				inline namespace relax_face_set {

Sean Kim commented

2024-07-12 01:34:32 +02:00

Not sure if this should be nested inside relax_cc or separate from it like it currently is, thoughts?

Not sure if this should be nested inside `relax_cc` or separate from it like it currently is, thoughts?

Hans Goudey commented

2024-07-12 02:49:38 +02:00

I'd include everything besides the public functions at the bottom in the relax_cc namespace, which is mostly just for unity builds

I'd include everything besides the public functions at the bottom in the `relax_cc` namespace, which is mostly just for unity builds

Sean-Kim marked this conversation as resolved

Hans Goudey approved these changes 2024-07-12 02:49:42 +02:00

Sean Kim added 1 commit 2024-07-12 05:19:05 +02:00

Reorganize and remove the extra namespace, add doxygen sections fc404d1292

Sean Kim merged commit 70d6926ab9 into main

2024-07-12 05:24:43 +02:00

Sean Kim referenced this issue from a commit

2024-07-12 05:24:45 +02:00

Cleanup: Restructure and rename relax_face_sets.cc

Sean Kim deleted branch restructure-relax

2024-07-12 05:24:47 +02:00

Jack Kurtz referenced this issue from a commit

2024-07-13 09:11:05 +02:00

Cleanup: Restructure and rename relax_face_sets.cc

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cleanup: Restructure and rename relax_face_sets.cc #124563