VSE: Fix glitchy handle select for adjacent strips #124708

John Kiril Swenson · 2024-07-15T06:15:03+02:00

2024-07-15 06:15:03 +02:00

For very small hotspot regions when trying to select handles on adjacent
strips, selection can sometimes jump to the strip farthest away from the
current mouse cursor position. This happens regardless of "Tweak
Handles" setting, but is most noticeable when it is off.

In the case that two strips are selected at once (which is possible
because internally strip handles are shifted away from the strip body by
a third of the handle size), mouseover_strips_sorted_get attempts to
sort these strips to maintain priority, but the logic was backwards --
fix the glitch by sorting strips such that the first strip in the
Vector is always the strip closest to the mouse cursor.

Before	After

For very small hotspot regions when trying to select handles on adjacent strips, selection can sometimes jump to the strip farthest away from the current mouse cursor position. This happens regardless of "Tweak Handles" setting, but is most noticeable when it is off. In the case that two strips are selected at once (which is possible because internally strip handles are shifted away from the strip body by a third of the handle size), `mouseover_strips_sorted_get` attempts to sort these strips to maintain priority, but the logic was backwards -- fix the glitch by sorting strips such that the first strip in the `Vector` is always the strip closest to the mouse cursor. |Before|After| |---|---| |![glitchy-handle-select-before.gif](/attachments/e2609b92-998b-4cdd-bafe-06b4bc28fb45)|![glitchy-handle-select-after.gif](/attachments/4b3b0b02-a59c-4ae9-b7cd-12e118a93e9b)|

glitchy-handle-select-before.gif

34 KiB

glitchy-handle-select-after.gif

29 KiB

❤️ 2

John Kiril Swenson added 1 commit 2024-07-15 06:15:13 +02:00

VSE: Fix glitchy handle select for adjacent strips 925009d7b9

For very small hotspot regions when trying to select handles on adjacent
strips, selection can sometimes jump to the strip farthest away from the
current mouse cursor position. This happens regardless of "Tweak
Handles" setting, but is most noticeable when it is off.

In the case that two strips are selected at once (which is possible
because internally strip handles are shifted away from the strip body by
a third of the handle size), `mouseover_strips_sorted_get` attempts to
sort these strips to maintain priority, but the logic was backwards --
fix the glitch by sorting strips such that the first strip in the
`Vector` is always the strip closest to the mouse cursor.

John Kiril Swenson requested review from Aras Pranckevicius 2024-07-15 06:15:52 +02:00

John Kiril Swenson requested review from Richard Antalik 2024-07-15 07:19:24 +02:00

Aras Pranckevicius approved these changes 2024-07-15 08:56:25 +02:00

Aras Pranckevicius left a comment

Nice catch!

Richard Antalik approved these changes 2024-07-16 11:33:15 +02:00

Richard Antalik merged commit 471a148666 into main

2024-07-16 12:25:30 +02:00

Richard Antalik referenced this issue from a commit

2024-07-16 12:25:31 +02:00

VSE: Fix glitchy handle select for adjacent strips

John Kiril Swenson deleted branch vse-fix-glitchy-handle-sel

2024-07-16 20:04:24 +02:00

Philipp Oeser referenced this issue from a commit

2024-07-25 16:47:20 +02:00

VSE: Fix glitchy handle select for adjacent strips

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: Fix glitchy handle select for adjacent strips #124708