Fix #125006: crash confirming specific operator popup dialog with ENTER #125085

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:125006 into main 2024-07-22 11:43:24 +02:00
Member

Crash was happening in this scenario:

  • mouse was over a property in the dialog
  • operator had a "check" callback that was accessing certain operator
    stuff

In this case, the UI_BUT_ACTIVE_DEFAULT button was executed, operator
finished or canceled (but stuff was freed along the way), then code
kicked in to still handle ENTER over the property in the popup (e.g.
toggle a checkbox), the uiAfterFunc still had the popup_op, tried to
run popup_check again with the faulty data.

Simple way to fix this is to use WM_UI_HANDLER_BREAK to not handle
further buttons after executing the UI_BUT_ACTIVE_DEFAULT

Crash was happening in this scenario: - mouse was over a property in the dialog - operator had a "check" callback that was accessing certain operator stuff In this case, the `UI_BUT_ACTIVE_DEFAULT` button was executed, operator finished or canceled (but stuff was freed along the way), then code kicked in to still handle ENTER over the property in the popup (e.g. toggle a checkbox), the `uiAfterFunc` still had the `popup_op`, tried to run `popup_check` again with the faulty data. Simple way to fix this is to use `WM_UI_HANDLER_BREAK` to not handle further buttons after executing the `UI_BUT_ACTIVE_DEFAULT`
Philipp Oeser added 1 commit 2024-07-19 16:50:32 +02:00
Crash was happening in this scenario:
- mouse was over a property in the dialog
- operator had a "check" callback that was accessing certain operator
stuff

In this case, the `UI_BUT_ACTIVE_DEFAULT` button was executed, operator
finished or canceled (but stuff was freed along the way), then code
kicked in to still handle ENTER over the property in the popup (e.g.
toggle a checkbox), the `uiAfterFunc` still had the `popup_op`, tried to
run `popup_check` again with the faulty data.

Simple way to fix this is to use `WM_UI_HANDLER_BREAK` to not handle
further buttons after executing the `UI_BUT_ACTIVE_DEFAULT`
Philipp Oeser added this to the User Interface project 2024-07-19 16:50:49 +02:00
Philipp Oeser requested review from Julian Eisel 2024-07-19 16:51:00 +02:00
Philipp Oeser requested review from Campbell Barton 2024-07-19 16:51:06 +02:00
Philipp Oeser requested review from Bastien Montagne 2024-07-19 16:51:32 +02:00
Campbell Barton approved these changes 2024-07-20 00:53:38 +02:00
Julian Eisel approved these changes 2024-07-22 11:02:47 +02:00
Philipp Oeser merged commit d5d64f4a9f into main 2024-07-22 11:43:24 +02:00
Philipp Oeser deleted branch 125006 2024-07-22 11:43:28 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#125085
No description provided.