Fix: Geometry Nodes: Correct node sockets description #126166

Open
Iliya Katushenock wants to merge 1 commits from mod_moder/blender:fix_edge_angle_tooltip_2 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Correct tooltip of Edge Angle node.

"angle in radians between"

There is no reason to point the units of the value.
This does depend on the subtype of the socket.

"where they meet at an edge"

Here is 2 way to compute face normal: average normal for all surface or normal
of triangle which is a part of the surface.
If you say that the normal is from place where they meet at an edge then i'd
treat this as using the normal of the triangle which is the nearest part of the
fact to the edge. But this is just wrong (based on the code). For the reason,
just say that this is face normal which is generally accepted as just average normal of any n-gon.

"Flat edges and Non-manifold edges"

Since the normal is computed as average for whole the face, its more clear
to say that face have to be flat or manifold. Second part is that Flat can
be destructive which is produce other result, so add note for that.

Computing this value is faster than the signed angle"

No reason to point speed measurement in a tooltip, this is different features in any case.

Correct tooltip of Edge Angle node. > "angle in radians between" There is no reason to point the units of the value. This does depend on the subtype of the socket. > "where they meet at an edge" Here is 2 way to compute face normal: average normal for all surface or normal of triangle which is a part of the surface. If you say that the normal is from place `where they meet at an edge` then i'd treat this as using the normal of the triangle which is the nearest part of the fact to the edge. But this is just wrong (based on the code). For the reason, just say that this is face normal which is generally accepted as just average normal of any n-gon. > "Flat edges and Non-manifold edges" Since the normal is computed as average for whole the face, its more clear to say that face have to be flat or manifold. Second part is that `Flat` can be destructive which is produce other result, so add note for that. > Computing this value is faster than the signed angle" No reason to point speed measurement in a tooltip, this is different features in any case.
Iliya Katushenock added the
Interest
Geometry Nodes
Module
User Interface
labels 2024-08-10 01:56:25 +02:00
Iliya Katushenock added 1 commit 2024-08-10 01:56:31 +02:00
Iliya Katushenock added this to the Nodes & Physics project 2024-08-10 01:56:37 +02:00
Iliya Katushenock requested review from Hans Goudey 2024-08-10 01:56:42 +02:00
Merge conflict checking is in progress. Try again in few moments.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix_edge_angle_tooltip_2:mod_moder-fix_edge_angle_tooltip_2
git checkout mod_moder-fix_edge_angle_tooltip_2
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#126166
No description provided.