blender/blender

Presets: consider presets in the path registry as built-in #126176

Closed

Damien Picard wants to merge 1 commits from pioverfour:dp_builtin_extension_presets into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Damien Picard commented

2024-08-10 13:08:50 +02:00

Member

Presets shipped with extensions can currently be removed. This
behavior is different from Blender's built-in presets, which is
confusing because once deleted they cannot be retrieved, except by
reinstalling the extension.

This change updates bpy.utils.is_path_builtin() to also check paths
in _preset_path_registry, and considering them built-in.

Presets shipped with extensions can currently be removed. This behavior is different from Blender's built-in presets, which is confusing because once deleted they cannot be retrieved, except by reinstalling the extension. This change updates `bpy.utils.is_path_builtin()` to also check paths in _preset_path_registry, and considering them built-in.

Damien Picard added the

label 2024-08-10 13:08:50 +02:00

Damien Picard added 1 commit 2024-08-10 13:09:05 +02:00

Presets: consider presets in the path registry as built-in 96364ffda5

Presets shipped with extensions can currently be removed. This
behavior is different from Blender's built-in presets, which is
confusing because once deleted they cannot be retrieved, except by
reinstalling the extension.

This change updates `bpy.utils.is_path_builtin()` to also check paths
in _preset_path_registry, and considering them built-in.

Damien Picard requested review from Campbell Barton 2024-08-10 13:12:37 +02:00

Campbell Barton commented

2024-08-15 08:29:07 +02:00

Owner

Thanks for the PR, I agree with the basic change but I don't think it's correct to consider all presets "builtin".

I've committed changes that consider all extension paths to be built-in when used with presets.

Changes split into 3 commits:

Thanks for the PR, I agree with the basic change but I don't think it's correct to consider all presets "builtin". I've committed changes that consider all extension paths to be built-in when used with presets. Changes split into 3 commits: - 5f9be675f072d7883e7b78a4555123034ce3bd75 - f42713ab1d1163fae65cb265fd7b5e2d261aab60 - 9f931ee3d266551ba33a9e92a2796f0ccc97ee9e

Campbell Barton closed this pull request

2024-08-15 08:29:10 +02:00

Damien Picard deleted branch dp_builtin_extension_presets

2024-08-15 14:41:36 +02:00

Damien Picard commented

2024-08-15 14:42:24 +02:00

Author

Member

Thanks, Campbell!

Thanks, Campbell!

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#126176

No description provided.